feat: add UpdateRegistry msg for gov proposal to update the token registry

[gsk967]

Description

closes: #1001

This pull request contains below changes:

1. Removed leverage proposal handler for update registry
2. Add MsgGovUpdateRegistry
3. Add UpdateRegistry Proposal from gov tx
4. Add tests for MsgGovUpdateRegistry in msg_server

Sample proposal.json for submit the proposal from gov

Note : creator address will be the gov module address

{
    "messages": [
        {
            "@type": "/umee.leverage.v1.MsgGovUpdateRegistry",
            "authority": "umee10d07y265gmmuvt4z0w9aw880jnsr700jg5w6jp",
            "title": "Update the Leverage Token Registry",
            "description": "Update the uumee token in the leverage registry.",
            "add_tokens": [
                {
                    "base_denom": "uumee",
                    "reserve_factor": "0.100000000000000000",
                    "collateral_weight": "0.050000000000000000",
                    "liquidation_threshold": "0.050000000000000000",
                    "base_borrow_rate": "0.020000000000000000",
                    "kink_borrow_rate": "0.200000000000000000",
                    "max_borrow_rate": "1.500000000000000000",
                    "kink_utilization": "0.200000000000000000",
                    "liquidation_incentive": "0.100000000000000000",
                    "symbol_denom": "UMEE",
                    "exponent": 6,
                    "enable_msg_supply": true,
                    "enable_msg_borrow": true,
                    "blacklist": false,
                    "max_collateral_share": "0.900000000000000000",
                    "max_supply_utilization": "0.900000000000000000",
                    "min_collateral_liquidity": "0.900000000000000000",
                    "max_supply": "123123"
                },
            ],
            "update_tokens": [
                {
                    "base_denom": "uatom",
                    "reserve_factor": "0.100000000000000000",
                    "collateral_weight": "0.050000000000000000",
                    "liquidation_threshold": "0.050000000000000000",
                    "base_borrow_rate": "0.020000000000000000",
                    "kink_borrow_rate": "0.200000000000000000",
                    "max_borrow_rate": "1.500000000000000000",
                    "kink_utilization": "0.200000000000000000",
                    "liquidation_incentive": "0.100000000000000000",
                    "symbol_denom": "ATOM",
                    "exponent": 6,
                    "enable_msg_supply": true,
                    "enable_msg_borrow": true,
                    "blacklist": false,
                    "max_collateral_share": "0.900000000000000000",
                    "max_supply_utilization": "0.900000000000000000",
                    "min_collateral_liquidity": "0.900000000000000000",
                    "max_supply": "123123"
                },
            ]
        }
    ],
    "metadata": "AQ==",
    "deposit": "100uumee"
}

---

Author Checklist

All items are required. Please add a note to the item if the item is not applicable and
please add links to any relevant follow up issues.

I have...

• included the correct type prefix in the PR title
• added ! to the type prefix if API or client breaking change
• added appropriate labels to the PR
• targeted the correct branch (see PR Targeting)
• provided a link to the relevant issue or specification
• added a changelog entry to CHANGELOG.md
• included comments for documenting Go code
• updated the relevant documentation or specification
• reviewed "Files changed" and left comments if necessary
• confirmed all CI checks have passed

Reviewers Checklist

All items are required. Please add a note if the item is not applicable and please add
your handle next to the items reviewed if you only reviewed selected items.

I have...

• confirmed the correct type prefix in the PR title
• confirmed all author checklist items have been addressed
• reviewed state machine logic
• reviewed API design and naming
• reviewed documentation is accurate
• reviewed tests and test coverage
• manually tested (if applicable)

[codecov-commenter]

Codecov Report

Merging #1486 (88794b3) into main (b40ed0d) will increase coverage by 2.86%.
The diff coverage is 38.93%.

@@            Coverage Diff             @@
##             main    #1486      +/-   ##
==========================================
+ Coverage   52.47%   55.33%   +2.86%     
==========================================
  Files          73       66       -7     
  Lines        7040     6636     -404     
==========================================
- Hits         3694     3672      -22     
+ Misses       3073     2691     -382     
  Partials      273      273              

Impacted Files	Coverage Δ
x/leverage/types/msgs.go	4.61% <4.61%> (ø)
x/leverage/types/codec.go	48.27% <50.00%> (+5.85%)	⬆️
x/leverage/keeper/token.go	72.72% <68.42%> (-3.28%)	⬇️
x/leverage/keeper/keeper.go	66.28% <100.00%> (+0.12%)	⬆️
x/leverage/keeper/msg_server.go	11.91% <100.00%> (+10.95%)	⬆️
x/leverage/client/cli/tx.go
x/leverage/module.go
x/leverage/genesis.go
x/leverage/abci.go
x/leverage/client/cli/query.go

[gsk967]

@robert-zaremba should we remove NewCmdSubmitUpdateRegistryProposal from tx.go in leverage module and gov proposal handler from app.go ?

[toteki]

Could we make x/leverage follow the pattern seen elsewhere in the sdk, with

// GetAuthority returns the x/leverage module's authority.
func (k Keeper) GetAuthority() string {
	return k.authority
}

with k.authority set to authtypes.NewModuleAddress(govtypes.ModuleName).String()?

Similarly, MsgUpdateRegistry field Creator can be renamed to Authority and any mismatch should be rejected with err "expected gov account as only signer for proposal message"

See x/bank example

[toteki]

@robert-zaremba should we remove NewCmdSubmitUpdateRegistryProposal from tx.go in leverage module and gov proposal handler from app.go ?

The old proposal type can be removed in this PR, since we're adding the new one.

[gsk967]

@robert-zaremba should we remove NewCmdSubmitUpdateRegistryProposal from tx.go in leverage module and gov proposal handler from app.go ?

The old proposal type can be removed in this PR, since we're adding the new one.

Ok

[gsk967]

Could we make x/leverage follow the pattern seen elsewhere in the sdk, with

// GetAuthority returns the x/leverage module's authority.
func (k Keeper) GetAuthority() string {
	return k.authority
}

with k.authority set to authtypes.NewModuleAddress(govtypes.ModuleName).String()?

Similarly, MsgUpdateRegistry field Creator can be renamed to Authority and any mismatch should be rejected with err "expected gov account as only signer for proposal message"

See x/bank example

I updated the changes with authority

[robert-zaremba]

should we remove NewCmdSubmitUpdateRegistryProposal ...

Yes

[toteki]

This is looking good so far - would it be possible to create an example proposal to add to documentation?

Note: we should delay merging until after 3.1.0 release.

Removing blocker, but don't merge until after 3.1.0

[robert-zaremba]

I've made a suggestion to change the message behavior a bit. Also, let's put example proposal file in docs. This information should not be in infra because it should be available to the community.

[gsk967]

@toteki I removed remove functionality and updated Registry to Tokens

[toteki]

If you could

• document somewhere a an example CLI for creating this proposal type (possibly add it to the leverage spec or readme)
• and run a local test to make sure it executes as expected

then I think we can merge this.

Edit: There's also a failing test - needs the field Registry to be updated to its new name.

[gsk967]

@robert-zaremba @toteki now I moved addTokens to MsgAddTokensToRegistry message from updateRegistry , so now updateRegistry only do update the token setttings and addTokensRegistry only add tokens to registry

[toteki]

Following this comment on a separate PR, could we rename

MsgAddTokensToRegistry -> MsgGovRegisterTokens
and
MsgUpdateRegistry -> MsgGovUpdateRegistry
?

[robert-zaremba]

Almost there. Can we query an address of the gov account, rather than recreating it? (see comments)

[toteki]

Ran proto format to remove some extra whitespace. LGTM