Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: compute proper tx prioritization #1290

Merged
merged 8 commits into from
Aug 30, 2022
Merged

Conversation

robert-zaremba
Copy link
Member

Description

closes: #510


Author Checklist

All items are required. Please add a note to the item if the item is not applicable and
please add links to any relevant follow up issues.

I have...

  • included the correct type prefix in the PR title
  • added ! to the type prefix if API or client breaking change
  • added appropriate labels to the PR
  • targeted the correct branch (see PR Targeting)
  • provided a link to the relevant issue or specification
  • added a changelog entry to CHANGELOG.md
  • included comments for documenting Go code
  • updated the relevant documentation or specification
  • reviewed "Files changed" and left comments if necessary
  • confirmed all CI checks have passed

Reviewers Checklist

All items are required. Please add a note if the item is not applicable and please add
your handle next to the items reviewed if you only reviewed selected items.

I have...

  • confirmed the correct type prefix in the PR title
  • confirmed all author checklist items have been addressed
  • reviewed state machine logic
  • reviewed API design and naming
  • reviewed documentation is accurate
  • reviewed tests and test coverage
  • manually tested (if applicable)

@codecov-commenter
Copy link

codecov-commenter commented Aug 26, 2022

Codecov Report

Merging #1290 (82dbd22) into main (a8f403b) will increase coverage by 0.08%.
The diff coverage is 88.88%.

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #1290      +/-   ##
==========================================
+ Coverage   51.34%   51.43%   +0.08%     
==========================================
  Files          68       68              
  Lines        6834     6852      +18     
==========================================
+ Hits         3509     3524      +15     
- Misses       3067     3069       +2     
- Partials      258      259       +1     
Impacted Files Coverage Δ
ante/fee.go 89.74% <88.88%> (-1.93%) ⬇️

Copy link
Collaborator

@adamewozniak adamewozniak left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just some neatness here but this is much nicer 🥳

ante/fee.go Outdated Show resolved Hide resolved
ante/fee_unit_test.go Outdated Show resolved Hide resolved
@mergify mergify bot merged commit ba12f26 into main Aug 30, 2022
@mergify mergify bot deleted the robert/tx-prioritization branch August 30, 2022 10:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

x/oracle: Lack of prioritization for oracle messages
4 participants