Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: buf cosmos-sdk version #1408

Merged
merged 9 commits into from
Oct 7, 2022
Merged

fix: buf cosmos-sdk version #1408

merged 9 commits into from
Oct 7, 2022

Conversation

robert-zaremba
Copy link
Member

@robert-zaremba robert-zaremba commented Sep 18, 2022

Description

Continuation of #1397 (it was merged too early)

We need to find other way, because buf doesn't find past version we need, and the latest ones are not compatible.


Author Checklist

All items are required. Please add a note to the item if the item is not applicable and
please add links to any relevant follow up issues.

I have...

  • included the correct type prefix in the PR title
  • added ! to the type prefix if API or client breaking change
  • added appropriate labels to the PR
  • targeted the correct branch (see PR Targeting)
  • provided a link to the relevant issue or specification
  • added a changelog entry to CHANGELOG.md
  • included comments for documenting Go code
  • updated the relevant documentation or specification
  • reviewed "Files changed" and left comments if necessary
  • confirmed all CI checks have passed

Reviewers Checklist

All items are required. Please add a note if the item is not applicable and please add
your handle next to the items reviewed if you only reviewed selected items.

I have...

  • confirmed the correct type prefix in the PR title
  • confirmed all author checklist items have been addressed
  • reviewed state machine logic
  • reviewed API design and naming
  • reviewed documentation is accurate
  • reviewed tests and test coverage
  • manually tested (if applicable)

@robert-zaremba robert-zaremba changed the title Robert/fix buf fix: buf cosmos-sdk version Sep 18, 2022
@robert-zaremba robert-zaremba marked this pull request as ready for review October 6, 2022 22:39
@robert-zaremba robert-zaremba requested a review from a team as a code owner October 6, 2022 22:39
Copy link
Collaborator

@gsk967 gsk967 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Member

@toteki toteki left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Confirmed that this one correctly generates the proto files on main branch as well without diffs

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants