-
Notifications
You must be signed in to change notification settings - Fork 161
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: update th buf cache to get proto deps #1485
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The import overwrite are due to gogo proto version. Let's update gogo proto , and keep the cosmos-sdk commit from umee/main (af8...
)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Confirmed locally that running make proto-all
in this branch correctly generates the current proto files seen in main
branch with no diff.
Holding off on merge until discussing robert's comment though
EDIT: ... I finished that yesterday in #1408 but it was skipped in reviews. |
Let's merge both - both have same fix, but each has some side improvement. |
Checking up on the merge conflict - which version to use? |
@robert-zaremba should be we use latest commit for googleapis https://buf.build/googleapis/googleapis/commits/main |
Description
this pr will fix the
make proto-gen
,Note:
we need to update the commit for deps in buf config whenever we bump the cosmos-sdk version
We can get the commits for deps of buf https://github.com/cosmos/cosmos-sdk/blob/v0.46.2/client/v2/internal/buf.lock
Author Checklist
All items are required. Please add a note to the item if the item is not applicable and
please add links to any relevant follow up issues.
I have...
!
to the type prefix if API or client breaking changeCHANGELOG.md
Reviewers Checklist
All items are required. Please add a note if the item is not applicable and please add
your handle next to the items reviewed if you only reviewed selected items.
I have...