Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: use more store functions in incentive #2101

Merged
merged 10 commits into from
Jun 22, 2023
Merged

feat: use more store functions in incentive #2101

merged 10 commits into from
Jun 22, 2023

Conversation

robert-zaremba
Copy link
Member

Description

@robert-zaremba robert-zaremba requested a review from a team as a code owner June 20, 2023 18:52
@codecov
Copy link

codecov bot commented Jun 20, 2023 •
edited
Loading

Codecov Report

Merging #2101 (a947d32) into main (7f05ad4) will decrease coverage by 0.70%.
The diff coverage is 77.57%.

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #2101      +/-   ##
==========================================
- Coverage   75.38%   74.69%   -0.70%     
==========================================
  Files         100      127      +27     
  Lines        8025     9723    +1698     
==========================================
+ Hits         6050     7263    +1213     
- Misses       1589     1980     +391     
- Partials      386      480      +94
Impacted Files Coverage Δ
ante/spam_prevention.go 75.92% <ø> (ø)
x/incentive/codec.go 47.82% <ø> (+9.89%) ⬆️
x/incentive/keeper/invariants.go 0.00% <0.00%> (ø)
x/leverage/client/tests/suite.go 100.00% <ø> (ø)
x/leverage/client/tests/tests.go 100.00% <ø> (ø)
x/leverage/keeper/borrows.go 78.57% <ø> (ø)
x/leverage/keeper/collateral.go 73.48% <ø> (+0.59%) ⬆️
x/leverage/keeper/errors.go 100.00% <ø> (ø)
x/leverage/keeper/exchange_rate.go 72.72% <ø> (ø)
x/leverage/keeper/genesis.go 87.23% <ø> (ø)
... and 62 more

... and 25 files with indirect coverage changes

toteki
toteki reviewed Jun 20, 2023
View reviewed changes
x/incentive/keeper/iter.go Outdated Show resolved Hide resolved
toteki
toteki reviewed Jun 20, 2023
View reviewed changes
x/leverage/keeper/iter.go Outdated Show resolved Hide resolved
toteki
toteki approved these changes Jun 20, 2023
View reviewed changes
Copy link
Member

@toteki toteki left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Left a couple comments and pre-approved

robert-zaremba and others added 2 commits June 20, 2023 23:26
@robert-zaremba @toteki
Update x/incentive/keeper/iter.go
196dc99 
Co-authored-by: Adam Moser <63419657+toteki@users.noreply.github.com>
@robert-zaremba
add SumCoins to store/iter
92d6064
gsk967
gsk967 approved these changes Jun 21, 2023
View reviewed changes
Copy link
Collaborator

@gsk967 gsk967 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM
May be can you add small test case to SumCoins func

@robert-zaremba robert-zaremba enabled auto-merge June 22, 2023 10:09
@robert-zaremba
Copy link
Member Author

I've added unit tests for SumCoins with prefix store.

@robert-zaremba robert-zaremba added this pull request to the merge queue Jun 22, 2023
Merged via the queue into main with commit fc4fd4d Jun 22, 2023
@robert-zaremba robert-zaremba deleted the robert/loadall branch June 22, 2023 10:22
@robert-zaremba robert-zaremba mentioned this pull request Jun 23, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@toteki toteki toteki approved these changes

@gsk967 gsk967 gsk967 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@robert-zaremba @gsk967 @toteki