Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

perf: remove unnecessary null byte #2110

Merged
merged 6 commits into from
Jun 28, 2023
Merged

perf: remove unnecessary null byte #2110

merged 6 commits into from
Jun 28, 2023

Conversation

robert-zaremba
Copy link
Member

Description

followup to: #2101

@robert-zaremba robert-zaremba requested a review from a team as a code owner June 23, 2023 15:03
gsk967
gsk967 approved these changes Jun 23, 2023
View reviewed changes
Copy link
Collaborator

@gsk967 gsk967 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

toteki
toteki requested changes Jun 23, 2023
View reviewed changes
Copy link
Member

@toteki toteki left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

discussion

toteki
toteki reviewed Jun 27, 2023
View reviewed changes
x/incentive/keeper/iter.go Outdated Show resolved Hide resolved
toteki and others added 4 commits June 27, 2023 18:27
@toteki
Merge branch 'main' into robert/nullbyte
66d3ec4
@robert-zaremba @toteki
Apply suggestions from code review
a0d82e0 
Co-authored-by: Adam Moser <63419657+toteki@users.noreply.github.com>
@toteki @robert-zaremba
feat: add borrow factor (#2114)
4f5fad7 
* cl++

* cl++

* rephrase test - sign changes based on cpu architecture so strict equal avoided

* implement borrow factor restriction

* fix new uToken calc

* Update x/leverage/keeper/oracle.go

* Update x/leverage/types/token.go

* revert

* revert

* implement borrow factor in userMaxBorrow

* implement userMaxBorrow + cause failing wasm test

* lint

* add denom to test suite registry

* max withdaw test

* withdraw and max withdraw tests

* borrow and maxborrow tests

* renaming suggestion

* halfDec

* rename

* README

* Update x/leverage/README.md

Co-authored-by: Robert Zaremba <robert@zaremba.ch>

* readme suggestions

---------

Co-authored-by: Robert Zaremba <robert@zaremba.ch>
@robert-zaremba
tests: remove gb from e2e tests (#2119)
a5e13bc 
* tests: remove gb from e2e tests

* go.mod tidy
@robert-zaremba robert-zaremba requested a review from a team as a code owner June 28, 2023 13:40
@codecov
Copy link

codecov bot commented Jun 28, 2023 •
edited
Loading

Codecov Report

Merging #2110 (a5e13bc) into main (7f05ad4) will decrease coverage by 0.78%.
The diff coverage is 77.39%.

❗ Current head a5e13bc differs from pull request most recent head 67a619c. Consider uploading reports for the commit 67a619c to get more accurate results

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #2110      +/-   ##
==========================================
- Coverage   75.38%   74.61%   -0.78%     
==========================================
  Files         100      127      +27     
  Lines        8025     9883    +1858     
==========================================
+ Hits         6050     7374    +1324     
- Misses       1589     2007     +418     
- Partials      386      502     +116
Impacted Files Coverage Δ
ante/spam_prevention.go 75.92% <ø> (ø)
x/incentive/codec.go 47.82% <ø> (+9.89%) ⬆️
x/incentive/keeper/invariants.go 0.00% <0.00%> (ø)
x/leverage/client/tests/suite.go 100.00% <ø> (ø)
x/leverage/client/tests/tests.go 100.00% <ø> (ø)
x/leverage/keeper/borrows.go 75.93% <ø> (-2.64%) ⬇️
x/leverage/keeper/collateral.go 72.72% <ø> (-0.16%) ⬇️
x/leverage/keeper/errors.go 100.00% <ø> (ø)
x/leverage/keeper/exchange_rate.go 72.72% <ø> (ø)
x/leverage/keeper/genesis.go 87.23% <ø> (ø)
... and 62 more

... and 25 files with indirect coverage changes

@robert-zaremba robert-zaremba added the skip-e2e-test Skip the e2e tests label Jun 28, 2023
@robert-zaremba robert-zaremba added this pull request to the merge queue Jun 28, 2023
Merged via the queue into main with commit bc66b64 Jun 28, 2023
@robert-zaremba robert-zaremba deleted the robert/nullbyte branch June 28, 2023 14:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@toteki toteki toteki approved these changes

@gsk967 gsk967 gsk967 approved these changes

Assignees
No one assigned
Labels
skip-e2e-test Skip the e2e tests
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@robert-zaremba @gsk967 @toteki