Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add badger db support & tune release #927

Merged
merged 11 commits into from
May 20, 2022

Conversation

dreamcodez
Copy link
Contributor

@dreamcodez dreamcodez commented May 19, 2022

Description

  • tweak github actions triggers to allow rc tags
  • bump golang release version to 1.18 from 1.17
  • disable arm6 build (not arm64) as it is not compatible with badger
  • add badger to cosmos build tags for release as it is a more performant database than goleveldb (enables usage)
  • release build is only invoked for a pr when the Enable:ReleaseBuild label is applied

Author Checklist

All items are required. Please add a note to the item if the item is not applicable and
please add links to any relevant follow up issues.

I have...

  • included the correct type prefix in the PR title
  • added appropriate labels to the PR
  • added ! to the type prefix if API or client breaking change
  • targeted the correct branch (see PR Targeting)
  • provided a link to the relevant issue or specification
  • added a changelog entry to CHANGELOG.md
  • included comments for documenting Go code
  • updated the relevant documentation or specification
  • reviewed "Files changed" and left comments if necessary
  • confirmed all CI checks have passed

Reviewers Checklist

All items are required. Please add a note if the item is not applicable and please add
your handle next to the items reviewed if you only reviewed selected items.

I have...

  • confirmed the correct type prefix in the PR title
  • confirmed ! in the type prefix if API or client breaking change
  • confirmed all author checklist items have been addressed
  • reviewed state machine logic
  • reviewed API design and naming
  • reviewed documentation is accurate
  • reviewed tests and test coverage
  • manually tested (if applicable)

@dreamcodez dreamcodez changed the title feat: add additional db support to release feat: add badger db support & tune release May 19, 2022
@dreamcodez dreamcodez marked this pull request as ready for review May 19, 2022 23:39
@dreamcodez dreamcodez requested a review from a team as a code owner May 19, 2022 23:39
Comment on lines +8 to +9
- "v[0-9]+\\.[0-9]+\\.[0-9]+" # Official release version tags e.g. v2.0.5
- "v[0-9]+\\.[0-9]+\\.[0-9]+-rc[0-9]+" # Release candidate tags e.g. v1.0.3-rc4
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
- "v[0-9]+\\.[0-9]+\\.[0-9]+" # Official release version tags e.g. v2.0.5
- "v[0-9]+\\.[0-9]+\\.[0-9]+-rc[0-9]+" # Release candidate tags e.g. v1.0.3-rc4
- "v[0-9]+.[0-9]+.[0-9]+" # Official release version tags e.g. v2.0.5
- "v[0-9]+.[0-9]+.[0-9]+-rc[0-9]+" # Release candidate tags e.g. v1.0.3-rc4

Slashes needed?

Copy link
Contributor Author

@dreamcodez dreamcodez May 19, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

by putting the slashes in the regexp is more exact. \\. means an actual period. In regexp . means 'any character'. Hence before v0🙏🏻1🙏🏻2 was valid.. if that makes sense?

Two backslashes looks weird; the first slash is to escape the dot in the regexp; the second backslash escapes the backslash itself in the double-quoted string so that its not interpreted as a string escape (a single slash is seen by the regexp engine).

I've tested it :) in another repo and the rc i tested as well today.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

claps in semver

@dreamcodez dreamcodez merged commit 41fc62b into main May 20, 2022
@dreamcodez dreamcodez deleted the matt/add-additional-db-support-to-release branch May 20, 2022 00:08
mergify bot pushed a commit that referenced this pull request May 20, 2022
* tweak triggers to allow rc tags and also run on pull request

* bump golang to 1.18

* enable build tags badgerdb and rocksdb, get rid of CGO_ENABLED=0 to try to get ledger built in the binary statically as well

* move static flag to ldflags

* disable arm6 for now incompatible with badger

* reenable cgo_enabled=0, remove rocksdb from build tags to ease cross-compile

* reduce the diff

* add comments; also use Enable:ReleaseBuild label to control whether release build runs on pr

* bump ci to test label

* Revert "bump ci to test label"

This reverts commit da42097.

(cherry picked from commit 41fc62b)
adamewozniak pushed a commit that referenced this pull request May 20, 2022
Co-authored-by: Matthew Elder <sseses@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants