-
Notifications
You must be signed in to change notification settings - Fork 170
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: add badger db support & tune release #927
Conversation
…ry to get ledger built in the binary statically as well
…itional-db-support-to-release
…elease build runs on pr
This reverts commit da42097.
- "v[0-9]+\\.[0-9]+\\.[0-9]+" # Official release version tags e.g. v2.0.5 | ||
- "v[0-9]+\\.[0-9]+\\.[0-9]+-rc[0-9]+" # Release candidate tags e.g. v1.0.3-rc4 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
- "v[0-9]+\\.[0-9]+\\.[0-9]+" # Official release version tags e.g. v2.0.5 | |
- "v[0-9]+\\.[0-9]+\\.[0-9]+-rc[0-9]+" # Release candidate tags e.g. v1.0.3-rc4 | |
- "v[0-9]+.[0-9]+.[0-9]+" # Official release version tags e.g. v2.0.5 | |
- "v[0-9]+.[0-9]+.[0-9]+-rc[0-9]+" # Release candidate tags e.g. v1.0.3-rc4 |
Slashes needed?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
by putting the slashes in the regexp is more exact. \\.
means an actual period. In regexp .
means 'any character'. Hence before v0🙏🏻1🙏🏻2
was valid.. if that makes sense?
Two backslashes looks weird; the first slash is to escape the dot in the regexp; the second backslash escapes the backslash itself in the double-quoted string so that its not interpreted as a string escape (a single slash is seen by the regexp engine).
I've tested it :) in another repo and the rc i tested as well today.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
claps in semver
* tweak triggers to allow rc tags and also run on pull request * bump golang to 1.18 * enable build tags badgerdb and rocksdb, get rid of CGO_ENABLED=0 to try to get ledger built in the binary statically as well * move static flag to ldflags * disable arm6 for now incompatible with badger * reenable cgo_enabled=0, remove rocksdb from build tags to ease cross-compile * reduce the diff * add comments; also use Enable:ReleaseBuild label to control whether release build runs on pr * bump ci to test label * Revert "bump ci to test label" This reverts commit da42097. (cherry picked from commit 41fc62b)
Description
Enable:ReleaseBuild
label is appliedAuthor Checklist
All items are required. Please add a note to the item if the item is not applicable and
please add links to any relevant follow up issues.
I have...
!
to the type prefix if API or client breaking changeCHANGELOG.md
Reviewers Checklist
All items are required. Please add a note if the item is not applicable and please add
your handle next to the items reviewed if you only reviewed selected items.
I have...
!
in the type prefix if API or client breaking change