Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: add badger db support & tune release #927

Merged
merged 11 commits into from
May 20, 2022
Merged

feat: add badger db support & tune release #927

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
11 commits
Select commit Hold shift + click to select a range
73fe164
tweak triggers to allow rc tags and also run on pull request
dreamcodez May 19, 2022
25edf1b
bump golang to 1.18
dreamcodez May 19, 2022
fa03b89
enable build tags badgerdb and rocksdb, get rid of CGO_ENABLED=0 to t…
dreamcodez May 19, 2022
0a50e36
move static flag to ldflags
dreamcodez May 19, 2022
c8a8068
disable arm6 for now incompatible with badger
dreamcodez May 19, 2022
6349757
reenable cgo_enabled=0, remove rocksdb from build tags to ease cross-…
dreamcodez May 19, 2022
418d991
reduce the diff
dreamcodez May 19, 2022
558cc70
Merge branch 'main' of github.com:umee-network/umee into matt/add-add…
dreamcodez May 19, 2022
b7ff2a5
add comments; also use Enable:ReleaseBuild label to control whether r…
dreamcodez May 19, 2022
da42097
bump ci to test label
dreamcodez May 19, 2022
fff1a5a
Revert "bump ci to test label"
dreamcodez May 19, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 6 additions & 3 deletions .github/workflows/release.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,7 +5,10 @@ on:
push:
# Sequence of patterns matched against refs/tags
tags:
- "v[0-9]+.[0-9]+.[0-9]+" # Push events to matching v*, i.e. v1.0, v20.15.10
- "v[0-9]+\\.[0-9]+\\.[0-9]+" # Official release version tags e.g. v2.0.5
- "v[0-9]+\\.[0-9]+\\.[0-9]+-rc[0-9]+" # Release candidate tags e.g. v1.0.3-rc4
Comment on lines +8 to +9
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
- "v[0-9]+\\.[0-9]+\\.[0-9]+" # Official release version tags e.g. v2.0.5
- "v[0-9]+\\.[0-9]+\\.[0-9]+-rc[0-9]+" # Release candidate tags e.g. v1.0.3-rc4
- "v[0-9]+.[0-9]+.[0-9]+" # Official release version tags e.g. v2.0.5
- "v[0-9]+.[0-9]+.[0-9]+-rc[0-9]+" # Release candidate tags e.g. v1.0.3-rc4

Slashes needed?

Copy link
Contributor Author

@dreamcodez dreamcodez May 19, 2022 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

by putting the slashes in the regexp is more exact. \\. means an actual period. In regexp . means 'any character'. Hence before v0🙏🏻1🙏🏻2 was valid.. if that makes sense?

Two backslashes looks weird; the first slash is to escape the dot in the regexp; the second backslash escapes the backslash itself in the double-quoted string so that its not interpreted as a string escape (a single slash is seen by the regexp engine).

I've tested it :) in another repo and the rc i tested as well today.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

claps in semver

pull_request:
types: [ opened, synchronize ]

jobs:
release:
Expand All @@ -16,12 +19,12 @@ jobs:
fetch-depth: 0
- uses: actions/setup-go@v3
with:
go-version: 1.17
go-version: 1.18
- name: Set Env
run: echo "TM_VERSION=$(go list -m github.com/tendermint/tendermint | sed 's:.* ::')" >> $GITHUB_ENV
- name: Build
uses: goreleaser/goreleaser-action@v2
if: ${{ github.event_name == 'pull_request' }}
if: github.event_name == 'pull_request' && contains(github.event.pull_request.labels.*.name, 'Enable:ReleaseBuild')
with:
version: latest
args: build --rm-dist --skip-validate # skip validate skips initial sanity checks in order to be able to fully run
Expand Down
3 changes: 1 addition & 2 deletions .goreleaser.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -14,7 +14,7 @@ builds:
binary: umeed
mod_timestamp: "{{ .CommitTimestamp }}"
flags:
- -tags=netgo ledger
- -tags=badgerdb ledger netgo
- -trimpath
env:
- CGO_ENABLED=0
Expand All @@ -25,7 +25,6 @@ builds:
- linux
goarch:
- amd64
- arm
- arm64

archives:
Expand Down