chore: remove ui terminal node-pty (#5522)

umijs · Oct 10, 2020 · 4d0d5d0 · 4d0d5d0
1 parent f37bbac
commit 4d0d5d0
Show file tree

Hide file tree

Showing 3 changed files with 0 additions and 79 deletions.
diff --git a/packages/umi-ui/client/src/layouts/Footer.tsx b/packages/umi-ui/client/src/layouts/Footer.tsx
@@ -10,7 +10,6 @@ import {
   QuestionCircleOutlined,
   CheckOutlined,
   MessageOutlined,
-  CodeOutlined,
 } from '@ant-design/icons';
 import { formatMessage } from 'umi-plugin-react/locale';
 import cls from 'classnames';
@@ -19,7 +18,6 @@ import Context from '@/layouts/Context';
 import Logs from '@/components/Logs';
 import FooterToolbar from './FooterToolbar';
 import EditorIcon from '@/components/icons/Editor';
-import Shell from '@/components/Shell';
 import { states, reducers } from '@/customModels/footer';
 import { handleBack } from '@/utils';
 import event, { MESSAGES } from '@/message';
@@ -127,7 +125,6 @@ const Footer: React.SFC<IFooterProps> = props => {
 
   const actionCls = cls(styles.section, styles.action);
   const logCls = cls(actionCls, styles.log);
-  const shellCls = cls(actionCls, styles.shell);
 
   const LocaleText = ({ locale: textLocale, checked, style }) => (
     <span style={style}>
@@ -214,55 +211,6 @@ const Footer: React.SFC<IFooterProps> = props => {
         >
           <Logs logs={logs} type={type} className={styles['section-drawer-logs']} />
         </Drawer>
-        <Drawer
-          title={
-            <FooterToolbar
-              title={formatMessage({ id: 'org.umi.ui.global.terminal.upperCase' })}
-              resizeAxis="y"
-              onResize={size => {
-                const newHeight = terminalHeight + size.deltaY;
-                dispatch({
-                  type: 'changeSize',
-                  payload: {
-                    terminalHeight: newHeight,
-                  },
-                });
-                if (fitAddon) {
-                  fitAddon.fit();
-                }
-              }}
-              onClose={() => togglePanel('terminal')}
-              onClear={() => terminal.clear()}
-              onScrollBottom={() => terminal.scrollToBottom()}
-            />
-          }
-          getContainer={drawerContainerRef.current}
-          destroyOnClose={false}
-          closable={false}
-          visible={visible.terminal}
-          placement="bottom"
-          mask={false}
-          className={styles['section-drawer']}
-          height={terminalHeight}
-        >
-          {typeof visible.terminal === 'boolean' && (
-            // init shell socket when open Drawer
-            <Shell
-              // style hide / show, not dom
-              visible={!!visible.terminal}
-              ref={(ref, fitAddon) =>
-                dispatch({
-                  type: 'initTerminal',
-                  payload: {
-                    terminal: ref,
-                    fitAddon,
-                  },
-                })
-              }
-              className={styles['section-drawer-shell']}
-            />
-          )}
-        </Drawer>
       </div>
       <div className={styles.statusBar}>
         <div className={styles['statusBar-left']}>
@@ -289,12 +237,6 @@ const Footer: React.SFC<IFooterProps> = props => {
             <ProfileFilled style={{ marginRight: 4 }} />{' '}
             {formatMessage({ id: 'org.umi.ui.global.log' })}
           </div>
-          {projectDashboard && (
-            <div className={shellCls} onClick={() => togglePanel('terminal')}>
-              <CodeOutlined style={{ marginRight: 4 }} />{' '}
-              {formatMessage({ id: 'org.umi.ui.global.terminal' })}
-            </div>
-          )}
         </div>
 
         {!!key && (

diff --git a/packages/umi-ui/package.json b/packages/umi-ui/package.json
@@ -24,9 +24,6 @@
     "chencheng <sorrycc@gmail.com> (https://github.com/sorrycc)"
   ],
   "license": "MIT",
-  "optionalDependencies": {
-    "node-pty": "^0.10.0-beta3"
-  },
   "dependencies": {
     "@umijs/launch-editor": "^1.0.0",
     "binary-mirror-config": "1.20.3",

diff --git a/packages/umi-ui/src/UmiUI.ts b/packages/umi-ui/src/UmiUI.ts
@@ -24,7 +24,6 @@ import { BackToHomeAction, OpenProjectAction, ReInstallDependencyAction } from '
 import { isDepLost, isPluginLost, isUmiProject, isUsingBigfish, isUsingUmi } from './checkProject';
 import getScripts from './scripts';
 import isDepFileExists from './utils/isDepFileExists';
-import initTerminal, { resizeTerminal } from './terminal';
 import detectLanguage from './detectLanguage';
 import detectNpmClients from './detectNpmClients';
 import debug, { debugSocket } from './debug';
@@ -849,22 +848,6 @@ export default class UmiUI {
         );
       }
 
-      /**
-       * Terminal shell resize server
-       */
-      app.get('/terminal/resize', async (req, res) => {
-        const rows = parseInt(req.query.rows || 30);
-        const cols = parseInt(req.query.cols || 180);
-        try {
-          resizeTerminal({ rows, cols });
-          res.send({
-            success: true,
-            rows,
-            cols,
-          });
-        } catch (_) {}
-      });
-
       app.get('/', async (req, res) => {
         const isMini = 'mini' in req.query;
         debug('isMini', isMini);
@@ -1080,7 +1063,6 @@ export default class UmiUI {
         prefix: '/umiui',
         log: () => {},
       });
-      initTerminal.call(this, server);
       this.socketServer = ss;
       this.server = server;
     });