Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: remove ui terminal node-pty #5522

Merged
merged 1 commit into from
Oct 10, 2020
Merged

chore: remove ui terminal node-pty #5522

merged 1 commit into from
Oct 10, 2020

Conversation

ycjcl868
Copy link
Contributor

@ycjcl868 ycjcl868 commented Oct 10, 2020

ref: https://github.com/umijs/umi-ui/pull/94/files

schnerd/d3-scale-cluster#7 (comment)
https://github.com/nodejs/node-gyp/blob/1e2e94d9851a1685d80d591262d0730681b5481d/macOS_Catalina.md

Checklist
  • npm test passes
  • tests are included
  • documentation is changed or added
  • commit message follows commit guidelines
Description of change

@ycjcl868 ycjcl868 requested a review from sorrycc October 10, 2020 09:20
@codecov
Copy link

codecov bot commented Oct 10, 2020

Codecov Report

Merging #5522 into 2.x will increase coverage by 0.03%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##              2.x    #5522      +/-   ##
==========================================
+ Coverage   40.81%   40.85%   +0.03%     
==========================================
  Files         284      284              
  Lines        8080     8073       -7     
  Branches     1922     1967      +45     
==========================================
  Hits         3298     3298              
+ Misses       4409     4395      -14     
- Partials      373      380       +7     
Impacted Files Coverage Δ
packages/umi-ui/src/UmiUI.ts 0.00% <ø> (ø)
packages/umi-plugin-ui/src/bubble/index.jsx 0.00% <0.00%> (ø)
...kages/umi-plugin-ui/src/plugins/dashboard/index.ts 0.00% <0.00%> (ø)
...s/umi-build-dev/src/plugins/commands/block/util.ts 33.11% <0.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update f37bbac...4ba6771. Read the comment docs.

@sorrycc sorrycc merged commit 4d0d5d0 into 2.x Oct 10, 2020
@delete-merged-branch delete-merged-branch bot deleted the chore-remove-ui-terminal branch October 10, 2020 09:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants