Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Suppress extinct species in checklist #972

Merged

Conversation

pdl
Copy link
Contributor

@pdl pdl commented Feb 19, 2024

This PR changes the behaviour of the CITES Checklist Taxon Concept route. Instead of returning all countries where there is geographic distribution information, this route will now exclude those where the information is that the species is extinct, per issue 215 on Codebase

STR:

/checklist/taxon_concepts?locale=en&output_layout=alphabetical&level_of_listing=0&show_synonyms=1&show_author=1&show_english=1&show_spanish=1&show_french=1&scientific_name=Acinonyx+jubatus%00&page=1&per_page=20
  • Observed: countries_ids has >50 items including 203, Afghanistan
  • Expected: Fewer entries, not includng 203

@pdl pdl merged commit f22c599 into upgrade/rails-6.1.7.6 Feb 22, 2024
@pdl
Copy link
Contributor Author

pdl commented Feb 22, 2024

Merged this as I applied it to develop too

@pdl pdl mentioned this pull request Mar 14, 2024
pdl added a commit that referenced this pull request Apr 10, 2024
#974

Upgrades:

- Rails 4.0 to 6.1
- Ruby 2.3 to 3.0
- Many other dependencies, and associated fixes
- See notes in #969 for most of the changes
- Also includes feature change to checklist #972
@pdl pdl deleted the feat/215-suppress-checklist-extinct-species branch August 21, 2024 12:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant