2024 Q1 Rails Upgrade #974

pdl · 2024-03-14T15:08:29Z

Upgrades:

Rails 4.0 to 6.1
Ruby 2.3 to 3.0
Many other dependencies, and associated fixes
See notes in Upgrade: Ruby 3.0.6; Rails 6.1.7.6 #969 for most of the changes
Also includes feature change to checklist Suppress extinct species in checklist #972

…, we should add this to our Gemfile.

… so safe to remove the dependancy gem in our Gemfile.

…1 spec failed)

…ient js libraries Fixes issues caused by updating versions of the ember-rails and ember-data-source gems by running the following: rails generate ember:install --tag=v1.6.1 --ember rails generate ember:install --tag=v0.14 --ember-data ...and committing the files the commands place in `vendor/`

…-5-fix-frontend fix: ember was broken, and some assets failed to load

…ken Rails 5.0 belongs_to.

…_to.

…mview fails https://unep-wcmc.codebasehq.com/projects/species-rails-upgrade/tickets/139 If a user edits names in change_type so that either ADDITION or DELETION is missing, then this function will concatenate NULL while building SQL, leading to a confusing error message.

... so that it's clear when it's all done

https://unep-wcmc.codebasehq.com/projects/species-rails-upgrade/tickets/106

…strong params

https://unep-wcmc.codebasehq.com/projects/cites-support-maintenance/tickets/249

https://unep-wcmc.codebasehq.com/projects/species-rails-upgrade/tickets/105

…cord behaviour has changed https://unep-wcmc.codebasehq.com/projects/species-rails-upgrade/tickets/112

https://unep-wcmc.codebasehq.com/projects/species-rails-upgrade/tickets/90 NB: https://github.com/aws/aws-sdk-ruby/blob/version-3/UPGRADING.md > Aws.eager_autoload! is deprecated as all autoload statements have been > replaced with require statements. Calling this method will now generate > a warning and have no other effect.

Upgrade: Ruby 3.0.6; Rails 6.1.7.6

…taint deprecation warning

… tabulations

This commit changes the format of matching_criteria so that the values of the hash are always strings, in order that we don't get errors on account of type mismatches, e.g. `{ "some_id": 123 } @> {"some_id": "123"}` is false. https://unep-wcmc.codebasehq.com/projects/species-rails-upgrade/tickets/102

…plit operations https://unep-wcmc.codebasehq.com/projects/cites-support-maintenance/tickets/177

https://unep-wcmc.codebasehq.com/projects/cites-support-maintenance/tickets/177

Upgrade rails 6.1.7.6 to 6.1.7.7

…errors Fix for errors on some nomenclature changes

pdl · 2024-04-10T16:44:37Z

RSpec results for reference

Finished in 10 minutes 24 seconds (files took 9.28 seconds to load)
2166 examples, 0 failures, 27 pending

[Coveralls] Outside the CI environment, not sending data.
Coverage report generated for RSpec to /SAPI/coverage. 8668 / 13814 LOC (62.75%) covered.

leonardow-unep-wcmc and others added 30 commits January 18, 2024 15:59

upgrade pg_search

57fb302

upgrade groupdate gem

995f592

clean up gemfile

14ff1f4

upgrade paper_trail to v5 latest

7774b25

upgrade pg_search

1916ae2

We use Sentient in User model, so don't relay on clerk's dependencies…

a30061a

…, we should add this to our Gemfile.

add deprecated message for update_attributes

736ae76

strong params (round 1)

0e5f639

Remove broken code

539e879

found include SentientUser and track_who_does_it in Clerk gem README,…

a1aaded

… so safe to remove the dependancy gem in our Gemfile.

strong params (round 2)

82c04aa

quiet assets from rails log

7bc1606

strong params (round 3)

3061263

strong params (round 3) (missed)

c0b1ad9

strong params (round 4) add comments

d9c3591

strong params (round 5), trace from model

fdb91a8

update config for strong params, bugs fix, and fix rspec. (still got …

561fe1b

…1 spec failed)

bug fixes

3bab736

upgrade paper_trail to 10.3.1 (was 5.2.3)

b991d4f

deps: add a comment to explain why ember versions don't match

a20d0da

fix: assets with the plus symbol in the name were returning 404s

7789207

Merge pull request #961 from unepwcmc/chore/upgrade-gems-before-rails…

54af37f

…-5-fix-frontend fix: ember was broken, and some assets failed to load

remove gem Clerk, and reimplement it, to remove dependency. Clerk bro…

65ae7b7

…ken Rails 5.0 belongs_to.

Merge branch 'upgrade/remove_clerk' into upgrade-gems-before-rails-5

18aca4d

add more tests to help isolate the document citation touch issue

3dc4495

in spec, refactor out @recent_time

8c310a9

Add more detailed tests on behaviour of DocumentSearch

6b1d245

Remove gem Traco, migrate to Mobility. Traco breaks Rails 5.0 belongs…

0df258e

…_to.

re-implement Traco's locale_columns methods and admin helper.

2a7667e

pdl added 27 commits March 11, 2024 15:02

chore: add a little more logging to Trade::RebuildComplianceMviews

7ea6c23

... so that it's clear when it's all done

fix: another sql literal in order() clause

4d2de12

fix: strong params for checklist download index

be8ff31

https://unep-wcmc.codebasehq.com/projects/species-rails-upgrade/tickets/106

fix: checklist has its own param sanitisation method - use that over …

7d7c553

…strong params

refactor: also use checklist params for history

660945f

fix: checklist history CSV did not contain taxon ids

c7df549

https://unep-wcmc.codebasehq.com/projects/cites-support-maintenance/tickets/249

fix: for checklist downloads ID manual entries pdf

1c8b528

https://unep-wcmc.codebasehq.com/projects/species-rails-upgrade/tickets/105

fix: my own stupidity

727ec61

chore: do not swallow exceptions; re-raise them

8de7b56

fix: PDFKit now requires enable_local_file_access to read local files

71c383f

chore: replace tabs with spaces in cites trade js

5167365

chore: fix more whitespace issuesin cites trade js

bac0601

fix: trim_decimal_zero still needs coercing to text, because ActiveRe…

773d662

…cord behaviour has changed https://unep-wcmc.codebasehq.com/projects/species-rails-upgrade/tickets/112

feat: allow configuration of AWS region in credentials

d8f08c8

chore: upgrade rails from 6.1.7.6 to 6.1.7.7

1b7896d

Merge pull request #969 from unepwcmc/upgrade/rails-6.1.7.6

7b272cf

Upgrade: Ruby 3.0.6; Rails 6.1.7.6

chore: update bundler from 1.17.3 to 2.2.33 - fixes noisy Pathname#un…

138fd3f

…taint deprecation warning

fix: rename DocumentTagsController spec so it is picked up by rspec

a45f97d

fix: more issues relating to numeric/string typing in Gross/Net trade…

b6f7357

… tabulations

fix: correctly identify duplicates where array is empty during lump/s…

0100449

…plit operations https://unep-wcmc.codebasehq.com/projects/cites-support-maintenance/tickets/177

fix: postgres needs a hint with the array type here

3c80e9b

https://unep-wcmc.codebasehq.com/projects/cites-support-maintenance/tickets/177

docs: document ComparisonAttributes

4369c25

Merge pull request #973 from unepwcmc/upgrade/rails-6.1.7.7

ad54285

Upgrade rails 6.1.7.6 to 6.1.7.7

Merge pull request #975 from unepwcmc/fix/177-nomenclature-change-pg-…

30bd9ab

…errors Fix for errors on some nomenclature changes

pdl merged commit 3bc9fdd into develop Apr 10, 2024

pdl deleted the rails-upgrades branch August 21, 2024 12:45

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

2024 Q1 Rails Upgrade #974

2024 Q1 Rails Upgrade #974

pdl commented Mar 14, 2024

pdl commented Apr 10, 2024 •

edited

Loading

2024 Q1 Rails Upgrade #974

2024 Q1 Rails Upgrade #974

Conversation

pdl commented Mar 14, 2024

pdl commented Apr 10, 2024 • edited Loading

pdl commented Apr 10, 2024 •

edited

Loading