Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ICU-20600 build icu-data-bin files #1048

Merged
merged 1 commit into from
Mar 17, 2020
Merged

Conversation

srl295
Copy link
Member

@srl295 srl295 commented Mar 14, 2020

ICU-20600

make dist will now produce:

  • icu4c-67.1-data-bin-b.zip
  • icu4c-67.1-data-bin-l.zip

I made the builder a separate shell script, so that I can run it on backlevel ICUs.

@srl295 srl295 requested review from roubert, markusicu and jefgen March 14, 2020 01:20
@srl295 srl295 self-assigned this Mar 14, 2020
@srl295
Copy link
Member Author

srl295 commented Mar 14, 2020

@sgallagher PTAL

@srl295
Copy link
Member Author

srl295 commented Mar 14, 2020

this enables nodejs/full-icu-npm#36

@srl295
Copy link
Member Author

srl295 commented Mar 14, 2020

Here's an example of the generated readme:


ICU Data Zip for 66.1

For information on Unicode ICU, see http://icu-project.org

Contents

This .zip file contains:

How to use this file

This file contains prebuilt data in form b.
(“l” for Little Endian, “b” for Big Endian, “e” for EBCDIC.)
It may be used to simplify build and installation of ICU.
See http://icu-project.org for further information.

License

See LICENSE.

Copyright © 2016 and later Unicode, Inc. and others. All Rights Reserved.
Unicode and the Unicode Logo are registered trademarks
of Unicode, Inc. in the U.S. and other countries.
Terms of Use and License

make dist will now produce:
- icu4c-67.1-data-bin-b.zip
- icu4c-67.1-data-bin-l.zip
dist-local: $(DISTY_FILES)
VERSION=$(VERSION) $(SHELL) $(top_srcdir)/config/dist-data.sh
Copy link
Member

@jefgen jefgen Mar 14, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I wonder if we could/should add a build bot that does make dist just to exercise this...

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

that would be [ICU-20605] but yeah

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

fair point, should probably be another ticket. :)

@jira-pull-request-webhook
Copy link

Notice: the branch changed across the force-push!

  • icu4c/source/config/dist-data.sh is different

View Diff Across Force-Push

~ Your Friendly Jira-GitHub PR Checker Bot

Copy link
Member

@jefgen jefgen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

rslgtm. :)

@srl295
Copy link
Member Author

srl295 commented Mar 14, 2020

thanks, I'm going to leave this open and hopefully actually test this against the npm module before closing. But at least it's ready to go.

@sgallagher
Copy link

LGTM

@srl295 srl295 merged commit f63a8bb into unicode-org:master Mar 17, 2020
@srl295 srl295 deleted the make-data-dist branch March 17, 2020 15:30
@srl295
Copy link
Member Author

srl295 commented Sep 27, 2021

=> nodejs/full-icu-npm#53

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants