-
-
Notifications
You must be signed in to change notification settings - Fork 752
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ICU-20600 build icu-data-bin files #1048
Conversation
@sgallagher PTAL |
this enables nodejs/full-icu-npm#36 |
Here's an example of the generated readme: ICU Data Zip for 66.1For information on Unicode ICU, see http://icu-project.org ContentsThis .zip file contains:
How to use this fileThis file contains prebuilt data in form b. LicenseSee LICENSE.
|
make dist will now produce: - icu4c-67.1-data-bin-b.zip - icu4c-67.1-data-bin-l.zip
dist-local: $(DISTY_FILES) | ||
VERSION=$(VERSION) $(SHELL) $(top_srcdir)/config/dist-data.sh |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I wonder if we could/should add a build bot that does make dist
just to exercise this...
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
that would be [ICU-20605] but yeah
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
fair point, should probably be another ticket. :)
Notice: the branch changed across the force-push!
~ Your Friendly Jira-GitHub PR Checker Bot |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
rslgtm. :)
thanks, I'm going to leave this open and hopefully actually test this against the npm module before closing. But at least it's ready to go. |
LGTM |
ICU-20600
make dist will now produce:
I made the builder a separate shell script, so that I can run it on backlevel ICUs.