Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ICU-20605 travis: make dist. #1049

Merged
merged 1 commit into from
Mar 17, 2020
Merged

ICU-20605 travis: make dist. #1049

merged 1 commit into from
Mar 17, 2020

Conversation

srl295
Copy link
Member

@srl295 srl295 commented Mar 14, 2020

ICU-20605

  • run 'make dist' after the linux clang build
    - upgrade ubuntu xenial (16 LTS) to bionic (18 LTS) (schedule)

HT: #1048 (comment)

@srl295 srl295 requested review from sffc and jefgen March 14, 2020 01:34
@srl295 srl295 self-assigned this Mar 14, 2020
@srl295
Copy link
Member Author

srl295 commented Mar 14, 2020

This should maybe be two PRs. One for make dist, and one for bumping the version.

Or should we keep trying ubuntu xenial?

In any event, let's discuss this some more, maybe in TC.

@jefgen yeah, could consider the pipelines… all of this has time vs. coverage tradeoffs.

.travis.yml Outdated
@@ -5,7 +5,7 @@ matrix:
# TODO: publish the latest built docs from master on GitHub pages.
# See https://gist.github.com/vidavidorra/548ffbcdae99d752da02 for ideas.
- name: "c: docs"
dist: xenial
dist: bionic
Copy link
Member

@jefgen jefgen Mar 14, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

oh, we should likely update (or add) to azure pipelines bionic as well

@@ -87,6 +87,7 @@ matrix:
- make -j2 check
- ( cd test/depstest && python3 depstest.py ../../../source/ )
- ( cd .. && source/test/hdrtst/testtagsguards.sh )
- make dist # not sure if this is -j safe everywhere.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

does travis let you download artifacts?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

not sure. We could push them somewhere (like a github release) though.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

fwiw, you can publish artifacts from the pipelines.
ex: https://github.com/unicode-org/icu/blob/master/.ci-builds/.azure-pipelines.yml#L108
(This is how the windows binaries are produced.)
It should work for *nix as well, so we might be able to have a sort of rolling/evergreen make dist available.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It looks like Travis can potentially directly deploy to a GitHub release:
https://docs.travis-ci.com/user/build-stages/deploy-github-releases/
which is definitely nicer.
AFAIK, the pipelines just give you an arbitrary file you can download. (So you'd have to copy/paste to a release).

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

right. But I'm not sure what release it would go to.

@jefgen
Copy link
Member

jefgen commented Mar 14, 2020

I'd vote for a separate ticket to bump the version. We should probably bump the azure pipelines one too at the same time. (or add an extra build line)

@jira-pull-request-webhook
Copy link

Notice: the branch changed across the force-push!

  • .travis.yml is different

View Diff Across Force-Push

~ Your Friendly Jira-GitHub PR Checker Bot

@srl295 srl295 changed the title ICU-20605 travis: make dist. xenial->bionic ICU-20605 travis: make dist. Mar 14, 2020
@sffc
Copy link
Member

sffc commented Mar 15, 2020

Your new check is already failing

make[3]: *** No rule to make target 'icu-docs.zip'.  Stop.

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature. The key has expired.
- run 'make dist' after the linux clang build
@jira-pull-request-webhook
Copy link

Notice: the branch changed across the force-push!

  • .travis.yml is different

View Diff Across Force-Push

~ Your Friendly Jira-GitHub PR Checker Bot

@srl295 srl295 requested a review from jefgen March 17, 2020 15:29
@srl295 srl295 merged commit b1af32b into unicode-org:master Mar 17, 2020
@srl295 srl295 deleted the makedist branch March 17, 2020 18:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants