-
-
Notifications
You must be signed in to change notification settings - Fork 752
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ICU-20605 travis: make dist. #1049
Conversation
This should maybe be two PRs. One for make dist, and one for bumping the version. Or should we keep trying ubuntu xenial? In any event, let's discuss this some more, maybe in TC. @jefgen yeah, could consider the pipelines… all of this has time vs. coverage tradeoffs. |
.travis.yml
Outdated
@@ -5,7 +5,7 @@ matrix: | |||
# TODO: publish the latest built docs from master on GitHub pages. | |||
# See https://gist.github.com/vidavidorra/548ffbcdae99d752da02 for ideas. | |||
- name: "c: docs" | |||
dist: xenial | |||
dist: bionic |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
oh, we should likely update (or add) to azure pipelines bionic as well
@@ -87,6 +87,7 @@ matrix: | |||
- make -j2 check | |||
- ( cd test/depstest && python3 depstest.py ../../../source/ ) | |||
- ( cd .. && source/test/hdrtst/testtagsguards.sh ) | |||
- make dist # not sure if this is -j safe everywhere. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
does travis let you download artifacts?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
not sure. We could push them somewhere (like a github release) though.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
fwiw, you can publish artifacts from the pipelines.
ex: https://github.com/unicode-org/icu/blob/master/.ci-builds/.azure-pipelines.yml#L108
(This is how the windows binaries are produced.)
It should work for *nix as well, so we might be able to have a sort of rolling/evergreen make dist available.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It looks like Travis can potentially directly deploy to a GitHub release:
https://docs.travis-ci.com/user/build-stages/deploy-github-releases/
which is definitely nicer.
AFAIK, the pipelines just give you an arbitrary file you can download. (So you'd have to copy/paste to a release).
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
right. But I'm not sure what release it would go to.
I'd vote for a separate ticket to bump the version. We should probably bump the azure pipelines one too at the same time. (or add an extra build line) |
Notice: the branch changed across the force-push!
~ Your Friendly Jira-GitHub PR Checker Bot |
Your new check is already failing
|
- run 'make dist' after the linux clang build
Notice: the branch changed across the force-push!
~ Your Friendly Jira-GitHub PR Checker Bot |
ICU-20605
- upgrade ubuntu xenial (16 LTS) to bionic (18 LTS) (schedule)HT: #1048 (comment)