Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ICU-20605 travis: make dist. #1049

Merged
merged 1 commit into from
Mar 17, 2020
Merged

ICU-20605 travis: make dist. #1049

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 3 additions & 0 deletions .travis.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -79,6 +79,8 @@ matrix:
- CFLAGS="-Wimplicit-fallthrough"
- CXXFLAGS="-Wimplicit-fallthrough"
compiler: clang
before_install:
- sudo apt-get -y install doxygen # for make dist
before_script:
- cd icu4c/source
- ./runConfigureICU Linux
Expand All @@ -87,6 +89,7 @@ matrix:
- make -j2 check
- ( cd test/depstest && python3 depstest.py ../../../source/ )
- ( cd .. && source/test/hdrtst/testtagsguards.sh )
- make dist # not sure if this is -j safe everywhere.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

does travis let you download artifacts?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

not sure. We could push them somewhere (like a github release) though.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

fwiw, you can publish artifacts from the pipelines.
ex: https://github.com/unicode-org/icu/blob/master/.ci-builds/.azure-pipelines.yml#L108
(This is how the windows binaries are produced.)
It should work for *nix as well, so we might be able to have a sort of rolling/evergreen make dist available.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It looks like Travis can potentially directly deploy to a GitHub release:
https://docs.travis-ci.com/user/build-stages/deploy-github-releases/
which is definitely nicer.
AFAIK, the pipelines just give you an arbitrary file you can download. (So you'd have to copy/paste to a release).

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

right. But I'm not sure what release it would go to.


- name: "c: osx clang"
language: cpp
Expand Down