Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

#3682 followup #3714

Merged
merged 2 commits into from
Jul 20, 2023
Merged

#3682 followup #3714

merged 2 commits into from
Jul 20, 2023

Conversation

robertbastian
Copy link
Member

@robertbastian robertbastian commented Jul 20, 2023 •
edited
Loading

Adding an .empty file to be VCS agnostic.

#3682

@robertbastian robertbastian requested a review from sffc as a code owner July 20, 2023 15:42
@robertbastian robertbastian requested a review from a team as a code owner July 20, 2023 15:47
@robertbastian robertbastian changed the title Adding .empty file #3682 followup Jul 20, 2023
sffc
sffc approved these changes Jul 20, 2023
View reviewed changes
Copy link
Member

@sffc sffc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ok, there is a Stack Overflow for .empty so LGTM

https://stackoverflow.com/questions/15083542/what-is-the-empty-file-for

@robertbastian robertbastian merged commit c53523a into unicode-org:main Jul 20, 2023
@robertbastian robertbastian deleted the errs branch July 20, 2023 17:10
@sffc sffc mentioned this pull request Jul 23, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Manishearth Manishearth Manishearth approved these changes

@sffc sffc sffc approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@robertbastian @sffc @Manishearth