Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix ci-job-testdata #3726

Merged
merged 1 commit into from
Jul 23, 2023
Merged

Fix ci-job-testdata #3726

merged 1 commit into from
Jul 23, 2023

Conversation

sffc
Copy link
Member

@sffc sffc commented Jul 23, 2023

Conflict between #3669 and #3714

@sffc
Copy link
Member Author

sffc commented Jul 23, 2023

Gonna force-merge this since it is a 0-line change and CI is passing.

@sffc sffc merged commit 0f56fad into unicode-org:main Jul 23, 2023
@sffc sffc deleted the fix-ci-job-testdata branch July 23, 2023 16:53
Copy link
Member

@robertbastian robertbastian left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Weird, how did that even merge

Edit: ah

@sffc
Copy link
Member Author

sffc commented Jul 25, 2023

Weird, how did that even merge

Edit: ah

Yeah you can consider this a red TBR (to-be-reviewed) submission in need of a post-submit LGTM. Fixing main CI is one of the few things I think we can agree rises to the level of a TBR.

@robertbastian
Copy link
Member

I meant my PR, I understand why you force-merged this :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants