Datagen: Consume CLDR-JSON resources keyed with default script #3772
Conversation
sffc
requested review from
a team,
Manishearth,
dminor and
zbraniecki
as code owners
|
🎉 All dependencies have been resolved ! |
| @@ -75,6 +75,7 @@ itertools = "0.10" | |||
| lazy_static = "1" | |||
| log = "0.4" | |||
| memchr = "2.5.0" | |||
| once_cell = "1" | |||
There was a problem hiding this comment.
@Manishearth to approve the new dependency. (We now have multiple places where it is useful)
There was a problem hiding this comment.
I'd prefer to not have two lazy initialization dependencies, we should either use lazy_static everywhere or once_cell everywhere.
Slight preference for the latter since 1.70 has it in std
There was a problem hiding this comment.
Approved with #3777 being 1.3 blocking (I'm fine with this landing first)
|
@robertbastian's changes LGTM. Looks like we need to add once_cell to the deps checker, and then we can merge? |
|
Blocked on #3777 |
|
I'm admin-merging based on the approval from robertbastian, the clean CI, the fact that I had no substantive changes since that approval, and because I want to fix #2683 tonight. |
Part of #2683
Depends on #3769
Depends on #3768