Datagen: Normalize locales with default script but no region (#3772 follow-up) #3786
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sffc
changed the title
|
I attempted to write a PR title that roughly describes what this PR is doing |
sffc
changed the title
Manishearth
approved these changes
Aug 4, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#3772 only collapsed non-minimised CLDR locales if they had a region. However, we also want to treat
sr-Cyrlassr, assr-Cyrlis not reachable under ICU4X fallback (see this test).Now, CLDR does contain data for both
srandsr-Cyrl(andzh-Hans,yue-Hant, ...), which is identical as far as I can tell. With this change,srdata will be generated from eithersrorsr-Cyrl(in that order), depending on which one exists.This removes the
sr-Cyrlentries from testdata, which is a behaviour change if used without fallback. Once we use the hybrid mode for test data, these should come back.