Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Collapse all escape sequence rules into one #743

Merged
merged 2 commits into from
May 13, 2024
Merged

Conversation

eemeli
Copy link
Collaborator

@eemeli eemeli commented Mar 23, 2024

Currently, we are very strict about which characters may be escaped, and where. This means that in the syntax we have

text-escape = backslash ( backslash / "{" / "}" )
quoted-escape = backslash ( backslash / "|" )
reserved-escape = backslash ( backslash / "{" / "|" / "}" )

As discussed in #635 and during the 2024-03-18 call, this could be simplified by allowing each of the characters \, {, |, } to be escaped in all the positions we allow for any of them to be escaped. Doing so would simplify the syntax, make escaping easier to understand for users, and simplify implementations.

This relaxation would come with the small cost of making the messages this|that and this\|that synonymous, much like we already allow for hello and {{hello}} to be synonymous.

This PR is not intended for consideration for the LDML 45 release of MF2, but after that.

@eemeli eemeli added the syntax Issues related with MF Syntax label Mar 23, 2024
@eemeli eemeli added this to the Stable Release (CLDR v46) milestone Mar 23, 2024
@aphillips aphillips added Future Deferred for future standardization LDML46 LDML46 Release (Tech Preview - October 2024) labels Mar 23, 2024
@aphillips
Copy link
Member

I think there would need to be spec text about this as well as the ABNF mods.

@aphillips
Copy link
Member

If we made this change, we'd also need to change lines 87-88 in the ABNF to exclude |

Current:

; Restrictions on characters in various contexts
simple-start-char = content-char / s / "@" / "|"
text-char         = content-char / s / "." / "@" / "|"

Replace with:

; Restrictions on characters in various contexts
simple-start-char = content-char / s / "@"
text-char         = content-char / s / "." / "@"

@eemeli
Copy link
Collaborator Author

eemeli commented Mar 23, 2024

I think there would need to be spec text about this as well as the ABNF mods.

That's included; the only new thing that's required is this addition:

Each _escape sequence_ represents the literal character immediately following the initial `\`.

That's because we already have this in Literal Resolution:

The resolved value of a _text_ or a _literal_ is
the character sequence of the _text_ or _literal_
after any character escape has been converted to the escaped character.

If we made this change, we'd also need to change lines 87-88 in the ABNF to exclude |

We don't need to do that; as I mention in the first comment above, | can still be allowed in patterns, so the messages this|that and this\|that are synonymous. We don't need to make the first variant invalid.

@stasm
Copy link
Collaborator

stasm commented Mar 25, 2024

This relaxation would come with the small cost of making the messages this|that and this\|that synonymous, much like we already allow for hello and {{hello}} to be synonymous.

It would also mean that a |{foo}| literal could be spelled as |\{foo\}|.


Doing so would simplify the syntax, make escaping easier to understand for users, and simplify implementations.

Overall, I'm leaning against this change. It's much easier for me personally to remember which characters need escaping by recalling what the delimiters are. There's a clear one-to-one correspondence in the current design: In {{patterns}} you escape \{ and \}, and in |literals| you escape \|.

With the proposed change, there are now multiple spellings of the same content. It may be simple to write for some, but it will also confuse readers who don't know the specifics of the syntax by heart.


Furthermore, we invested a lot of effort to avoid slashes as much as we could, because we target multiple different host formats in which the backslash must be escaped (with another backslash). I don't think the convenience of parser implementors should have a higher priority.

@mihnita
Copy link
Collaborator

mihnita commented Mar 25, 2024

Overall, I'm leaning against this change. It's much easier for me personally to remember which characters need escaping by recalling what the delimiters are

I'm kind of in the same boat.

Except for the reserved body syntax, which seems very clunky, and has its own escape.
Not only that, but the reserved body can contain |...| escapes.
Does not have delimiters of its own, depends on context.
And the context can go several levels in (in pattern (|...| inside a reserved because it is after a .fooo inside a placeholder which can be pattern, which can be in a {{...}} or not).

So I would rather (partially) fix this by improving the reserved syntax.

@bearfriend
Copy link
Contributor

Does this change simply allow these characters to be escaped without effect or require it?

@stasm
Copy link
Collaborator

stasm commented Mar 25, 2024

It's the former: this|that is also allowed to be spelled as this\|that.

The vertical bar | remains a valid character inside patterns, and the curly braces {, } remain valid characters inside literals:

text-char         = content-char / s / "." / "@" / "|"
quoted-char       = content-char / s / "." / "@" / "{" / "}"

@bearfriend
Copy link
Contributor

Right, so in that case it seems simply "recalling what the delimiters are" still works, from a message-writing perspective.

I understand javascript certainly won't be the only implementation but I personally wouldn't expect it to work any differently than:

'\{\|' === '{|'; // true

@aphillips
Copy link
Member

@eemeli Do you want to clean this up so that we can consider it for merge?

@aphillips aphillips removed the Future Deferred for future standardization label Apr 15, 2024
@aphillips aphillips requested a review from stasm May 12, 2024 16:13
@aphillips
Copy link
Member

In the 2024-05-06 call we agreed that we were waiting on a review from @stasm followed by some additional discussion

Copy link
Collaborator

@stasm stasm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

My opposition here wasn’t strong. I was leaning against but I can see the value of this change. I also acknowledge the prior art by JavaScript among others.

Copy link
Member

@srl295 srl295 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

simplification lgtm

@aphillips aphillips merged commit 60c1b1f into main May 13, 2024
1 check passed
@aphillips aphillips deleted the collapse-escapes branch May 13, 2024 17:07
eemeli added a commit to messageformat/messageformat that referenced this pull request Aug 21, 2024
eemeli added a commit that referenced this pull request Aug 21, 2024
aphillips pushed a commit that referenced this pull request Sep 3, 2024
* Add missing expected bad-selector errors

* Fix expected parts for unsupported-statement test

* Add a few new tests for leading-whitespace and duplicate-variant

* Add tests for escaped-char changes made in #743

* Fix tests for attributes with variable values
aphillips added a commit that referenced this pull request Oct 26, 2024
* Create notes-2024-08-19.md

* Accept attributes design & remove spec note (#845)

* Accept attributes design & remove spec note

* Disallow duplicate attribute names (closes #756)

* Add link to contextual options PR

* Add more prose to tag example text

Co-authored-by: Addison Phillips <addison@unicode.org>

* Mention attribute validity condition in the **_valid_** definition

---------

Co-authored-by: Addison Phillips <addison@unicode.org>

* Update selection-declaration design doc based on mtg / issue discussion (#867)

* Add tests for pattern selection (#863)

* Add tests for pattern selection

* Add missing errors

* Apply suggestions from code review

Co-authored-by: Addison Phillips <addison@unicode.org>

---------

Co-authored-by: Addison Phillips <addison@unicode.org>

* Add Duplicate Variant to table in test/README.md (#861)

* Add new selection-declaration alternative: Require annotation of selector variables in placeholders (#860)

* Add new selection-declaration alternative: Require annotation of selector variables in placeholders

* Improve examples

* Switch example order

* Update the stability policy (#834)

* Update the stability policy

Based on discussion in the 2024-07-22 call and in PR #829, update the stability policy.

* A deeper, more thorough rewrite

- Standardizes the phrasing completely.
- Moves all potential future changes (which are not, after all, stability policies) to an "important" block
- Removes duplication
- Separates functions, options, and option values into separate guarantees
- Clarifies the note about formatting changing over time

* Update spec/README.md

Co-authored-by: Tim Chevalier <tjc@igalia.com>

* Update spec/README.md

Co-authored-by: Eemeli Aro <eemeli@mozilla.com>

* remove well-formed

* Update spec/README.md

---------

Co-authored-by: Tim Chevalier <tjc@igalia.com>
Co-authored-by: Eemeli Aro <eemeli@mozilla.com>

* Refine error handling text (#816)

* Refine error handling text

* Apply suggestions from code review

Co-authored-by: Addison Phillips <addison@unicode.org>

* Update fallback text

* Turn bullet point list into paragraphs

* Be more mighty

Co-authored-by: Addison Phillips <addison@unicode.org>

---------

Co-authored-by: Addison Phillips <addison@unicode.org>

* Create notes-2024-08-26.md

* Select "Match on variables instead of expressions" for selection-declarations (#824)

* Select "Match on variables instead of expressions" for selection-declarations

* Add hybrid option to selection-declaration.md (#870)

* Add hybrid option to selection-declaration.md

* Update selection-declaration.md

fixed glitch in original edit

* Update selection-declaration.md

* Apply suggestions from code review

Fixing typos

Co-authored-by: Addison Phillips <addison@unicode.org>

* Update selection-declaration.md

* Update exploration/selection-declaration.md

Co-authored-by: Eemeli Aro <eemeli@mozilla.com>

* Update exploration/selection-declaration.md

Co-authored-by: Eemeli Aro <eemeli@mozilla.com>

* Update exploration/selection-declaration.md

Co-authored-by: Eemeli Aro <eemeli@mozilla.com>

---------

Co-authored-by: Addison Phillips <addison@unicode.org>
Co-authored-by: Eemeli Aro <eemeli@mozilla.com>

* Update selection-declaration.md

---------

Co-authored-by: Mark Davis <mark@unicode.org>
Co-authored-by: Addison Phillips <addison@unicode.org>

* Fix "Allow immutable input declarative selectors" example (#874)

* Update README.md (#875)

* Update README.md

* Update README.md

* [DESIGN] Update bidi design document to show proposed design (#871)

* [DESIGN] Update bidi design document to show proposed design

The design I actually think we should adopt is the "hybrid approaches" one. This is a necessary first step on the highway to UAX31 compliance and I think is responsibly contained/managed. It is a hybrid approach, in that it permits testable strict implementations to be created (particularly for message serialization).

This PR consists of moving text around. I added one "pro" to one option also.

* Address comments

* Miscellaneous test fixes (#862)

* Add missing expected bad-selector errors

* Fix expected parts for unsupported-statement test

* Add a few new tests for leading-whitespace and duplicate-variant

* Add tests for escaped-char changes made in #743

* Fix tests for attributes with variable values

* Update contributing and joining info (#876)

* Update contributing and joining info

* Update README.md

* Update CONTRIBUTING.md

* Restore CLA copy

* Clarify error & fallback handling (#879)

* Clarify error & fallback handling

* Apply suggestions from code review

Co-authored-by: Addison Phillips <addison@unicode.org>

* Select last rather than first attribute

* Drop mention of "starting with Pattern Selection"

* Attributes can't change the formatted output

* Use "nor" instead of "or" regarding attribute restrictions

---------

Co-authored-by: Addison Phillips <addison@unicode.org>

* Clarify rule selection (#878)

* Clarify rule selection

Fixes #868 

This adds normative SHOULD language to using CLDR plural and ordinal data, which was intended originally.

- clarifies that keyword selection follows exact match
- clarifies the purpose of rule-based selection
- makes non-CLDR-based implementation permitted

* Update spec/registry.md

Co-authored-by: Eemeli Aro <eemeli@mozilla.com>

* Update spec/registry.md

Co-authored-by: Eemeli Aro <eemeli@mozilla.com>

* Update spec/registry.md

Co-authored-by: Eemeli Aro <eemeli@mozilla.com>

---------

Co-authored-by: Eemeli Aro <eemeli@mozilla.com>

* [DESIGN] Maintaining the Standard, Optional and Unicode Namespace Function Sets (#634)

* Design doc to capture registry maintenance

* Update maintaining-registry.md

* Update exploration/maintaining-registry.md

Co-authored-by: Tim Chevalier <tjc@igalia.com>

* Update exploration/maintaining-registry.md

Co-authored-by: Tim Chevalier <tjc@igalia.com>

* Add user stories, small updates to RGI

* Update exploration/maintaining-registry.md

* Adding additional detail

* Remove machine readable registry; update prose

* Update maintaining-registry.md

* Further development work

* Update to change format and naming

Per the 2024-08-19 call, we decided to switch towards a specification-per-function model, with statuses. This commit includes the initial set of changes to try and implement this.

* Address some comments.

---------

Co-authored-by: Tim Chevalier <tjc@igalia.com>

* Create notes-2024-09-09.md

* Fix a typo in an example (#880)

The upcoming work to implement resolved value might make this patch unnecessary or obsolete, but fixing the typo (missing `{`/`}` around the variable in the pattern) just in case

* Remove forward-compatibility promise and all reserved & private syntax (#883)

* Remove forwards compatibility from stability guarantee

* Drop reserved statements and expressions

* Drop private-use annotations

* Update tests

* Clarify that deprecation is not removal

* Match on variables instead of expressions (#877)

* Match on variables instead of expressions

* Apply suggestions from code review

Co-authored-by: Addison Phillips <addison@unicode.org>

* Apply suggestions from code review

* Add missing test changes noticed during implementation

* Empty commit to re-trigger CLA check

---------

Co-authored-by: Addison Phillips <addison@unicode.org>

* Create notes-2024-09-10.md

* Add bidi support and address UAX31/UTS55 requirements (#884)

* Add bidi support and address UAX31/UTS55 requirements

Adds the bidi strong marks ALM, RLM, and LRM plus the bidi isolate controls LRI, RLI, FSI, and PDI to the syntax.

Formally defines optional vs. non-optional whitespace.

Non-optional whitespace must include at least one whitespace character. Optional whitespace may contain only bidi marks (which are invisible)

* Update syntax.md including text from previous PR

* Repair the guidance on strongly directional marks

Include ALM and better specify how to use the marks.

* Fix formatting of the "important"

* Add bidi characters to description of whitespace.

* Permit bidi in a few more places

Add optional whitespace at the start of `variant`

Add optional whitespace around `quoted-pattern`

These changes result in allowing bidi around keys and quoted patterns as intended.

* Update syntax.md ABNF

* Update formatting.md

- Add a note about the difference between formatting and message syntax.
- Clarify the sentence about message directionality.

* Address comment about name/identifier

* Address comments related to bidi in `name`

* Fix variable's location

* Address comment about the list of LRI/PDI targets

* One character typo :-P

* Update spec/syntax.md

Co-authored-by: Eemeli Aro <eemeli@mozilla.com>

* Address comments about rule R3a-1

* Update spec/syntax.md

Co-authored-by: Eemeli Aro <eemeli@mozilla.com>

* Address comment about U+061C

* Change [o]wsp => `o` or `s`

* Match syntax spec to abnf

* Remove *

* Update syntax.md

* Update spec/syntax.md

Co-authored-by: Eemeli Aro <eemeli@mozilla.com>

* Update spec/message.abnf

Co-authored-by: Eemeli Aro <eemeli@mozilla.com>

* Update spec/message.abnf

Co-authored-by: Eemeli Aro <eemeli@mozilla.com>

* Update syntax.md

* Update spec/message.abnf

Co-authored-by: Eemeli Aro <eemeli@mozilla.com>

* Update spec/syntax.md

Co-authored-by: Eemeli Aro <eemeli@mozilla.com>

* Update spec/syntax.md

Co-authored-by: Eemeli Aro <eemeli@mozilla.com>

---------

Co-authored-by: Eemeli Aro <eemeli@mozilla.com>

* Specify `bad-option` for bad digit size option values (#882)

* Specify `bad-option` for bad digit size option values

Fixes #739

* adopt 'non-negative integer'

* Create notes-2024-09-16.md

* Address name and literal equality (#885)

* Address name and literal equality

This change defines equality as discussed in the 2024-09-09 teleconference in the following ways:

- It defines _name_ equality as being under NFC
- It defines _literal_ equality as explicitly **not** under NFC
- It moves _name_ before _identifier_ in that section of text to avoid a forward definition.

Note that this deviates from discussion in 2024-09-09's call in that we didn't discuss literals at length. It also doesn't discuss non-name/non-literal values, which I'll point out are limited to ASCII sequences such as keywords.

* Typo fix

* Add a note about not requiring implementations to actually normalize

* Implement changes dicussed in 2024-09-16 call.

- Make _key_ require NFC for uniqueness/comparison
- Add a note about NFC
- Make _literal_ **_not_** define equality
- Make text in _name_ identical to that in _key_ for consistency

* Update formatting.md to include keys in NFC

* Address comments

* Update spec/syntax.md

Co-authored-by: Eemeli Aro <eemeli@mozilla.com>

* Update spec/syntax.md

Co-authored-by: Eemeli Aro <eemeli@mozilla.com>

---------

Co-authored-by: Eemeli Aro <eemeli@mozilla.com>

* Update list of normative changes during the LDML45 period (#890)

* Fix typos in data-model-errors tests (#892)

Fix #886

* Update note on exact numeric match for v46 (#891)

Addresses #887 

Non-normative changes to the notes specifically part of LDML46

* Fix attribute value to be literal (#894)

Fixes #893

* Create notes-2024-09-30.md

* Add Resolved Values and Function Handler sections to formatting (#728)

* Add Resolved Values section to formatting

* Apply suggestions from code review

* Apply suggestions from code review

* Apply suggestions from code review

Co-authored-by: Tim Chevalier <tjc@igalia.com>

* Linkify "resolved value"

* Add some examples & explicitly allow wrapping input values

* No throw, only emit

Co-authored-by: Tim Chevalier <tjc@igalia.com>

* Add section on Function Handlers, defining the term

* Apply suggestions from code review

* Rephrase initial resolved value definition

* Update spec/formatting.md

Co-authored-by: Eemeli Aro <eemeli@mozilla.com>

* Update resolved value definition again

Co-authored-by: Addison Phillips <addison@unicode.org>

---------

Co-authored-by: Tim Chevalier <tjc@igalia.com>
Co-authored-by: Addison Phillips <addison@unicode.org>

* Define function composition for :number and :integer values (#823)

* Define function composition for :number and :integer values

* Apply suggestions from code review

Co-authored-by: Addison Phillips <addison@unicode.org>

* Add operand option priority example

* Add apostrophes'

Co-authored-by: Tim Chevalier <tjc@igalia.com>

* Update spec/registry.md

Co-authored-by: Eemeli Aro <eemeli@mozilla.com>

* Update spec/registry.md

Co-authored-by: Eemeli Aro <eemeli@mozilla.com>

---------

Co-authored-by: Addison Phillips <addison@unicode.org>
Co-authored-by: Tim Chevalier <tjc@igalia.com>

* Create notes-2024-10-07.md

* Apply NFC normalization during :string key comparison (#905)

* Apply NFC normalization during :string key comparison

* Add link to UAX#15

Co-authored-by: Addison Phillips <addison@unicode.org>

---------

Co-authored-by: Addison Phillips <addison@unicode.org>

* Add tests for changes due to bidi/whitespace (#902)

* Add tests for changes due to bidi/whitespace

* Correct output

* Make erroneous test a syntax error

* Define function composition for date/time values (#814)

* Define function composition for date/time values

* Apply suggestions from code review

Co-authored-by: Stanisław Małolepszy <sta@malolepszy.org>

* Drop the "only"

* Update spec/registry.md

* Update spec/registry.md

Co-authored-by: Eemeli Aro <eemeli@mozilla.com>

* Update spec/registry.md

Co-authored-by: Eemeli Aro <eemeli@mozilla.com>

* Update spec/registry.md

Co-authored-by: Eemeli Aro <eemeli@mozilla.com>

* Make :date and :time composition implementation-defined

---------

Co-authored-by: Stanisław Małolepszy <sta@malolepszy.org>
Co-authored-by: Addison Phillips <addison@unicode.org>

* DESIGN: Add alternative designs to the design doc on function composition (#806)

* DESIGN: Add a sequel to the design doc on function composition

This document sketches out some alternatives for the machinery
provided to enable function composition.

The goal is to provide an exhaustive list of alternatives.

* Remove 'part 2' document and move contents to the end of part 1

* Revise introduction to reflect the changed goal

* Edited for conciseness

* Further edits for conciseness

* Give a name to InputType and use it

* Refer to motivating examples

* Update function-composition-part-1.md status

Per 2024-10-14 telecon

* Create notes-2024-10-14.md

* Add test for :integer and :number composition (#907)

* Fix `:integer` option `useGrouping` values (#912)

I noticed that `:integer` does not include the "never" value for the option `useGrouping`. This is a bug.

* Drop syntax note on additional bidi changes (#910)

Drop syntax note on addition bidi changes

* Add tests for changes due to #885 (name/literal equality) (#904)

* Add tests for changes due to #885 (name/literal equality)

* Update test/tests/functions/string.json

Co-authored-by: Eemeli Aro <eemeli@gmail.com>

* Update test/tests/syntax.json

Co-authored-by: Eemeli Aro <eemeli@gmail.com>

* Update test/tests/functions/string.json

Co-authored-by: Eemeli Aro <eemeli@gmail.com>

* Added tests for reordering and special case mapping

* Add another selection test

---------

Co-authored-by: Eemeli Aro <eemeli@gmail.com>

* Add u: options namespace (#846)

* Move spec/registry.md -> spec/registry/default.md

* Add Unicode Registry definition

* Refer to BCP47, add note about only requiring normal tags

* Call it a namespace

* Apply suggestions from code review

Co-authored-by: Addison Phillips <addison@unicode.org>

* Fix test file reference

Co-authored-by: Tim Chevalier <tjc@igalia.com>

* Apply suggestions from code review

* Update spec/u-namespace.md

Co-authored-by: Eemeli Aro <eemeli@mozilla.com>

* Apply suggestions from code review

Co-authored-by: Addison Phillips <addison@unicode.org>

* Apply suggestions from code review

Co-authored-by: Addison Phillips <addison@unicode.org>

* Add mention of functions to namespace description

---------

Co-authored-by: Addison Phillips <addison@unicode.org>
Co-authored-by: Tim Chevalier <tjc@igalia.com>

* Define function composition for :string values (#798)

* Define function composition for :string values

* Update spec/registry.md as suggested by @stasm in #814

* Drop the "only"

* Update text following code review comments

---------

Co-authored-by: Addison Phillips <addison@unicode.org>

* Drop data model request for feedback on "name" (#909)

* Allow surrogates in content, issue #895 (#906)

* Allow surrogates in content, issue #895

* Grammar and typos, linkify terms, make into a note, and fix 2119 keywords

Thanks Addison!

Co-authored-by: Addison Phillips <addisonI18N@gmail.com>

* Not using "localizable elements"

Co-authored-by: Addison Phillips <addisonI18N@gmail.com>

* Keep syntax.md in sync with message.abnf

* Added note about surrogates to quoted literals

* Moved the note about surrogates from Security Considerations to The Message

* Update spec/syntax.md

* Update spec/syntax.md

* Italicize  in a couple of places

* Implemeted more (all?) feedback from review

---------

Co-authored-by: Addison Phillips <addisonI18N@gmail.com>

---------

Co-authored-by: Eemeli Aro <eemeli@mozilla.com>
Co-authored-by: Elango Cheran <elango@unicode.org>
Co-authored-by: Tim Chevalier <tjc@igalia.com>
Co-authored-by: Mark Davis <mark@unicode.org>
Co-authored-by: Danny Gleckler <daniel.gleckler@d2l.com>
Co-authored-by: Steven R. Loomis <srl295@gmail.com>
Co-authored-by: Stanisław Małolepszy <sta@malolepszy.org>
Co-authored-by: Eemeli Aro <eemeli@gmail.com>
Co-authored-by: Mihai Nita <nmihai_2000@yahoo.com>
aphillips added a commit that referenced this pull request Nov 4, 2024
* [DESIGN] Number selection design refinements

This is to build up and capture technical considerations for how to address the issues raised by @eemeli's PR #842.

* Update examples to match changes to syntax

Also responds to the long discussion with @eemeli about significant digits by removing from the example.

* Address 2024-09-16 call comments

This changes the status to "Re-Opened" and adds a link to the PR. Expect to merge this imminently, although discussion on number selection remains.

* Update exploration/number-selection.md

Co-authored-by: Eemeli Aro <eemeli@mozilla.com>

* Update from main (#914)

* Create notes-2024-08-19.md

* Accept attributes design & remove spec note (#845)

* Accept attributes design & remove spec note

* Disallow duplicate attribute names (closes #756)

* Add link to contextual options PR

* Add more prose to tag example text

Co-authored-by: Addison Phillips <addison@unicode.org>

* Mention attribute validity condition in the **_valid_** definition

---------

Co-authored-by: Addison Phillips <addison@unicode.org>

* Update selection-declaration design doc based on mtg / issue discussion (#867)

* Add tests for pattern selection (#863)

* Add tests for pattern selection

* Add missing errors

* Apply suggestions from code review

Co-authored-by: Addison Phillips <addison@unicode.org>

---------

Co-authored-by: Addison Phillips <addison@unicode.org>

* Add Duplicate Variant to table in test/README.md (#861)

* Add new selection-declaration alternative: Require annotation of selector variables in placeholders (#860)

* Add new selection-declaration alternative: Require annotation of selector variables in placeholders

* Improve examples

* Switch example order

* Update the stability policy (#834)

* Update the stability policy

Based on discussion in the 2024-07-22 call and in PR #829, update the stability policy.

* A deeper, more thorough rewrite

- Standardizes the phrasing completely.
- Moves all potential future changes (which are not, after all, stability policies) to an "important" block
- Removes duplication
- Separates functions, options, and option values into separate guarantees
- Clarifies the note about formatting changing over time

* Update spec/README.md

Co-authored-by: Tim Chevalier <tjc@igalia.com>

* Update spec/README.md

Co-authored-by: Eemeli Aro <eemeli@mozilla.com>

* remove well-formed

* Update spec/README.md

---------

Co-authored-by: Tim Chevalier <tjc@igalia.com>
Co-authored-by: Eemeli Aro <eemeli@mozilla.com>

* Refine error handling text (#816)

* Refine error handling text

* Apply suggestions from code review

Co-authored-by: Addison Phillips <addison@unicode.org>

* Update fallback text

* Turn bullet point list into paragraphs

* Be more mighty

Co-authored-by: Addison Phillips <addison@unicode.org>

---------

Co-authored-by: Addison Phillips <addison@unicode.org>

* Create notes-2024-08-26.md

* Select "Match on variables instead of expressions" for selection-declarations (#824)

* Select "Match on variables instead of expressions" for selection-declarations

* Add hybrid option to selection-declaration.md (#870)

* Add hybrid option to selection-declaration.md

* Update selection-declaration.md

fixed glitch in original edit

* Update selection-declaration.md

* Apply suggestions from code review

Fixing typos

Co-authored-by: Addison Phillips <addison@unicode.org>

* Update selection-declaration.md

* Update exploration/selection-declaration.md

Co-authored-by: Eemeli Aro <eemeli@mozilla.com>

* Update exploration/selection-declaration.md

Co-authored-by: Eemeli Aro <eemeli@mozilla.com>

* Update exploration/selection-declaration.md

Co-authored-by: Eemeli Aro <eemeli@mozilla.com>

---------

Co-authored-by: Addison Phillips <addison@unicode.org>
Co-authored-by: Eemeli Aro <eemeli@mozilla.com>

* Update selection-declaration.md

---------

Co-authored-by: Mark Davis <mark@unicode.org>
Co-authored-by: Addison Phillips <addison@unicode.org>

* Fix "Allow immutable input declarative selectors" example (#874)

* Update README.md (#875)

* Update README.md

* Update README.md

* [DESIGN] Update bidi design document to show proposed design (#871)

* [DESIGN] Update bidi design document to show proposed design

The design I actually think we should adopt is the "hybrid approaches" one. This is a necessary first step on the highway to UAX31 compliance and I think is responsibly contained/managed. It is a hybrid approach, in that it permits testable strict implementations to be created (particularly for message serialization).

This PR consists of moving text around. I added one "pro" to one option also.

* Address comments

* Miscellaneous test fixes (#862)

* Add missing expected bad-selector errors

* Fix expected parts for unsupported-statement test

* Add a few new tests for leading-whitespace and duplicate-variant

* Add tests for escaped-char changes made in #743

* Fix tests for attributes with variable values

* Update contributing and joining info (#876)

* Update contributing and joining info

* Update README.md

* Update CONTRIBUTING.md

* Restore CLA copy

* Clarify error & fallback handling (#879)

* Clarify error & fallback handling

* Apply suggestions from code review

Co-authored-by: Addison Phillips <addison@unicode.org>

* Select last rather than first attribute

* Drop mention of "starting with Pattern Selection"

* Attributes can't change the formatted output

* Use "nor" instead of "or" regarding attribute restrictions

---------

Co-authored-by: Addison Phillips <addison@unicode.org>

* Clarify rule selection (#878)

* Clarify rule selection

Fixes #868 

This adds normative SHOULD language to using CLDR plural and ordinal data, which was intended originally.

- clarifies that keyword selection follows exact match
- clarifies the purpose of rule-based selection
- makes non-CLDR-based implementation permitted

* Update spec/registry.md

Co-authored-by: Eemeli Aro <eemeli@mozilla.com>

* Update spec/registry.md

Co-authored-by: Eemeli Aro <eemeli@mozilla.com>

* Update spec/registry.md

Co-authored-by: Eemeli Aro <eemeli@mozilla.com>

---------

Co-authored-by: Eemeli Aro <eemeli@mozilla.com>

* [DESIGN] Maintaining the Standard, Optional and Unicode Namespace Function Sets (#634)

* Design doc to capture registry maintenance

* Update maintaining-registry.md

* Update exploration/maintaining-registry.md

Co-authored-by: Tim Chevalier <tjc@igalia.com>

* Update exploration/maintaining-registry.md

Co-authored-by: Tim Chevalier <tjc@igalia.com>

* Add user stories, small updates to RGI

* Update exploration/maintaining-registry.md

* Adding additional detail

* Remove machine readable registry; update prose

* Update maintaining-registry.md

* Further development work

* Update to change format and naming

Per the 2024-08-19 call, we decided to switch towards a specification-per-function model, with statuses. This commit includes the initial set of changes to try and implement this.

* Address some comments.

---------

Co-authored-by: Tim Chevalier <tjc@igalia.com>

* Create notes-2024-09-09.md

* Fix a typo in an example (#880)

The upcoming work to implement resolved value might make this patch unnecessary or obsolete, but fixing the typo (missing `{`/`}` around the variable in the pattern) just in case

* Remove forward-compatibility promise and all reserved & private syntax (#883)

* Remove forwards compatibility from stability guarantee

* Drop reserved statements and expressions

* Drop private-use annotations

* Update tests

* Clarify that deprecation is not removal

* Match on variables instead of expressions (#877)

* Match on variables instead of expressions

* Apply suggestions from code review

Co-authored-by: Addison Phillips <addison@unicode.org>

* Apply suggestions from code review

* Add missing test changes noticed during implementation

* Empty commit to re-trigger CLA check

---------

Co-authored-by: Addison Phillips <addison@unicode.org>

* Create notes-2024-09-10.md

* Add bidi support and address UAX31/UTS55 requirements (#884)

* Add bidi support and address UAX31/UTS55 requirements

Adds the bidi strong marks ALM, RLM, and LRM plus the bidi isolate controls LRI, RLI, FSI, and PDI to the syntax.

Formally defines optional vs. non-optional whitespace.

Non-optional whitespace must include at least one whitespace character. Optional whitespace may contain only bidi marks (which are invisible)

* Update syntax.md including text from previous PR

* Repair the guidance on strongly directional marks

Include ALM and better specify how to use the marks.

* Fix formatting of the "important"

* Add bidi characters to description of whitespace.

* Permit bidi in a few more places

Add optional whitespace at the start of `variant`

Add optional whitespace around `quoted-pattern`

These changes result in allowing bidi around keys and quoted patterns as intended.

* Update syntax.md ABNF

* Update formatting.md

- Add a note about the difference between formatting and message syntax.
- Clarify the sentence about message directionality.

* Address comment about name/identifier

* Address comments related to bidi in `name`

* Fix variable's location

* Address comment about the list of LRI/PDI targets

* One character typo :-P

* Update spec/syntax.md

Co-authored-by: Eemeli Aro <eemeli@mozilla.com>

* Address comments about rule R3a-1

* Update spec/syntax.md

Co-authored-by: Eemeli Aro <eemeli@mozilla.com>

* Address comment about U+061C

* Change [o]wsp => `o` or `s`

* Match syntax spec to abnf

* Remove *

* Update syntax.md

* Update spec/syntax.md

Co-authored-by: Eemeli Aro <eemeli@mozilla.com>

* Update spec/message.abnf

Co-authored-by: Eemeli Aro <eemeli@mozilla.com>

* Update spec/message.abnf

Co-authored-by: Eemeli Aro <eemeli@mozilla.com>

* Update syntax.md

* Update spec/message.abnf

Co-authored-by: Eemeli Aro <eemeli@mozilla.com>

* Update spec/syntax.md

Co-authored-by: Eemeli Aro <eemeli@mozilla.com>

* Update spec/syntax.md

Co-authored-by: Eemeli Aro <eemeli@mozilla.com>

---------

Co-authored-by: Eemeli Aro <eemeli@mozilla.com>

* Specify `bad-option` for bad digit size option values (#882)

* Specify `bad-option` for bad digit size option values

Fixes #739

* adopt 'non-negative integer'

* Create notes-2024-09-16.md

* Address name and literal equality (#885)

* Address name and literal equality

This change defines equality as discussed in the 2024-09-09 teleconference in the following ways:

- It defines _name_ equality as being under NFC
- It defines _literal_ equality as explicitly **not** under NFC
- It moves _name_ before _identifier_ in that section of text to avoid a forward definition.

Note that this deviates from discussion in 2024-09-09's call in that we didn't discuss literals at length. It also doesn't discuss non-name/non-literal values, which I'll point out are limited to ASCII sequences such as keywords.

* Typo fix

* Add a note about not requiring implementations to actually normalize

* Implement changes dicussed in 2024-09-16 call.

- Make _key_ require NFC for uniqueness/comparison
- Add a note about NFC
- Make _literal_ **_not_** define equality
- Make text in _name_ identical to that in _key_ for consistency

* Update formatting.md to include keys in NFC

* Address comments

* Update spec/syntax.md

Co-authored-by: Eemeli Aro <eemeli@mozilla.com>

* Update spec/syntax.md

Co-authored-by: Eemeli Aro <eemeli@mozilla.com>

---------

Co-authored-by: Eemeli Aro <eemeli@mozilla.com>

* Update list of normative changes during the LDML45 period (#890)

* Fix typos in data-model-errors tests (#892)

Fix #886

* Update note on exact numeric match for v46 (#891)

Addresses #887 

Non-normative changes to the notes specifically part of LDML46

* Fix attribute value to be literal (#894)

Fixes #893

* Create notes-2024-09-30.md

* Add Resolved Values and Function Handler sections to formatting (#728)

* Add Resolved Values section to formatting

* Apply suggestions from code review

* Apply suggestions from code review

* Apply suggestions from code review

Co-authored-by: Tim Chevalier <tjc@igalia.com>

* Linkify "resolved value"

* Add some examples & explicitly allow wrapping input values

* No throw, only emit

Co-authored-by: Tim Chevalier <tjc@igalia.com>

* Add section on Function Handlers, defining the term

* Apply suggestions from code review

* Rephrase initial resolved value definition

* Update spec/formatting.md

Co-authored-by: Eemeli Aro <eemeli@mozilla.com>

* Update resolved value definition again

Co-authored-by: Addison Phillips <addison@unicode.org>

---------

Co-authored-by: Tim Chevalier <tjc@igalia.com>
Co-authored-by: Addison Phillips <addison@unicode.org>

* Define function composition for :number and :integer values (#823)

* Define function composition for :number and :integer values

* Apply suggestions from code review

Co-authored-by: Addison Phillips <addison@unicode.org>

* Add operand option priority example

* Add apostrophes'

Co-authored-by: Tim Chevalier <tjc@igalia.com>

* Update spec/registry.md

Co-authored-by: Eemeli Aro <eemeli@mozilla.com>

* Update spec/registry.md

Co-authored-by: Eemeli Aro <eemeli@mozilla.com>

---------

Co-authored-by: Addison Phillips <addison@unicode.org>
Co-authored-by: Tim Chevalier <tjc@igalia.com>

* Create notes-2024-10-07.md

* Apply NFC normalization during :string key comparison (#905)

* Apply NFC normalization during :string key comparison

* Add link to UAX#15

Co-authored-by: Addison Phillips <addison@unicode.org>

---------

Co-authored-by: Addison Phillips <addison@unicode.org>

* Add tests for changes due to bidi/whitespace (#902)

* Add tests for changes due to bidi/whitespace

* Correct output

* Make erroneous test a syntax error

* Define function composition for date/time values (#814)

* Define function composition for date/time values

* Apply suggestions from code review

Co-authored-by: Stanisław Małolepszy <sta@malolepszy.org>

* Drop the "only"

* Update spec/registry.md

* Update spec/registry.md

Co-authored-by: Eemeli Aro <eemeli@mozilla.com>

* Update spec/registry.md

Co-authored-by: Eemeli Aro <eemeli@mozilla.com>

* Update spec/registry.md

Co-authored-by: Eemeli Aro <eemeli@mozilla.com>

* Make :date and :time composition implementation-defined

---------

Co-authored-by: Stanisław Małolepszy <sta@malolepszy.org>
Co-authored-by: Addison Phillips <addison@unicode.org>

* DESIGN: Add alternative designs to the design doc on function composition (#806)

* DESIGN: Add a sequel to the design doc on function composition

This document sketches out some alternatives for the machinery
provided to enable function composition.

The goal is to provide an exhaustive list of alternatives.

* Remove 'part 2' document and move contents to the end of part 1

* Revise introduction to reflect the changed goal

* Edited for conciseness

* Further edits for conciseness

* Give a name to InputType and use it

* Refer to motivating examples

* Update function-composition-part-1.md status

Per 2024-10-14 telecon

* Create notes-2024-10-14.md

* Add test for :integer and :number composition (#907)

* Fix `:integer` option `useGrouping` values (#912)

I noticed that `:integer` does not include the "never" value for the option `useGrouping`. This is a bug.

* Drop syntax note on additional bidi changes (#910)

Drop syntax note on addition bidi changes

* Add tests for changes due to #885 (name/literal equality) (#904)

* Add tests for changes due to #885 (name/literal equality)

* Update test/tests/functions/string.json

Co-authored-by: Eemeli Aro <eemeli@gmail.com>

* Update test/tests/syntax.json

Co-authored-by: Eemeli Aro <eemeli@gmail.com>

* Update test/tests/functions/string.json

Co-authored-by: Eemeli Aro <eemeli@gmail.com>

* Added tests for reordering and special case mapping

* Add another selection test

---------

Co-authored-by: Eemeli Aro <eemeli@gmail.com>

* Add u: options namespace (#846)

* Move spec/registry.md -> spec/registry/default.md

* Add Unicode Registry definition

* Refer to BCP47, add note about only requiring normal tags

* Call it a namespace

* Apply suggestions from code review

Co-authored-by: Addison Phillips <addison@unicode.org>

* Fix test file reference

Co-authored-by: Tim Chevalier <tjc@igalia.com>

* Apply suggestions from code review

* Update spec/u-namespace.md

Co-authored-by: Eemeli Aro <eemeli@mozilla.com>

* Apply suggestions from code review

Co-authored-by: Addison Phillips <addison@unicode.org>

* Apply suggestions from code review

Co-authored-by: Addison Phillips <addison@unicode.org>

* Add mention of functions to namespace description

---------

Co-authored-by: Addison Phillips <addison@unicode.org>
Co-authored-by: Tim Chevalier <tjc@igalia.com>

* Define function composition for :string values (#798)

* Define function composition for :string values

* Update spec/registry.md as suggested by @stasm in #814

* Drop the "only"

* Update text following code review comments

---------

Co-authored-by: Addison Phillips <addison@unicode.org>

* Drop data model request for feedback on "name" (#909)

* Allow surrogates in content, issue #895 (#906)

* Allow surrogates in content, issue #895

* Grammar and typos, linkify terms, make into a note, and fix 2119 keywords

Thanks Addison!

Co-authored-by: Addison Phillips <addisonI18N@gmail.com>

* Not using "localizable elements"

Co-authored-by: Addison Phillips <addisonI18N@gmail.com>

* Keep syntax.md in sync with message.abnf

* Added note about surrogates to quoted literals

* Moved the note about surrogates from Security Considerations to The Message

* Update spec/syntax.md

* Update spec/syntax.md

* Italicize  in a couple of places

* Implemeted more (all?) feedback from review

---------

Co-authored-by: Addison Phillips <addisonI18N@gmail.com>

---------

Co-authored-by: Eemeli Aro <eemeli@mozilla.com>
Co-authored-by: Elango Cheran <elango@unicode.org>
Co-authored-by: Tim Chevalier <tjc@igalia.com>
Co-authored-by: Mark Davis <mark@unicode.org>
Co-authored-by: Danny Gleckler <daniel.gleckler@d2l.com>
Co-authored-by: Steven R. Loomis <srl295@gmail.com>
Co-authored-by: Stanisław Małolepszy <sta@malolepszy.org>
Co-authored-by: Eemeli Aro <eemeli@gmail.com>
Co-authored-by: Mihai Nita <nmihai_2000@yahoo.com>

* Add serialization proposal

* Revert "Add serialization proposal"

This reverts commit 17af553.

* Revert "Update from main (#914)"

This reverts commit da9377b.

* Add serialization proposal

---------

Co-authored-by: Eemeli Aro <eemeli@mozilla.com>
Co-authored-by: Elango Cheran <elango@unicode.org>
Co-authored-by: Tim Chevalier <tjc@igalia.com>
Co-authored-by: Mark Davis <mark@unicode.org>
Co-authored-by: Danny Gleckler <daniel.gleckler@d2l.com>
Co-authored-by: Steven R. Loomis <srl295@gmail.com>
Co-authored-by: Stanisław Małolepszy <sta@malolepszy.org>
Co-authored-by: Eemeli Aro <eemeli@gmail.com>
Co-authored-by: Mihai Nita <nmihai_2000@yahoo.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
LDML46 LDML46 Release (Tech Preview - October 2024) syntax Issues related with MF Syntax
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants