Add u: options namespace #846

eemeli · 2024-07-30T10:23:03Z

Closes #452
See also #845

Following the registry separations proposed in #634, this PR adds a new folder spec/registry/ and moves the current default function definitions there as default.md, as well as adding a new u: Unicode Registry as unicode.md.

Initially, this includes only the u:id, u:locale, and u:dir definitions from the design doc.

A new function context definition is added to Function Resolution, to allow for it to be affected by the u: options. This is intended to encapsulate the parts of the formatting context that are made available when calling functions.

Regarding the options, the text is almost directly as in the design doc. For u:locale, I specified that literal values matching the langtag rule from RFC 5646 are always supported, but that other tags and locale definitions MAY also be supported. This is roughly in line with what we have for e.g. :datetime operands, where we define something relatively strict that will work ~everywhere, while allowing other values beyond that definition to also be processed without error.

Note that u:locale and u:dir are ignored when used on markup.

A new test suite unicode.json is added; this also ends up testing our Default Bidi Strategy.

aphillips

Good start. Mostly word-smithing suggestions...

spec/README.md

spec/formatting.md

aphillips · 2024-07-30T15:18:31Z

spec/formatting.md

+     potentially including a fallback chain of locales.
+   - The base directionality of the _message_ and its _text_ tokens.
+
+   If the resolved mapping of _options_ includes any `u:` options


This seems like special pleading on our part. The u: namespace is "just a namespace"?

Perhaps:

Suggested change

If the resolved mapping of _options_ includes any `u:` options

Implementations are encouraged to support _options_ defined in

the Unicode Reserved Namespace (`u:`).

It's not "just a namespace", because it needs special powers to affect the function context, though.

I think that the "function context" context distinction is an implementation detail.

In most formatters implementations the locale and the options on how to format are passed to the constructor as parameters, at the same time.

I would rather look at this as "universal function parameters" that might be recognized and honored by several / all functions.

I think the problem here is that the current set of u: options behaves that way, but we might introduce one that isn't function context affecting in the future? If our intention to is to require that all such options be context-affecting, we should set that as a requirement in the design doc and elsewhere. We might need to contemplate an additional namespace in the future as well, although I can't think of any universal options just at the moment that we wouldn't just put in the default namespace.

Note: I am not disagreeing with doing this. Just making sure we're consistent and clear about it.

spec/formatting.md

spec/registry/unicode.md

macchiati

We should be referencing the Unicode BCP 47 locale identifier, not RFC 5646. (In particular, we don't want to force people to support extlang.

aphillips · 2024-09-16T16:32:47Z

@macchiati Can you be specific? I think the 5646 reference is to the langtag grammar. We can (and should) refer to Unicode Locale for locale stuff.

macchiati · 2024-09-16T18:08:44Z

Here is a reference. https://cldr-smoke.unicode.org/spec/main/ldml/tr35.html#BCP_47_Language_Tag_Conversion

I've felt for a while that we need to hoist the Unicode BCP 47 locale identifier definition, I think we could do that in this release.

aphillips · 2024-09-16T18:23:23Z

That's not what I mean. Where in the text does it need to change?

spec/registry/unicode.md

aphillips · 2024-09-17T01:18:49Z

@macchiati noted:

I think allowing "implementation-defined locale identifiers" is dangerous,

The text doesn't allow that. It allows the list to be formatted in an implementation defined way, e.g. a List<String> or Intl.Locale[]. This might be phrased better to make it clear, though.

I think the are-also formulation is overkill. We can just say "valid CLDR locale identifiers", although that places some burden on implementations that can guarantee langtag but don't have a local implementation of the CLDR rules. Well-formed tags might be acceptable in certain cases.

eemeli · 2024-10-13T07:48:18Z

Resolved conflicts with the main branch and renamed the files to not refer to a "registry", but to a "namespace".

aphillips

Looking good. Some suggestions.

spec/formatting.md

spec/u-namespace.md

Co-authored-by: Addison Phillips <addison@unicode.org>

test/README.md

Co-authored-by: Tim Chevalier <tjc@igalia.com>

aphillips

Very close to ready. Comments are somewhat nitpicky.

spec/formatting.md

spec/u-namespace.md

Co-authored-by: Eemeli Aro <eemeli@mozilla.com>

Co-authored-by: Addison Phillips <addison@unicode.org>

catamorphism · 2024-10-15T22:51:49Z

Should this PR also include a change to registry.md explaining how the :string function uses the value of u:dir? As it is, the tests are the only thing documenting how u:dir gets used, as far as I can see.

spec/u-namespace.md

aphillips · 2024-10-16T16:00:50Z

@catamorphism asked:

Should this PR also include a change to registry.md explaining how the :string function uses the value of u:dir? As it is, the tests are the only thing documenting how u:dir gets used, as far as I can see.

We need to update and rename registry.md soon.

u:dir is used by any expression as part of the default bidi isolation strategy.

aphillips · 2024-10-21T16:45:28Z

In the 2024-10-21 call we merged this so that it is visible in the spec. Open issues against the results if iteration is needed.

@stasm

* Create notes-2024-08-19.md * Accept attributes design & remove spec note (#845) * Accept attributes design & remove spec note * Disallow duplicate attribute names (closes #756) * Add link to contextual options PR * Add more prose to tag example text Co-authored-by: Addison Phillips <addison@unicode.org> * Mention attribute validity condition in the **_valid_** definition --------- Co-authored-by: Addison Phillips <addison@unicode.org> * Update selection-declaration design doc based on mtg / issue discussion (#867) * Add tests for pattern selection (#863) * Add tests for pattern selection * Add missing errors * Apply suggestions from code review Co-authored-by: Addison Phillips <addison@unicode.org> --------- Co-authored-by: Addison Phillips <addison@unicode.org> * Add Duplicate Variant to table in test/README.md (#861) * Add new selection-declaration alternative: Require annotation of selector variables in placeholders (#860) * Add new selection-declaration alternative: Require annotation of selector variables in placeholders * Improve examples * Switch example order * Update the stability policy (#834) * Update the stability policy Based on discussion in the 2024-07-22 call and in PR #829, update the stability policy. * A deeper, more thorough rewrite - Standardizes the phrasing completely. - Moves all potential future changes (which are not, after all, stability policies) to an "important" block - Removes duplication - Separates functions, options, and option values into separate guarantees - Clarifies the note about formatting changing over time * Update spec/README.md Co-authored-by: Tim Chevalier <tjc@igalia.com> * Update spec/README.md Co-authored-by: Eemeli Aro <eemeli@mozilla.com> * remove well-formed * Update spec/README.md --------- Co-authored-by: Tim Chevalier <tjc@igalia.com> Co-authored-by: Eemeli Aro <eemeli@mozilla.com> * Refine error handling text (#816) * Refine error handling text * Apply suggestions from code review Co-authored-by: Addison Phillips <addison@unicode.org> * Update fallback text * Turn bullet point list into paragraphs * Be more mighty Co-authored-by: Addison Phillips <addison@unicode.org> --------- Co-authored-by: Addison Phillips <addison@unicode.org> * Create notes-2024-08-26.md * Select "Match on variables instead of expressions" for selection-declarations (#824) * Select "Match on variables instead of expressions" for selection-declarations * Add hybrid option to selection-declaration.md (#870) * Add hybrid option to selection-declaration.md * Update selection-declaration.md fixed glitch in original edit * Update selection-declaration.md * Apply suggestions from code review Fixing typos Co-authored-by: Addison Phillips <addison@unicode.org> * Update selection-declaration.md * Update exploration/selection-declaration.md Co-authored-by: Eemeli Aro <eemeli@mozilla.com> * Update exploration/selection-declaration.md Co-authored-by: Eemeli Aro <eemeli@mozilla.com> * Update exploration/selection-declaration.md Co-authored-by: Eemeli Aro <eemeli@mozilla.com> --------- Co-authored-by: Addison Phillips <addison@unicode.org> Co-authored-by: Eemeli Aro <eemeli@mozilla.com> * Update selection-declaration.md --------- Co-authored-by: Mark Davis <mark@unicode.org> Co-authored-by: Addison Phillips <addison@unicode.org> * Fix "Allow immutable input declarative selectors" example (#874) * Update README.md (#875) * Update README.md * Update README.md * [DESIGN] Update bidi design document to show proposed design (#871) * [DESIGN] Update bidi design document to show proposed design The design I actually think we should adopt is the "hybrid approaches" one. This is a necessary first step on the highway to UAX31 compliance and I think is responsibly contained/managed. It is a hybrid approach, in that it permits testable strict implementations to be created (particularly for message serialization). This PR consists of moving text around. I added one "pro" to one option also. * Address comments * Miscellaneous test fixes (#862) * Add missing expected bad-selector errors * Fix expected parts for unsupported-statement test * Add a few new tests for leading-whitespace and duplicate-variant * Add tests for escaped-char changes made in #743 * Fix tests for attributes with variable values * Update contributing and joining info (#876) * Update contributing and joining info * Update README.md * Update CONTRIBUTING.md * Restore CLA copy * Clarify error & fallback handling (#879) * Clarify error & fallback handling * Apply suggestions from code review Co-authored-by: Addison Phillips <addison@unicode.org> * Select last rather than first attribute * Drop mention of "starting with Pattern Selection" * Attributes can't change the formatted output * Use "nor" instead of "or" regarding attribute restrictions --------- Co-authored-by: Addison Phillips <addison@unicode.org> * Clarify rule selection (#878) * Clarify rule selection Fixes #868 This adds normative SHOULD language to using CLDR plural and ordinal data, which was intended originally. - clarifies that keyword selection follows exact match - clarifies the purpose of rule-based selection - makes non-CLDR-based implementation permitted * Update spec/registry.md Co-authored-by: Eemeli Aro <eemeli@mozilla.com> * Update spec/registry.md Co-authored-by: Eemeli Aro <eemeli@mozilla.com> * Update spec/registry.md Co-authored-by: Eemeli Aro <eemeli@mozilla.com> --------- Co-authored-by: Eemeli Aro <eemeli@mozilla.com> * [DESIGN] Maintaining the Standard, Optional and Unicode Namespace Function Sets (#634) * Design doc to capture registry maintenance * Update maintaining-registry.md * Update exploration/maintaining-registry.md Co-authored-by: Tim Chevalier <tjc@igalia.com> * Update exploration/maintaining-registry.md Co-authored-by: Tim Chevalier <tjc@igalia.com> * Add user stories, small updates to RGI * Update exploration/maintaining-registry.md * Adding additional detail * Remove machine readable registry; update prose * Update maintaining-registry.md * Further development work * Update to change format and naming Per the 2024-08-19 call, we decided to switch towards a specification-per-function model, with statuses. This commit includes the initial set of changes to try and implement this. * Address some comments. --------- Co-authored-by: Tim Chevalier <tjc@igalia.com> * Create notes-2024-09-09.md * Fix a typo in an example (#880) The upcoming work to implement resolved value might make this patch unnecessary or obsolete, but fixing the typo (missing `{`/`}` around the variable in the pattern) just in case * Remove forward-compatibility promise and all reserved & private syntax (#883) * Remove forwards compatibility from stability guarantee * Drop reserved statements and expressions * Drop private-use annotations * Update tests * Clarify that deprecation is not removal * Match on variables instead of expressions (#877) * Match on variables instead of expressions * Apply suggestions from code review Co-authored-by: Addison Phillips <addison@unicode.org> * Apply suggestions from code review * Add missing test changes noticed during implementation * Empty commit to re-trigger CLA check --------- Co-authored-by: Addison Phillips <addison@unicode.org> * Create notes-2024-09-10.md * Add bidi support and address UAX31/UTS55 requirements (#884) * Add bidi support and address UAX31/UTS55 requirements Adds the bidi strong marks ALM, RLM, and LRM plus the bidi isolate controls LRI, RLI, FSI, and PDI to the syntax. Formally defines optional vs. non-optional whitespace. Non-optional whitespace must include at least one whitespace character. Optional whitespace may contain only bidi marks (which are invisible) * Update syntax.md including text from previous PR * Repair the guidance on strongly directional marks Include ALM and better specify how to use the marks. * Fix formatting of the "important" * Add bidi characters to description of whitespace. * Permit bidi in a few more places Add optional whitespace at the start of `variant` Add optional whitespace around `quoted-pattern` These changes result in allowing bidi around keys and quoted patterns as intended. * Update syntax.md ABNF * Update formatting.md - Add a note about the difference between formatting and message syntax. - Clarify the sentence about message directionality. * Address comment about name/identifier * Address comments related to bidi in `name` * Fix variable's location * Address comment about the list of LRI/PDI targets * One character typo :-P * Update spec/syntax.md Co-authored-by: Eemeli Aro <eemeli@mozilla.com> * Address comments about rule R3a-1 * Update spec/syntax.md Co-authored-by: Eemeli Aro <eemeli@mozilla.com> * Address comment about U+061C * Change [o]wsp => `o` or `s` * Match syntax spec to abnf * Remove * * Update syntax.md * Update spec/syntax.md Co-authored-by: Eemeli Aro <eemeli@mozilla.com> * Update spec/message.abnf Co-authored-by: Eemeli Aro <eemeli@mozilla.com> * Update spec/message.abnf Co-authored-by: Eemeli Aro <eemeli@mozilla.com> * Update syntax.md * Update spec/message.abnf Co-authored-by: Eemeli Aro <eemeli@mozilla.com> * Update spec/syntax.md Co-authored-by: Eemeli Aro <eemeli@mozilla.com> * Update spec/syntax.md Co-authored-by: Eemeli Aro <eemeli@mozilla.com> --------- Co-authored-by: Eemeli Aro <eemeli@mozilla.com> * Specify `bad-option` for bad digit size option values (#882) * Specify `bad-option` for bad digit size option values Fixes #739 * adopt 'non-negative integer' * Create notes-2024-09-16.md * Address name and literal equality (#885) * Address name and literal equality This change defines equality as discussed in the 2024-09-09 teleconference in the following ways: - It defines _name_ equality as being under NFC - It defines _literal_ equality as explicitly **not** under NFC - It moves _name_ before _identifier_ in that section of text to avoid a forward definition. Note that this deviates from discussion in 2024-09-09's call in that we didn't discuss literals at length. It also doesn't discuss non-name/non-literal values, which I'll point out are limited to ASCII sequences such as keywords. * Typo fix * Add a note about not requiring implementations to actually normalize * Implement changes dicussed in 2024-09-16 call. - Make _key_ require NFC for uniqueness/comparison - Add a note about NFC - Make _literal_ **_not_** define equality - Make text in _name_ identical to that in _key_ for consistency * Update formatting.md to include keys in NFC * Address comments * Update spec/syntax.md Co-authored-by: Eemeli Aro <eemeli@mozilla.com> * Update spec/syntax.md Co-authored-by: Eemeli Aro <eemeli@mozilla.com> --------- Co-authored-by: Eemeli Aro <eemeli@mozilla.com> * Update list of normative changes during the LDML45 period (#890) * Fix typos in data-model-errors tests (#892) Fix #886 * Update note on exact numeric match for v46 (#891) Addresses #887 Non-normative changes to the notes specifically part of LDML46 * Fix attribute value to be literal (#894) Fixes #893 * Create notes-2024-09-30.md * Add Resolved Values and Function Handler sections to formatting (#728) * Add Resolved Values section to formatting * Apply suggestions from code review * Apply suggestions from code review * Apply suggestions from code review Co-authored-by: Tim Chevalier <tjc@igalia.com> * Linkify "resolved value" * Add some examples & explicitly allow wrapping input values * No throw, only emit Co-authored-by: Tim Chevalier <tjc@igalia.com> * Add section on Function Handlers, defining the term * Apply suggestions from code review * Rephrase initial resolved value definition * Update spec/formatting.md Co-authored-by: Eemeli Aro <eemeli@mozilla.com> * Update resolved value definition again Co-authored-by: Addison Phillips <addison@unicode.org> --------- Co-authored-by: Tim Chevalier <tjc@igalia.com> Co-authored-by: Addison Phillips <addison@unicode.org> * Define function composition for :number and :integer values (#823) * Define function composition for :number and :integer values * Apply suggestions from code review Co-authored-by: Addison Phillips <addison@unicode.org> * Add operand option priority example * Add apostrophes' Co-authored-by: Tim Chevalier <tjc@igalia.com> * Update spec/registry.md Co-authored-by: Eemeli Aro <eemeli@mozilla.com> * Update spec/registry.md Co-authored-by: Eemeli Aro <eemeli@mozilla.com> --------- Co-authored-by: Addison Phillips <addison@unicode.org> Co-authored-by: Tim Chevalier <tjc@igalia.com> * Create notes-2024-10-07.md * Apply NFC normalization during :string key comparison (#905) * Apply NFC normalization during :string key comparison * Add link to UAX#15 Co-authored-by: Addison Phillips <addison@unicode.org> --------- Co-authored-by: Addison Phillips <addison@unicode.org> * Add tests for changes due to bidi/whitespace (#902) * Add tests for changes due to bidi/whitespace * Correct output * Make erroneous test a syntax error * Define function composition for date/time values (#814) * Define function composition for date/time values * Apply suggestions from code review Co-authored-by: Stanisław Małolepszy <sta@malolepszy.org> * Drop the "only" * Update spec/registry.md * Update spec/registry.md Co-authored-by: Eemeli Aro <eemeli@mozilla.com> * Update spec/registry.md Co-authored-by: Eemeli Aro <eemeli@mozilla.com> * Update spec/registry.md Co-authored-by: Eemeli Aro <eemeli@mozilla.com> * Make :date and :time composition implementation-defined --------- Co-authored-by: Stanisław Małolepszy <sta@malolepszy.org> Co-authored-by: Addison Phillips <addison@unicode.org> * DESIGN: Add alternative designs to the design doc on function composition (#806) * DESIGN: Add a sequel to the design doc on function composition This document sketches out some alternatives for the machinery provided to enable function composition. The goal is to provide an exhaustive list of alternatives. * Remove 'part 2' document and move contents to the end of part 1 * Revise introduction to reflect the changed goal * Edited for conciseness * Further edits for conciseness * Give a name to InputType and use it * Refer to motivating examples * Update function-composition-part-1.md status Per 2024-10-14 telecon * Create notes-2024-10-14.md * Add test for :integer and :number composition (#907) * Fix `:integer` option `useGrouping` values (#912) I noticed that `:integer` does not include the "never" value for the option `useGrouping`. This is a bug. * Drop syntax note on additional bidi changes (#910) Drop syntax note on addition bidi changes * Add tests for changes due to #885 (name/literal equality) (#904) * Add tests for changes due to #885 (name/literal equality) * Update test/tests/functions/string.json Co-authored-by: Eemeli Aro <eemeli@gmail.com> * Update test/tests/syntax.json Co-authored-by: Eemeli Aro <eemeli@gmail.com> * Update test/tests/functions/string.json Co-authored-by: Eemeli Aro <eemeli@gmail.com> * Added tests for reordering and special case mapping * Add another selection test --------- Co-authored-by: Eemeli Aro <eemeli@gmail.com> * Add u: options namespace (#846) * Move spec/registry.md -> spec/registry/default.md * Add Unicode Registry definition * Refer to BCP47, add note about only requiring normal tags * Call it a namespace * Apply suggestions from code review Co-authored-by: Addison Phillips <addison@unicode.org> * Fix test file reference Co-authored-by: Tim Chevalier <tjc@igalia.com> * Apply suggestions from code review * Update spec/u-namespace.md Co-authored-by: Eemeli Aro <eemeli@mozilla.com> * Apply suggestions from code review Co-authored-by: Addison Phillips <addison@unicode.org> * Apply suggestions from code review Co-authored-by: Addison Phillips <addison@unicode.org> * Add mention of functions to namespace description --------- Co-authored-by: Addison Phillips <addison@unicode.org> Co-authored-by: Tim Chevalier <tjc@igalia.com> * Define function composition for :string values (#798) * Define function composition for :string values * Update spec/registry.md as suggested by @stasm in #814 * Drop the "only" * Update text following code review comments --------- Co-authored-by: Addison Phillips <addison@unicode.org> * Drop data model request for feedback on "name" (#909) * Allow surrogates in content, issue #895 (#906) * Allow surrogates in content, issue #895 * Grammar and typos, linkify terms, make into a note, and fix 2119 keywords Thanks Addison! Co-authored-by: Addison Phillips <addisonI18N@gmail.com> * Not using "localizable elements" Co-authored-by: Addison Phillips <addisonI18N@gmail.com> * Keep syntax.md in sync with message.abnf * Added note about surrogates to quoted literals * Moved the note about surrogates from Security Considerations to The Message * Update spec/syntax.md * Update spec/syntax.md * Italicize in a couple of places * Implemeted more (all?) feedback from review --------- Co-authored-by: Addison Phillips <addisonI18N@gmail.com> --------- Co-authored-by: Eemeli Aro <eemeli@mozilla.com> Co-authored-by: Elango Cheran <elango@unicode.org> Co-authored-by: Tim Chevalier <tjc@igalia.com> Co-authored-by: Mark Davis <mark@unicode.org> Co-authored-by: Danny Gleckler <daniel.gleckler@d2l.com> Co-authored-by: Steven R. Loomis <srl295@gmail.com> Co-authored-by: Stanisław Małolepszy <sta@malolepszy.org> Co-authored-by: Eemeli Aro <eemeli@gmail.com> Co-authored-by: Mihai Nita <nmihai_2000@yahoo.com>

@eemeli

* [DESIGN] Number selection design refinements This is to build up and capture technical considerations for how to address the issues raised by @eemeli's PR #842. * Update examples to match changes to syntax Also responds to the long discussion with @eemeli about significant digits by removing from the example. * Address 2024-09-16 call comments This changes the status to "Re-Opened" and adds a link to the PR. Expect to merge this imminently, although discussion on number selection remains. * Update exploration/number-selection.md Co-authored-by: Eemeli Aro <eemeli@mozilla.com> * Update from main (#914) * Create notes-2024-08-19.md * Accept attributes design & remove spec note (#845) * Accept attributes design & remove spec note * Disallow duplicate attribute names (closes #756) * Add link to contextual options PR * Add more prose to tag example text Co-authored-by: Addison Phillips <addison@unicode.org> * Mention attribute validity condition in the **_valid_** definition --------- Co-authored-by: Addison Phillips <addison@unicode.org> * Update selection-declaration design doc based on mtg / issue discussion (#867) * Add tests for pattern selection (#863) * Add tests for pattern selection * Add missing errors * Apply suggestions from code review Co-authored-by: Addison Phillips <addison@unicode.org> --------- Co-authored-by: Addison Phillips <addison@unicode.org> * Add Duplicate Variant to table in test/README.md (#861) * Add new selection-declaration alternative: Require annotation of selector variables in placeholders (#860) * Add new selection-declaration alternative: Require annotation of selector variables in placeholders * Improve examples * Switch example order * Update the stability policy (#834) * Update the stability policy Based on discussion in the 2024-07-22 call and in PR #829, update the stability policy. * A deeper, more thorough rewrite - Standardizes the phrasing completely. - Moves all potential future changes (which are not, after all, stability policies) to an "important" block - Removes duplication - Separates functions, options, and option values into separate guarantees - Clarifies the note about formatting changing over time * Update spec/README.md Co-authored-by: Tim Chevalier <tjc@igalia.com> * Update spec/README.md Co-authored-by: Eemeli Aro <eemeli@mozilla.com> * remove well-formed * Update spec/README.md --------- Co-authored-by: Tim Chevalier <tjc@igalia.com> Co-authored-by: Eemeli Aro <eemeli@mozilla.com> * Refine error handling text (#816) * Refine error handling text * Apply suggestions from code review Co-authored-by: Addison Phillips <addison@unicode.org> * Update fallback text * Turn bullet point list into paragraphs * Be more mighty Co-authored-by: Addison Phillips <addison@unicode.org> --------- Co-authored-by: Addison Phillips <addison@unicode.org> * Create notes-2024-08-26.md * Select "Match on variables instead of expressions" for selection-declarations (#824) * Select "Match on variables instead of expressions" for selection-declarations * Add hybrid option to selection-declaration.md (#870) * Add hybrid option to selection-declaration.md * Update selection-declaration.md fixed glitch in original edit * Update selection-declaration.md * Apply suggestions from code review Fixing typos Co-authored-by: Addison Phillips <addison@unicode.org> * Update selection-declaration.md * Update exploration/selection-declaration.md Co-authored-by: Eemeli Aro <eemeli@mozilla.com> * Update exploration/selection-declaration.md Co-authored-by: Eemeli Aro <eemeli@mozilla.com> * Update exploration/selection-declaration.md Co-authored-by: Eemeli Aro <eemeli@mozilla.com> --------- Co-authored-by: Addison Phillips <addison@unicode.org> Co-authored-by: Eemeli Aro <eemeli@mozilla.com> * Update selection-declaration.md --------- Co-authored-by: Mark Davis <mark@unicode.org> Co-authored-by: Addison Phillips <addison@unicode.org> * Fix "Allow immutable input declarative selectors" example (#874) * Update README.md (#875) * Update README.md * Update README.md * [DESIGN] Update bidi design document to show proposed design (#871) * [DESIGN] Update bidi design document to show proposed design The design I actually think we should adopt is the "hybrid approaches" one. This is a necessary first step on the highway to UAX31 compliance and I think is responsibly contained/managed. It is a hybrid approach, in that it permits testable strict implementations to be created (particularly for message serialization). This PR consists of moving text around. I added one "pro" to one option also. * Address comments * Miscellaneous test fixes (#862) * Add missing expected bad-selector errors * Fix expected parts for unsupported-statement test * Add a few new tests for leading-whitespace and duplicate-variant * Add tests for escaped-char changes made in #743 * Fix tests for attributes with variable values * Update contributing and joining info (#876) * Update contributing and joining info * Update README.md * Update CONTRIBUTING.md * Restore CLA copy * Clarify error & fallback handling (#879) * Clarify error & fallback handling * Apply suggestions from code review Co-authored-by: Addison Phillips <addison@unicode.org> * Select last rather than first attribute * Drop mention of "starting with Pattern Selection" * Attributes can't change the formatted output * Use "nor" instead of "or" regarding attribute restrictions --------- Co-authored-by: Addison Phillips <addison@unicode.org> * Clarify rule selection (#878) * Clarify rule selection Fixes #868 This adds normative SHOULD language to using CLDR plural and ordinal data, which was intended originally. - clarifies that keyword selection follows exact match - clarifies the purpose of rule-based selection - makes non-CLDR-based implementation permitted * Update spec/registry.md Co-authored-by: Eemeli Aro <eemeli@mozilla.com> * Update spec/registry.md Co-authored-by: Eemeli Aro <eemeli@mozilla.com> * Update spec/registry.md Co-authored-by: Eemeli Aro <eemeli@mozilla.com> --------- Co-authored-by: Eemeli Aro <eemeli@mozilla.com> * [DESIGN] Maintaining the Standard, Optional and Unicode Namespace Function Sets (#634) * Design doc to capture registry maintenance * Update maintaining-registry.md * Update exploration/maintaining-registry.md Co-authored-by: Tim Chevalier <tjc@igalia.com> * Update exploration/maintaining-registry.md Co-authored-by: Tim Chevalier <tjc@igalia.com> * Add user stories, small updates to RGI * Update exploration/maintaining-registry.md * Adding additional detail * Remove machine readable registry; update prose * Update maintaining-registry.md * Further development work * Update to change format and naming Per the 2024-08-19 call, we decided to switch towards a specification-per-function model, with statuses. This commit includes the initial set of changes to try and implement this. * Address some comments. --------- Co-authored-by: Tim Chevalier <tjc@igalia.com> * Create notes-2024-09-09.md * Fix a typo in an example (#880) The upcoming work to implement resolved value might make this patch unnecessary or obsolete, but fixing the typo (missing `{`/`}` around the variable in the pattern) just in case * Remove forward-compatibility promise and all reserved & private syntax (#883) * Remove forwards compatibility from stability guarantee * Drop reserved statements and expressions * Drop private-use annotations * Update tests * Clarify that deprecation is not removal * Match on variables instead of expressions (#877) * Match on variables instead of expressions * Apply suggestions from code review Co-authored-by: Addison Phillips <addison@unicode.org> * Apply suggestions from code review * Add missing test changes noticed during implementation * Empty commit to re-trigger CLA check --------- Co-authored-by: Addison Phillips <addison@unicode.org> * Create notes-2024-09-10.md * Add bidi support and address UAX31/UTS55 requirements (#884) * Add bidi support and address UAX31/UTS55 requirements Adds the bidi strong marks ALM, RLM, and LRM plus the bidi isolate controls LRI, RLI, FSI, and PDI to the syntax. Formally defines optional vs. non-optional whitespace. Non-optional whitespace must include at least one whitespace character. Optional whitespace may contain only bidi marks (which are invisible) * Update syntax.md including text from previous PR * Repair the guidance on strongly directional marks Include ALM and better specify how to use the marks. * Fix formatting of the "important" * Add bidi characters to description of whitespace. * Permit bidi in a few more places Add optional whitespace at the start of `variant` Add optional whitespace around `quoted-pattern` These changes result in allowing bidi around keys and quoted patterns as intended. * Update syntax.md ABNF * Update formatting.md - Add a note about the difference between formatting and message syntax. - Clarify the sentence about message directionality. * Address comment about name/identifier * Address comments related to bidi in `name` * Fix variable's location * Address comment about the list of LRI/PDI targets * One character typo :-P * Update spec/syntax.md Co-authored-by: Eemeli Aro <eemeli@mozilla.com> * Address comments about rule R3a-1 * Update spec/syntax.md Co-authored-by: Eemeli Aro <eemeli@mozilla.com> * Address comment about U+061C * Change [o]wsp => `o` or `s` * Match syntax spec to abnf * Remove * * Update syntax.md * Update spec/syntax.md Co-authored-by: Eemeli Aro <eemeli@mozilla.com> * Update spec/message.abnf Co-authored-by: Eemeli Aro <eemeli@mozilla.com> * Update spec/message.abnf Co-authored-by: Eemeli Aro <eemeli@mozilla.com> * Update syntax.md * Update spec/message.abnf Co-authored-by: Eemeli Aro <eemeli@mozilla.com> * Update spec/syntax.md Co-authored-by: Eemeli Aro <eemeli@mozilla.com> * Update spec/syntax.md Co-authored-by: Eemeli Aro <eemeli@mozilla.com> --------- Co-authored-by: Eemeli Aro <eemeli@mozilla.com> * Specify `bad-option` for bad digit size option values (#882) * Specify `bad-option` for bad digit size option values Fixes #739 * adopt 'non-negative integer' * Create notes-2024-09-16.md * Address name and literal equality (#885) * Address name and literal equality This change defines equality as discussed in the 2024-09-09 teleconference in the following ways: - It defines _name_ equality as being under NFC - It defines _literal_ equality as explicitly **not** under NFC - It moves _name_ before _identifier_ in that section of text to avoid a forward definition. Note that this deviates from discussion in 2024-09-09's call in that we didn't discuss literals at length. It also doesn't discuss non-name/non-literal values, which I'll point out are limited to ASCII sequences such as keywords. * Typo fix * Add a note about not requiring implementations to actually normalize * Implement changes dicussed in 2024-09-16 call. - Make _key_ require NFC for uniqueness/comparison - Add a note about NFC - Make _literal_ **_not_** define equality - Make text in _name_ identical to that in _key_ for consistency * Update formatting.md to include keys in NFC * Address comments * Update spec/syntax.md Co-authored-by: Eemeli Aro <eemeli@mozilla.com> * Update spec/syntax.md Co-authored-by: Eemeli Aro <eemeli@mozilla.com> --------- Co-authored-by: Eemeli Aro <eemeli@mozilla.com> * Update list of normative changes during the LDML45 period (#890) * Fix typos in data-model-errors tests (#892) Fix #886 * Update note on exact numeric match for v46 (#891) Addresses #887 Non-normative changes to the notes specifically part of LDML46 * Fix attribute value to be literal (#894) Fixes #893 * Create notes-2024-09-30.md * Add Resolved Values and Function Handler sections to formatting (#728) * Add Resolved Values section to formatting * Apply suggestions from code review * Apply suggestions from code review * Apply suggestions from code review Co-authored-by: Tim Chevalier <tjc@igalia.com> * Linkify "resolved value" * Add some examples & explicitly allow wrapping input values * No throw, only emit Co-authored-by: Tim Chevalier <tjc@igalia.com> * Add section on Function Handlers, defining the term * Apply suggestions from code review * Rephrase initial resolved value definition * Update spec/formatting.md Co-authored-by: Eemeli Aro <eemeli@mozilla.com> * Update resolved value definition again Co-authored-by: Addison Phillips <addison@unicode.org> --------- Co-authored-by: Tim Chevalier <tjc@igalia.com> Co-authored-by: Addison Phillips <addison@unicode.org> * Define function composition for :number and :integer values (#823) * Define function composition for :number and :integer values * Apply suggestions from code review Co-authored-by: Addison Phillips <addison@unicode.org> * Add operand option priority example * Add apostrophes' Co-authored-by: Tim Chevalier <tjc@igalia.com> * Update spec/registry.md Co-authored-by: Eemeli Aro <eemeli@mozilla.com> * Update spec/registry.md Co-authored-by: Eemeli Aro <eemeli@mozilla.com> --------- Co-authored-by: Addison Phillips <addison@unicode.org> Co-authored-by: Tim Chevalier <tjc@igalia.com> * Create notes-2024-10-07.md * Apply NFC normalization during :string key comparison (#905) * Apply NFC normalization during :string key comparison * Add link to UAX#15 Co-authored-by: Addison Phillips <addison@unicode.org> --------- Co-authored-by: Addison Phillips <addison@unicode.org> * Add tests for changes due to bidi/whitespace (#902) * Add tests for changes due to bidi/whitespace * Correct output * Make erroneous test a syntax error * Define function composition for date/time values (#814) * Define function composition for date/time values * Apply suggestions from code review Co-authored-by: Stanisław Małolepszy <sta@malolepszy.org> * Drop the "only" * Update spec/registry.md * Update spec/registry.md Co-authored-by: Eemeli Aro <eemeli@mozilla.com> * Update spec/registry.md Co-authored-by: Eemeli Aro <eemeli@mozilla.com> * Update spec/registry.md Co-authored-by: Eemeli Aro <eemeli@mozilla.com> * Make :date and :time composition implementation-defined --------- Co-authored-by: Stanisław Małolepszy <sta@malolepszy.org> Co-authored-by: Addison Phillips <addison@unicode.org> * DESIGN: Add alternative designs to the design doc on function composition (#806) * DESIGN: Add a sequel to the design doc on function composition This document sketches out some alternatives for the machinery provided to enable function composition. The goal is to provide an exhaustive list of alternatives. * Remove 'part 2' document and move contents to the end of part 1 * Revise introduction to reflect the changed goal * Edited for conciseness * Further edits for conciseness * Give a name to InputType and use it * Refer to motivating examples * Update function-composition-part-1.md status Per 2024-10-14 telecon * Create notes-2024-10-14.md * Add test for :integer and :number composition (#907) * Fix `:integer` option `useGrouping` values (#912) I noticed that `:integer` does not include the "never" value for the option `useGrouping`. This is a bug. * Drop syntax note on additional bidi changes (#910) Drop syntax note on addition bidi changes * Add tests for changes due to #885 (name/literal equality) (#904) * Add tests for changes due to #885 (name/literal equality) * Update test/tests/functions/string.json Co-authored-by: Eemeli Aro <eemeli@gmail.com> * Update test/tests/syntax.json Co-authored-by: Eemeli Aro <eemeli@gmail.com> * Update test/tests/functions/string.json Co-authored-by: Eemeli Aro <eemeli@gmail.com> * Added tests for reordering and special case mapping * Add another selection test --------- Co-authored-by: Eemeli Aro <eemeli@gmail.com> * Add u: options namespace (#846) * Move spec/registry.md -> spec/registry/default.md * Add Unicode Registry definition * Refer to BCP47, add note about only requiring normal tags * Call it a namespace * Apply suggestions from code review Co-authored-by: Addison Phillips <addison@unicode.org> * Fix test file reference Co-authored-by: Tim Chevalier <tjc@igalia.com> * Apply suggestions from code review * Update spec/u-namespace.md Co-authored-by: Eemeli Aro <eemeli@mozilla.com> * Apply suggestions from code review Co-authored-by: Addison Phillips <addison@unicode.org> * Apply suggestions from code review Co-authored-by: Addison Phillips <addison@unicode.org> * Add mention of functions to namespace description --------- Co-authored-by: Addison Phillips <addison@unicode.org> Co-authored-by: Tim Chevalier <tjc@igalia.com> * Define function composition for :string values (#798) * Define function composition for :string values * Update spec/registry.md as suggested by @stasm in #814 * Drop the "only" * Update text following code review comments --------- Co-authored-by: Addison Phillips <addison@unicode.org> * Drop data model request for feedback on "name" (#909) * Allow surrogates in content, issue #895 (#906) * Allow surrogates in content, issue #895 * Grammar and typos, linkify terms, make into a note, and fix 2119 keywords Thanks Addison! Co-authored-by: Addison Phillips <addisonI18N@gmail.com> * Not using "localizable elements" Co-authored-by: Addison Phillips <addisonI18N@gmail.com> * Keep syntax.md in sync with message.abnf * Added note about surrogates to quoted literals * Moved the note about surrogates from Security Considerations to The Message * Update spec/syntax.md * Update spec/syntax.md * Italicize in a couple of places * Implemeted more (all?) feedback from review --------- Co-authored-by: Addison Phillips <addisonI18N@gmail.com> --------- Co-authored-by: Eemeli Aro <eemeli@mozilla.com> Co-authored-by: Elango Cheran <elango@unicode.org> Co-authored-by: Tim Chevalier <tjc@igalia.com> Co-authored-by: Mark Davis <mark@unicode.org> Co-authored-by: Danny Gleckler <daniel.gleckler@d2l.com> Co-authored-by: Steven R. Loomis <srl295@gmail.com> Co-authored-by: Stanisław Małolepszy <sta@malolepszy.org> Co-authored-by: Eemeli Aro <eemeli@gmail.com> Co-authored-by: Mihai Nita <nmihai_2000@yahoo.com> * Add serialization proposal * Revert "Add serialization proposal" This reverts commit 17af553. * Revert "Update from main (#914)" This reverts commit da9377b. * Add serialization proposal --------- Co-authored-by: Eemeli Aro <eemeli@mozilla.com> Co-authored-by: Elango Cheran <elango@unicode.org> Co-authored-by: Tim Chevalier <tjc@igalia.com> Co-authored-by: Mark Davis <mark@unicode.org> Co-authored-by: Danny Gleckler <daniel.gleckler@d2l.com> Co-authored-by: Steven R. Loomis <srl295@gmail.com> Co-authored-by: Stanisław Małolepszy <sta@malolepszy.org> Co-authored-by: Eemeli Aro <eemeli@gmail.com> Co-authored-by: Mihai Nita <nmihai_2000@yahoo.com>

eemeli added 2 commits July 30, 2024 12:35

Move spec/registry.md -> spec/registry/default.md

0117fee

Add Unicode Registry definition

f969ab6

eemeli added registry specification formatting test-suite labels Jul 30, 2024

aphillips reviewed Jul 30, 2024

View reviewed changes

Refer to BCP47, add note about only requiring normal tags

3a3d4ab

eemeli mentioned this pull request Aug 19, 2024

Accept attributes design & remove spec note #845

Merged

macchiati requested changes Sep 16, 2024

View reviewed changes

macchiati requested changes Sep 17, 2024

View reviewed changes

spec/registry/unicode.md Outdated Show resolved Hide resolved

eemeli added 2 commits October 13, 2024 10:15

Merge branch 'main' into u-options

6c20950

Call it a namespace

087bd0d

eemeli changed the title ~~Add Unicode Registry definition~~ Add u: options namespace Oct 13, 2024

aphillips reviewed Oct 13, 2024

View reviewed changes

spec/formatting.md Outdated Show resolved Hide resolved

spec/u-namespace.md Outdated Show resolved Hide resolved

spec/u-namespace.md Outdated Show resolved Hide resolved

spec/u-namespace.md Outdated Show resolved Hide resolved

spec/u-namespace.md Outdated Show resolved Hide resolved

Apply suggestions from code review

9c307cb

Co-authored-by: Addison Phillips <addison@unicode.org>

catamorphism requested changes Oct 14, 2024

View reviewed changes

test/README.md Outdated Show resolved Hide resolved

eemeli and others added 2 commits October 14, 2024 22:55

Fix test file reference

af2d4e9

Co-authored-by: Tim Chevalier <tjc@igalia.com>

Apply suggestions from code review

b4b2921

eemeli requested review from aphillips, macchiati, catamorphism and mihnita October 15, 2024 09:02

macchiati approved these changes Oct 15, 2024

View reviewed changes

aphillips requested changes Oct 15, 2024

View reviewed changes

eemeli commented Oct 15, 2024

View reviewed changes

spec/u-namespace.md Outdated Show resolved Hide resolved

aphillips and others added 3 commits October 15, 2024 07:56

Update spec/u-namespace.md

680d25d

Co-authored-by: Eemeli Aro <eemeli@mozilla.com>

Apply suggestions from code review

01fed13

Co-authored-by: Addison Phillips <addison@unicode.org>

Apply suggestions from code review

de56e4c

Co-authored-by: Addison Phillips <addison@unicode.org>

eemeli requested a review from aphillips October 15, 2024 18:06

aphillips approved these changes Oct 15, 2024

View reviewed changes

catamorphism approved these changes Oct 15, 2024

View reviewed changes

macchiati requested changes Oct 15, 2024

View reviewed changes

spec/u-namespace.md Show resolved Hide resolved

Add mention of functions to namespace description

0c9414b

eemeli requested a review from macchiati October 17, 2024 06:45

aphillips merged commit 7f9a4de into main Oct 21, 2024
2 checks passed

aphillips deleted the u-options branch October 21, 2024 16:45

eemeli added a commit to messageformat/messageformat that referenced this pull request Oct 27, 2024

feat(mf2): Support u:locale option (unicode-org/message-format-wg#846)

35ab407

eemeli added a commit to messageformat/messageformat that referenced this pull request Oct 27, 2024

feat(mf2): Support u:id option (unicode-org/message-format-wg#846)

5b2254e

eemeli added a commit to messageformat/messageformat that referenced this pull request Nov 5, 2024

feat(mf2): Support u:id option (unicode-org/message-format-wg#846)

d86b1c1

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Add u: options namespace #846

Add u: options namespace #846

eemeli commented Jul 30, 2024

aphillips left a comment

aphillips Jul 30, 2024

eemeli Jul 30, 2024

mihnita Aug 5, 2024

aphillips Sep 16, 2024

macchiati left a comment

aphillips commented Sep 16, 2024

macchiati commented Sep 16, 2024

aphillips commented Sep 16, 2024

aphillips commented Sep 17, 2024

eemeli commented Oct 13, 2024

aphillips left a comment

aphillips left a comment

catamorphism commented Oct 15, 2024

aphillips commented Oct 16, 2024

aphillips commented Oct 21, 2024

	If the resolved mapping of _options_ includes any `u:` options
	Implementations are encouraged to support _options_ defined in
	the Unicode Reserved Namespace (`u:`).

Add u: options namespace #846

Add u: options namespace #846

Conversation

eemeli commented Jul 30, 2024

aphillips left a comment

Choose a reason for hiding this comment

aphillips Jul 30, 2024

Choose a reason for hiding this comment

eemeli Jul 30, 2024

Choose a reason for hiding this comment

mihnita Aug 5, 2024

Choose a reason for hiding this comment

aphillips Sep 16, 2024

Choose a reason for hiding this comment

macchiati left a comment

Choose a reason for hiding this comment

aphillips commented Sep 16, 2024

macchiati commented Sep 16, 2024

aphillips commented Sep 16, 2024

aphillips commented Sep 17, 2024

eemeli commented Oct 13, 2024

aphillips left a comment

Choose a reason for hiding this comment

aphillips left a comment

Choose a reason for hiding this comment

catamorphism commented Oct 15, 2024

aphillips commented Oct 16, 2024

aphillips commented Oct 21, 2024