Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

EVM - Packet receipts must be stored under the commitment path #1663

Closed
hussein-aitlahcen opened this issue Apr 3, 2024 · 0 comments · Fixed by #1782
Closed

EVM - Packet receipts must be stored under the commitment path #1663

hussein-aitlahcen opened this issue Apr 3, 2024 · 0 comments · Fixed by #1782
Labels
C-bug Category: This is a bug. E-easy Call for participation: Easy difficulty. Experience needed to fix: Not much. Good first issue.

Comments

@hussein-aitlahcen
Copy link
Contributor

Reference:

Remove packetReceipts mapping in favor of saving the commitment (boolean true) under the expected commitment path.

The path should be

union/evm/contracts/core/04-channel/IBCPacket.sol

Line 532 in 4ac94d8

IBCCommitment.packetReceiptCommitmentPath(

@hussein-aitlahcen hussein-aitlahcen added C-bug Category: This is a bug. E-easy Call for participation: Easy difficulty. Experience needed to fix: Not much. Good first issue. labels Apr 3, 2024
@hussein-aitlahcen hussein-aitlahcen mentioned this issue Apr 4, 2024
Open
@benluelo benluelo mentioned this issue Apr 5, 2024
Merged
benluelo added a commit that referenced this issue Apr 5, 2024
@benluelo
refactor(unionlabs): clean up ics24 (previously proof) module (#1675)
2586181 
closes #1673

After some internal discussion, I think it's best to keep this module in
`unionlabs`, to avoid over-fragmenting our codebase; however the module
rename is still good.

- `unionlabs::proof` -> `unionlabs::ics24`
- added the remaining paths (receipts and next sequence paths)
- implementations in `chain_utils::ethereum` are stubbed out for now,
until #1663 is resolved
- simple proc macro for generating the `Display` and `FromStr`
implementations
  - much nicer to look at the module now lol
  - also one less use site of `derive_more`
- removed the `Path` suffix from the `Path` enum variants
- `IbcPath::Output` -> `IbcPath::Value`
- `Output` is just my default associated type name, `Value` is clearer
(although still not great, open to suggestions)
@hussein-aitlahcen hussein-aitlahcen mentioned this issue Apr 11, 2024
Closed
@hussein-aitlahcen hussein-aitlahcen mentioned this issue Apr 18, 2024
Merged
hussein-aitlahcen added a commit that referenced this issue Apr 22, 2024
@hussein-aitlahcen
feat(evm): ics24 compliant (#1782)
9ead3f2 
fixes #1663 
fixes #1739 
fixes #1489
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
C-bug Category: This is a bug. E-easy Call for participation: Easy difficulty. Experience needed to fix: Not much. Good first issue.
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

feat(evm): ics24 compliant unionlabs/union
1 participant
@hussein-aitlahcen