feat(mpp-idea): implement Code Review functionality#6
Conversation
- Add IdeaCodeReviewModels.kt with data models (IdeaCodeReviewState, IdeaCommitInfo, IdeaDiffFileInfo, IdeaAIAnalysisProgress, IdeaAnalysisStage) - Add IdeaCodeReviewViewModel.kt with git operations using GitOperations (JVM) and CodeReviewAgent integration - Add IdeaCodeReviewContent.kt with three-panel Jewel UI (commit list, diff viewer, AI analysis panel) - Integrate Code Review tab in IdeaAgentApp.kt - Update IdeaAgentToolWindowFactory.kt to pass project and coroutineScope
WalkthroughAdds IntelliJ Code Review UI scaffolding: a three‑pane composable, new state models, a lifecycle-aware IdeaCodeReviewViewModel, and updated IdeaAgentApp/ToolWindow wiring to accept Project and CoroutineScope for viewmodel lifecycle. Changes
Sequence DiagramsequenceDiagram
actor User
participant UI as Code Review UI
participant VM as IdeaCodeReviewViewModel
participant Git as GitOperations
participant Agent as CodeReviewAgent
participant LLM as KoogLLMService
User->>UI: Open CODE_REVIEW tab
UI->>VM: lazy init (project, coroutineScope)
VM->>Git: loadCommitHistory()
Git-->>VM: commits
VM-->>UI: update commit list
User->>UI: Select commit(s)
UI->>VM: selectCommits(indices)
VM->>Git: loadCommitDiff(commits)
Git-->>VM: diffs per file
VM-->>UI: update diffs
User->>UI: Start analysis
UI->>VM: startAnalysis()
VM->>Agent: initialize/run ReviewTask (streaming)
Agent->>LLM: streaming requests
LLM-->>Agent: streaming responses
Agent-->>VM: progress updates
VM-->>UI: update analysis panel
User->>UI: Close tab
UI->>VM: dispose ViewModel
Estimated code review effort🎯 4 (Complex) | ⏱️ ~45 minutes
Possibly related PRs
Poem
Pre-merge checks and finishing touches❌ Failed checks (1 warning)
✅ Passed checks (2 passed)
✨ Finishing touches
🧪 Generate unit tests (beta)
Comment |
![augmentcode[bot]](https://avatars.githubusercontent.com/in/1027498?s=60&v=4){kind=small}
| // Dispose CodeReviewViewModel when leaving CODE_REVIEW tab | ||
| DisposableEffect(currentAgentType) { | ||
| onDispose { | ||
| if (currentAgentType != AgentType.CODE_REVIEW) { |
There was a problem hiding this comment.
DisposableEffect only disposes codeReviewViewModel when leaving CODE_REVIEW; if the composable is removed while still on CODE_REVIEW, the view model won't be disposed, risking a leak—consider always disposing here or registering with the IDE Disposer (Guideline: no_memory_leaks).
🤖 Was this useful? React with 👍 or 👎
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Actionable comments posted: 0
🧹 Nitpick comments (7)
mpp-idea/src/main/kotlin/cc/unitmesh/devins/idea/toolwindow/IdeaAgentApp.kt (1)
77-85: Simplify the DisposableEffect logic.The current implementation is correct but confusing. When the
DisposableEffectkey (currentAgentType) changes,onDisposeruns with the new value ofcurrentAgentType, making the condition check unnecessary. A cleaner pattern would be to unconditionally dispose inonDisposesince it only runs when leaving the current tab:// Dispose CodeReviewViewModel when leaving CODE_REVIEW tab DisposableEffect(currentAgentType) { onDispose { - if (currentAgentType != AgentType.CODE_REVIEW) { - codeReviewViewModel?.dispose() - codeReviewViewModel = null - } + codeReviewViewModel?.dispose() + codeReviewViewModel = null } }Alternatively, consider using
DisposableEffect(Unit)scoped to the composable's lifetime if the VM should persist across tab switches within the same session.mpp-idea/src/main/kotlin/cc/unitmesh/devins/idea/toolwindow/codereview/IdeaCodeReviewContent.kt (3)
129-133: Improve visual distinction for selected commit.The selected state uses
panelBackground.copy(alpha = 0.8f)while unselected usespanelBackgroundwithout alpha modification. This creates very subtle visual feedback. Consider using a more distinct selection indicator:val backgroundColor = if (isSelected) { - JewelTheme.globalColors.panelBackground.copy(alpha = 0.8f) + JewelTheme.globalColors.infoContent.copy(alpha = 0.2f) } else { JewelTheme.globalColors.panelBackground }Or add a left border/indicator for selected items to improve accessibility.
183-230: Consider horizontal scrolling for file tabs.When reviewing commits with many changed files, the file tabs may overflow the available width. Consider wrapping the
Rowin ahorizontalScrollmodifier:+ val scrollState = rememberScrollState() if (diffFiles.isNotEmpty()) { Row( - modifier = Modifier.fillMaxWidth().padding(8.dp), + modifier = Modifier + .fillMaxWidth() + .horizontalScroll(scrollState) + .padding(8.dp), horizontalArrangement = Arrangement.spacedBy(4.dp) ) {
290-295: Consider importing DiffLineType for cleaner code.The fully qualified reference
cc.unitmesh.agent.diff.DiffLineTypeis verbose. Consider adding an import:import cc.unitmesh.agent.diff.ChangeType import cc.unitmesh.agent.diff.DiffHunk +import cc.unitmesh.agent.diff.DiffLineTypeThen simplify the usage:
- cc.unitmesh.agent.diff.DiffLineType.ADDED -> AutoDevColors.Green.c400 - cc.unitmesh.agent.diff.DiffLineType.DELETED -> AutoDevColors.Red.c400 + DiffLineType.ADDED -> AutoDevColors.Green.c400 + DiffLineType.DELETED -> AutoDevColors.Red.c400mpp-idea/src/main/kotlin/cc/unitmesh/devins/idea/toolwindow/codereview/IdeaCodeReviewViewModel.kt (3)
37-38: Potential issue with empty projectPath.
GitOperationsis initialized unconditionally withprojectPath, which could be empty ifproject.basePathis null. Consider deferring initialization or handling the empty path case:private val projectPath: String = project.basePath ?: "" - private val gitOps = GitOperations(projectPath) + private val gitOps: GitOperations? = if (projectPath.isNotEmpty()) GitOperations(projectPath) else nullThen guard usages accordingly, or move initialization into the
elsebranch of the init block whereprojectPathis confirmed non-empty.
302-326: Consider invalidating cached agent on configuration changes.The
CodeReviewAgentis cached after first initialization. If users change model settings between analyses, the cached agent will use stale configuration. Consider either:
- Recreating the agent on each analysis (simpler, slight overhead)
- Adding a mechanism to detect config changes and invalidate the cache
- private suspend fun initializeCodeReviewAgent(): CodeReviewAgent { - if (codeReviewAgent != null && agentInitialized) { - return codeReviewAgent!! - } + private suspend fun initializeCodeReviewAgent(): CodeReviewAgent { + // Always create fresh agent to pick up any config changes + val toolConfig = ToolConfigFile.default()Or add a
resetAgent()method callable from settings UI.
341-343: Consider nullingcodeReviewAgentin dispose() for proper resource cleanup.While
CodeReviewAgentand its dependencies (KoogLLMService,McpToolConfigService) do not implementDisposableorCloseable, the currentdispose()method only cancelscurrentJob. SettingcodeReviewAgentto null would allow garbage collection of the agent and its dependencies when the ViewModel is disposed, which is good practice for cleanup:override fun dispose() { currentJob?.cancel() + codeReviewAgent = null + agentInitialized = false }
📜 Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro
📒 Files selected for processing (5)
mpp-idea/src/main/kotlin/cc/unitmesh/devins/idea/toolwindow/IdeaAgentApp.kt(5 hunks)mpp-idea/src/main/kotlin/cc/unitmesh/devins/idea/toolwindow/IdeaAgentToolWindowFactory.kt(1 hunks)mpp-idea/src/main/kotlin/cc/unitmesh/devins/idea/toolwindow/codereview/IdeaCodeReviewContent.kt(1 hunks)mpp-idea/src/main/kotlin/cc/unitmesh/devins/idea/toolwindow/codereview/IdeaCodeReviewModels.kt(1 hunks)mpp-idea/src/main/kotlin/cc/unitmesh/devins/idea/toolwindow/codereview/IdeaCodeReviewViewModel.kt(1 hunks)
🧰 Additional context used
📓 Path-based instructions (1)
**/*.kt
📄 CodeRabbit inference engine (AGENTS.md)
Use
expect/actualfor platform-specific code in KMP projects (e.g., file I/O on JVM/JS/Wasm)
Files:
mpp-idea/src/main/kotlin/cc/unitmesh/devins/idea/toolwindow/IdeaAgentApp.ktmpp-idea/src/main/kotlin/cc/unitmesh/devins/idea/toolwindow/codereview/IdeaCodeReviewModels.ktmpp-idea/src/main/kotlin/cc/unitmesh/devins/idea/toolwindow/IdeaAgentToolWindowFactory.ktmpp-idea/src/main/kotlin/cc/unitmesh/devins/idea/toolwindow/codereview/IdeaCodeReviewViewModel.ktmpp-idea/src/main/kotlin/cc/unitmesh/devins/idea/toolwindow/codereview/IdeaCodeReviewContent.kt
🧠 Learnings (1)
📚 Learning: 2025-11-30T02:30:49.805Z
Learnt from: CR
Repo: phodal/auto-dev-sketch PR: 0
File: AGENTS.md:0-0
Timestamp: 2025-11-30T02:30:49.805Z
Learning: Applies to **/src/{androidMain,desktopMain}/**/*.kt : For Compose (Desktop/Android), use `AutoDevColors` from `cc.unitmesh.devins.ui.compose.theme` or `MaterialTheme.colorScheme`
Applied to files:
mpp-idea/src/main/kotlin/cc/unitmesh/devins/idea/toolwindow/IdeaAgentApp.ktmpp-idea/src/main/kotlin/cc/unitmesh/devins/idea/toolwindow/codereview/IdeaCodeReviewContent.kt
🧬 Code graph analysis (2)
mpp-idea/src/main/kotlin/cc/unitmesh/devins/idea/toolwindow/IdeaAgentApp.kt (1)
mpp-idea/src/main/kotlin/cc/unitmesh/devins/idea/toolwindow/codereview/IdeaCodeReviewContent.kt (1)
IdeaCodeReviewContent(28-66)
mpp-idea/src/main/kotlin/cc/unitmesh/devins/idea/toolwindow/IdeaAgentToolWindowFactory.kt (1)
mpp-idea/src/main/kotlin/cc/unitmesh/devins/idea/toolwindow/IdeaAgentApp.kt (1)
IdeaAgentApp(43-144)
⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (2)
- GitHub Check: Build (223)
- GitHub Check: Build (241)
🔇 Additional comments (10)
mpp-idea/src/main/kotlin/cc/unitmesh/devins/idea/toolwindow/IdeaAgentToolWindowFactory.kt (1)
43-45: LGTM!The updated call site correctly passes
projectandcoroutineScopetoIdeaAgentApp, enabling the Code Review feature to access project context and manage coroutines properly. The lifecycle management viaDisposer.registerensures proper cleanup.mpp-idea/src/main/kotlin/cc/unitmesh/devins/idea/toolwindow/IdeaAgentApp.kt (2)
44-48: LGTM!The updated function signature correctly accepts
projectandcoroutineScopeparameters, enabling dependency injection for the Code Review feature.
116-120: LGTM!The conditional rendering correctly handles the brief async initialization period by showing a loading message until
codeReviewViewModelis available.mpp-idea/src/main/kotlin/cc/unitmesh/devins/idea/toolwindow/codereview/IdeaCodeReviewModels.kt (2)
10-23: LGTM!The data models are well-structured with sensible defaults. The separation of concerns between state (
IdeaCodeReviewState), commit metadata (IdeaCommitInfo), diff info (IdeaDiffFileInfo), and progress tracking (IdeaAIAnalysisProgress) is clean.
62-70: LGTM!The
IdeaAnalysisStageenum covers the complete lifecycle of AI analysis fromIDLEthrough various processing stages toCOMPLETEDorERROR.mpp-idea/src/main/kotlin/cc/unitmesh/devins/idea/toolwindow/codereview/IdeaCodeReviewContent.kt (2)
28-66: LGTM!The three-panel layout with fixed widths for commit list (280.dp) and AI analysis (350.dp), with the diff viewer taking remaining space via
weight(1f), provides a sensible default for code review workflows.
312-420: LGTM!The
AIAnalysisPanelis well-structured with clear state-driven button toggling, color-coded status indicators, proper error display, and a scrollable output area for analysis results.mpp-idea/src/main/kotlin/cc/unitmesh/devins/idea/toolwindow/codereview/IdeaCodeReviewViewModel.kt (3)
69-107: LGTM!The
loadCommitHistoryfunction properly manages loading state, handles errors, and provides good UX by auto-selecting the first commit and loading its diff.
139-141: LGTM!The index sorting correctly handles commit ordering (lower index = more recent commit in typical git log output). The empty tree hash
4b825dc642cb6eb9a060e54bf8d69288fbee4904on line 154 is a well-known git convention for diffing initial commits.
206-289: LGTM!The
startAnalysisfunction correctly:
- Cancels any previous analysis job before starting
- Properly propagates
CancellationExceptionfor structured concurrency- Streams progress updates incrementally via the callback
- Handles both agent-level and outer exceptions with appropriate error states
- Add JUnit 4 runtime dependency required by IntelliJ Platform test infrastructure - Temporarily disable IdeaAgentViewModelTest (requires full IntelliJ Platform setup) - Remove testFramework(TestFrameworkType.Platform) to avoid JUnit conflicts - JewelRendererTest now runs successfully with JUnit 5
There was a problem hiding this comment.
Actionable comments posted: 0
🧹 Nitpick comments (1)
mpp-idea/src/test/kotlin/cc/unitmesh/devins/idea/toolwindow/IdeaAgentViewModelTest.kt (1)
3-6: Consider alternative approaches to test disabling.While commenting out tests is pragmatic given the missing platform framework, consider these alternatives for better maintainability:
- Use Gradle source sets to separate platform tests from unit tests
- Use
@Disabledannotations when the platform framework is available- Add a Gradle task filter to conditionally exclude these tests
This would maintain test discoverability and provide clearer reporting of skipped tests.
📜 Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro
📒 Files selected for processing (2)
mpp-idea/build.gradle.kts(2 hunks)mpp-idea/src/test/kotlin/cc/unitmesh/devins/idea/toolwindow/IdeaAgentViewModelTest.kt(2 hunks)
🧰 Additional context used
📓 Path-based instructions (1)
**/*.kt
📄 CodeRabbit inference engine (AGENTS.md)
Use
expect/actualfor platform-specific code in KMP projects (e.g., file I/O on JVM/JS/Wasm)
Files:
mpp-idea/src/test/kotlin/cc/unitmesh/devins/idea/toolwindow/IdeaAgentViewModelTest.kt
🧠 Learnings (3)
📚 Learning: 2025-11-30T02:30:49.805Z
Learnt from: CR
Repo: phodal/auto-dev-sketch PR: 0
File: AGENTS.md:0-0
Timestamp: 2025-11-30T02:30:49.805Z
Learning: Use `cd mpp-idea && ../gradlew test --tests "cc.unitmesh.devins.idea.renderer.JewelRendererTest"` for running standalone JUnit 5 tests that do not require IntelliJ Platform
Applied to files:
mpp-idea/build.gradle.ktsmpp-idea/src/test/kotlin/cc/unitmesh/devins/idea/toolwindow/IdeaAgentViewModelTest.kt
📚 Learning: 2025-11-30T02:30:49.805Z
Learnt from: CR
Repo: phodal/auto-dev-sketch PR: 0
File: AGENTS.md:0-0
Timestamp: 2025-11-30T02:30:49.805Z
Learning: For IntelliJ IDEA Plugin build, use `cd mpp-idea && ../gradlew compileKotlin` instead of `./gradlew :mpp-idea:compileKotlin` from root
Applied to files:
mpp-idea/build.gradle.kts
📚 Learning: 2025-11-30T02:30:49.805Z
Learnt from: CR
Repo: phodal/auto-dev-sketch PR: 0
File: AGENTS.md:0-0
Timestamp: 2025-11-30T02:30:49.805Z
Learning: Applies to {mpp-core,mpp-ui}/**/*.kt : Check export first in mpp-core and mpp-ui; if some functions are not working well with CLI (TypeScript), verify JsExport usage
Applied to files:
mpp-idea/build.gradle.kts
🔇 Additional comments (3)
mpp-idea/src/test/kotlin/cc/unitmesh/devins/idea/toolwindow/IdeaAgentViewModelTest.kt (1)
7-169: Test preservation approach is pragmatic.The decision to comment out the entire test class aligns with the removal of
testFramework(TestFrameworkType.Platform)in build.gradle.kts. The tests are preserved for future re-enabling, and the header provides clear instructions for running them.mpp-idea/build.gradle.kts (2)
136-141: Clear explanation for removing platform test framework.The comments provide excellent context for why
testFramework(TestFrameworkType.Platform)is removed and how to re-enable it when needed. This aligns well with the disabled tests in IdeaAgentViewModelTest.kt.
115-118: Test dependencies are correctly configured and well-documented.The JUnit 5 (Jupiter) dependencies follow Maven Central standards: API on test implementation, engine on test runtime. Including JUnit 4 on the runtime classpath for IntelliJ Platform test infrastructure (JUnit5TestEnvironmentInitializer) is correct and properly justified in the comment.
testImplementation("org.junit.jupiter:junit-jupiter-api:5.11.4") testRuntimeOnly("org.junit.jupiter:junit-jupiter-engine:5.11.4") // JUnit 4 is required by IntelliJ Platform test infrastructure (JUnit5TestEnvironmentInitializer) testRuntimeOnly("junit:junit:4.13.2")The test class
cc.unitmesh.devins.idea.renderer.JewelRendererTestexists atmpp-idea/src/test/kotlin/cc/unitmesh/devins/idea/renderer/JewelRendererTest.kt, so the verification command is valid.
1 participant
Summary
Implement Code Review functionality in mpp-idea module, porting the CodeReviewAgent logic and UI from mpp-core/mpp-ui.
Changes
New Files
IdeaCodeReviewModels.kt- Data modelsIdeaCodeReviewState- UI stateIdeaCommitInfo- Git commit informationIdeaDiffFileInfo- File diff informationIdeaAIAnalysisProgress- AI analysis progressIdeaAnalysisStage- Analysis stage enumIdeaCodeReviewViewModel.kt- ViewModelGitOperations(JVM) for git commandsCodeReviewAgentfor AI analysisIdeaCodeReviewContent.kt- UI Components (Jewel)CommitListPanel- Left panel with commit historyDiffViewerPanel- Center panel with diff displayAIAnalysisPanel- Right panel with AI analysis controls and outputModified Files
IdeaAgentApp.kt- Integrate Code Review tabIdeaAgentToolWindowFactory.kt- Pass project and coroutineScopeBuild Status
./gradlew compileKotlin)Pull Request opened by Augment Code with guidance from the PR author
Summary by CodeRabbit
New Features
Chores
✏️ Tip: You can customize this high-level summary in your review settings.