Skip to content

feat(mpp-idea): implement Code Review functionality #6

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
phodal merged 2 commits into from
Nov 30, 2025
Merged

feat(mpp-idea): implement Code Review functionality #6

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
e2b9ee5
feat(mpp-idea): implement Code Review functionality
phodal Nov 30, 2025
421bb92
fix(mpp-idea): fix test configuration for JUnit 5 with IntelliJ Platform
phodal Nov 30, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 10 additions & 1 deletion mpp-idea/build.gradle.kts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -112,6 +112,10 @@ dependencies {
compileOnly("io.ktor:ktor-client-logging:3.2.2")

testImplementation(kotlin("test"))
testImplementation("org.junit.jupiter:junit-jupiter-api:5.11.4")
testRuntimeOnly("org.junit.jupiter:junit-jupiter-engine:5.11.4")
// JUnit 4 is required by IntelliJ Platform test infrastructure (JUnit5TestEnvironmentInitializer)
testRuntimeOnly("junit:junit:4.13.2")

intellijPlatform {
// Target IntelliJ IDEA 2025.2+ for Compose support
Expand All @@ -129,7 +133,12 @@ dependencies {
"intellij.platform.compose"
)

testFramework(TestFrameworkType.Platform)
// Note: testFramework(TestFrameworkType.Platform) is removed because:
// 1. It requires JUnit 4 (junit.framework.TestCase) which conflicts with JUnit 5
// 2. JewelRendererTest uses JUnit 5 and doesn't need IntelliJ Platform
// 3. IdeaAgentViewModelTest (which needs Platform) is temporarily disabled
// To run platform tests, uncomment testFramework and add JUnit 4 dependency
// testFramework(TestFrameworkType.Platform)
}
}

Expand Down
39 changes: 32 additions & 7 deletions mpp-idea/src/main/kotlin/cc/unitmesh/devins/idea/toolwindow/IdeaAgentApp.kt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -17,7 +17,11 @@ import androidx.compose.ui.unit.dp
import androidx.compose.ui.unit.sp
import cc.unitmesh.agent.AgentType
import cc.unitmesh.devins.idea.renderer.JewelRenderer
import cc.unitmesh.devins.idea.toolwindow.codereview.IdeaCodeReviewContent
import cc.unitmesh.devins.idea.toolwindow.codereview.IdeaCodeReviewViewModel
import cc.unitmesh.devins.ui.compose.theme.AutoDevColors
import com.intellij.openapi.project.Project
import kotlinx.coroutines.CoroutineScope
import kotlinx.coroutines.flow.distinctUntilChanged
import org.jetbrains.jewel.foundation.theme.JewelTheme
import org.jetbrains.jewel.ui.Orientation
Expand All @@ -37,7 +41,11 @@ import org.jetbrains.jewel.ui.theme.defaultBannerStyle
* Aligned with AgentChatInterface from mpp-ui for feature parity.
*/
@Composable
fun IdeaAgentApp(viewModel: IdeaAgentViewModel) {
fun IdeaAgentApp(
viewModel: IdeaAgentViewModel,
project: Project,
coroutineScope: CoroutineScope
) {
val currentAgentType by viewModel.currentAgentType.collectAsState()
val timeline by viewModel.renderer.timeline.collectAsState()
val streamingOutput by viewModel.renderer.currentStreamingOutput.collectAsState()
Expand All @@ -46,6 +54,9 @@ fun IdeaAgentApp(viewModel: IdeaAgentViewModel) {
val mcpPreloadingMessage by viewModel.mcpPreloadingMessage.collectAsState()
val listState = rememberLazyListState()

// Code Review ViewModel (created lazily when needed)
var codeReviewViewModel by remember { mutableStateOf<IdeaCodeReviewViewModel?>(null) }

// Auto-scroll to bottom when new items arrive
LaunchedEffect(timeline.size, streamingOutput) {
if (timeline.isNotEmpty() || streamingOutput.isNotEmpty()) {
Expand All @@ -56,6 +67,23 @@ fun IdeaAgentApp(viewModel: IdeaAgentViewModel) {
}
}

// Create CodeReviewViewModel when switching to CODE_REVIEW tab
LaunchedEffect(currentAgentType) {
if (currentAgentType == AgentType.CODE_REVIEW && codeReviewViewModel == null) {
codeReviewViewModel = IdeaCodeReviewViewModel(project, coroutineScope)
}
}

// Dispose CodeReviewViewModel when leaving CODE_REVIEW tab
DisposableEffect(currentAgentType) {
onDispose {
if (currentAgentType != AgentType.CODE_REVIEW) {
Copy link

@augmentcode augmentcode bot Nov 30, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

DisposableEffect only disposes codeReviewViewModel when leaving CODE_REVIEW; if the composable is removed while still on CODE_REVIEW, the view model won't be disposed, risking a leak—consider always disposing here or registering with the IDE Disposer (Guideline: no_memory_leaks).

🤖 Was this useful? React with 👍 or 👎

codeReviewViewModel?.dispose()
codeReviewViewModel = null
}
}
}

Column(
modifier = Modifier
.fillMaxSize()
Expand Down Expand Up @@ -86,7 +114,9 @@ fun IdeaAgentApp(viewModel: IdeaAgentViewModel) {
)
}
AgentType.CODE_REVIEW -> {
CodeReviewContent()
codeReviewViewModel?.let { vm ->
IdeaCodeReviewContent(viewModel = vm)
} ?: EmptyStateMessage("Loading Code Review...")
}
AgentType.KNOWLEDGE -> {
KnowledgeContent()
Expand Down Expand Up @@ -166,11 +196,6 @@ private fun TimelineItemView(item: JewelRenderer.TimelineItem) {
}
}

@Composable
private fun CodeReviewContent() {
EmptyStateMessage("Code Review mode - Coming soon!")
}

@Composable
private fun KnowledgeContent() {
EmptyStateMessage("Knowledge mode - Coming soon!")
Expand Down
2 changes: 1 addition & 1 deletion mpp-idea/src/main/kotlin/cc/unitmesh/devins/idea/toolwindow/IdeaAgentToolWindowFactory.kt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -41,7 +41,7 @@ class IdeaAgentToolWindowFactory : ToolWindowFactory {
Disposer.register(toolWindow.disposable, viewModel)

toolWindow.addComposeTab("Agent") {
IdeaAgentApp(viewModel)
IdeaAgentApp(viewModel, project, coroutineScope)
}
}
}
Expand Down
Loading
Loading