Addresses #125 by adding some missing members of 115th Congress #132

rthbound · 2017-02-06T00:17:00Z

A group on ProgCode is using this repo

We wanted to help get it up to date
Many thanks to @woobietuesday, @DesmondJones for helping to gather images
We worked from this list https://gist.github.com/rthbound/9abeca9b0c4890d58f66d29b3e75bafe
Hope this helps!
Adds originals.
Switch to images for which attributions can be found for some being added.
Metadata for new additions
Converts updated originals, c/o @hiemanshu
also adds imagemagick script used in converting originals
to the prescribed .jpg format

Addreses #125.

konklone · 2017-02-06T00:26:09Z

This is very impressive work. I especially appreciate the addition of metadata documenting the source of each image -- that's crucial, if we're not getting them from GPO.

I do have some concerns about copyright for some of these, unfortunately. Photos from house.gov and senate.gov sites should be fine. But the photos from campaign websites have no guarantees around being public domain, and are likely to be copyrighted by the photographer.

The metadata for photos from Wikipedia/Wikimedia is a mixed bag. They're cited in a few different ways -- by the Wikipedia article, by the Wikimedia Commons URL, or the Wikipedia file URL. In each of these cases, Wikipedia is getting them from an underlying source, and our metadata should link to the underlying source instead.

For example, https://commons.wikimedia.org/wiki/File:Scott_Taylor_(politician).jpg is from a Facebook album from a House committee, so that would be the appropriate link. (And I would also feel comfortable with the public domain status of that photo.) However, it's impossible to tell from the Wikipedia links where these come from.

We do want public domain here, because we want even commercial uses of this data to be unencumbered, and for there just to be as few questions as possible.

So, while respecting all the work that has gone into this, I would like to see the PR drop photos from campaign sources, and to replace the Wikipedia links with the underlying source that Wikipedia drew it from.

rthbound · 2017-02-06T00:40:40Z

@konklone thank you for the detailed feedback. We will refine our PR as described:

Remove those images sourced from campaign sites. We'll also try and replace those, if possible, with images from more appropriate sources.
Clarify the sources for the images found on Wikipedia or on Wikimedia.

Will get back to you soon.

konklone · 2017-02-06T02:39:22Z

Unfortunately, I have to recommend removing the Ballotpedia one, since they took it from his campaign.

Inspired by your links from dems.gov, I did also take a look at https://www.gop.gov/about/members/, but Mike Gallagher's not there either. I think he might just have to stand empty unless an official photo of him can be found from another source.

rthbound · 2017-02-06T02:41:42Z

That's Gallagher, gone. Mike Johnson is also sourced from Ballotpedia. J000299

konklone · 2017-02-06T02:43:43Z

congress/metadata/G000580.yaml

@@ -0,0 +1,2 @@
+name: Ballotpedia
+link: https://ballotpedia.org/Vicente_Gonz%C3%A1lez


Confirmed through reverse image search, also from Gonzales' campaign.

konklone · 2017-02-06T02:44:14Z

congress/metadata/J000299.yaml

@@ -0,0 +1,2 @@
+name: Ballotpedia
+link: https://ballotpedia.org/Mike_Johnson_(Louisiana)


Confirmed through reverse-image-search, also from the campaign. :/

konklone · 2017-02-06T02:45:32Z

congress/metadata/G000581.yaml

@@ -0,0 +1,2 @@
+name: Facebook
+link: https://www.facebook.com/votevicente/


I'm not sure why this is two separate bioguide IDs -- the images for G000580 and G000581 are both for Vicente Gonzalez. Also, this one is from a campaign Facebook page.

https://www.facebook.com/votevicente/

G000580 should have been a Thomas Garret, I think.

konklone · 2017-02-06T02:46:59Z

congress/metadata/G000583.yaml

@@ -0,0 +1,2 @@
+name: Twitter
+link: https://pbs.twimg.com/profile_images/735547603912433664/TIW7-Jzs.jpg


This image appears to be from the member's campaign. Two candidate replacements:

Header from official page: https://gottheimer.house.gov/images/jg-headshot.png

Avatar from https://twitter.com/RepJoshG

konklone · 2017-02-06T02:47:17Z

congress/metadata/H001077.yaml

@@ -0,0 +1,2 @@
+name: Facebook
+link: https://www.facebook.com/captclayhiggins/


This Facebook page is the member's campaign account.

konklone · 2017-02-06T02:48:35Z

congress/metadata/K000390.yaml

@@ -0,0 +1,2 @@
+name: Votesmart
+link: http://votesmartnv.org/us-congress/ruben-kihuen/


This is from the campaign. Candidates for replacement:

Home page header: https://kihuen.house.gov/images/headshot-web.png

Twitter avatar: https://twitter.com/RepKihuen

konklone · 2017-02-06T02:49:19Z

congress/metadata/L000587.yaml

@@ -0,0 +1,2 @@
+name: Genesis Communications Network
+link: https://commons.wikimedia.org/w/index.php?title=User:Genesis_Communications_Network&action=edit&redlink=1


This is to an edit link for a user page.

konklone · 2017-02-06T02:50:40Z

congress/metadata/L000586.yaml

@@ -0,0 +1,2 @@
+name: Al Lawson Campaign - Own work
+link: https://upload.wikimedia.org/wikipedia/commons/e/e2/Al_Lawson.jpg


The page with details is https://en.wikipedia.org/wiki/File:Al_Lawson.jpg, and it says the campaign donated it with a CC-BY-SA 4.0 license. That's better than usual, but we still need to look for a public domain image and not pass attribution requirements on down to downstream users.

rthbound · 2017-02-06T02:58:00Z

Triaging remaining comments here:

K000390 see comments
G000583 see comments
Check on G000580, which should have been a Thomas Garret
Check on L000587 attribution.

rthbound · 2017-02-06T03:25:19Z

konklone · 2017-02-06T05:16:52Z

congress/metadata/B001299.yaml

@@ -0,0 +1,2 @@
+name: Gage Skidmore
+link: https://commons.wikimedia.org/wiki/File:Jim_Banks_by_Gage_Skidmore.jpg


This has a CC-BY-SA 3.0 license attached, and needs to be replaced with a public domain version.

rthbound · 2017-02-06T06:14:45Z

@konklone once this is suitable, I can squash so @unitedstates doesn't have to keep the git history for all the images we've rejected.

hugovk · 2017-02-06T06:45:17Z

convert_to_jpg.sh

+        convert $file $filename.jpg # Convert to a jpg
+        rm $file
+    fi
+done


If you'd like to keep this script in the repo, please move it to the scripts/ directory. Thank you.

konklone · 2017-02-07T03:10:56Z

congress/metadata/C001111.yaml

@@ -0,0 +1,2 @@
+name: LWVSPA
+link: https://lwvspa.org/congressional-representatives-pinellas-county/


I can't figure out where Crist's image ultimately comes from here, so it's not safe to assume it's free of copyright. Options:

http://crist.house.gov/images/crist-head.jpg

https://twitter.com/repcharliecrist avatar (seems like the same)

(BTW, sorry for the delays here -- I'm doing this in my spare time at the end of evenings.)

konklone · 2017-02-07T03:12:59Z

congress/metadata/G000578.yaml

@@ -0,0 +1,2 @@
+name: Florida House of Representatives
+link: http://www.myfloridahouse.gov/Sections/Representatives/representatives.aspx?SortField=district&SortDirection=asc&SessionId=73


Ugh, sorry for this, I know this is a .gov, but state governments don't have the same guarantee of public domain as the federal government. I can't find a quick replacement for this one except for the (bad) avatar at https://twitter.com/Rep_Matt_Gaetz.

konklone · 2017-02-07T03:13:36Z

congress/metadata/L000587.yaml

@@ -0,0 +1,2 @@
+name: Genesis Communications Network
+link: https://commons.wikimedia.org/wiki/File:Jason_Lewis.png


This is licensed under CC-BY-SA 3.0, not public domain.

konklone · 2017-02-07T03:14:11Z

congress/metadata/M001200.yaml

@@ -0,0 +1,2 @@
+name: JCWilmore - Own work
+link: https://commons.wikimedia.org/wiki/User:JCWilmore


This link doesn't contain the image in question. I would recommend looking for an official .gov source instead of Wikipedia anyway.

konklone · 2017-02-07T03:16:34Z

OK, I've completed my review, and the rest of the URLs look like they are from official government sources.

In the future, it would be better to do a review like this ahead of time (this was fairly intensive). I'm going to add an issue and PR template to make it more clear that the images must be public domain, to hopefully avoid this going forward.

konklone · 2017-02-07T03:16:52Z

@hugovk You're the better maintainer to review this and merge.

konklone · 2017-02-07T03:17:08Z

@konklone once this is suitable, I can squash so @unitedstates doesn't have to keep the git history for all the images we've rejected.

And yeah, that would be great.

rthbound · 2017-02-07T04:08:51Z

Use public domain image for Charlie Crist C001111 (see comments)
Use public domain image for Matt Gaetz G000578 (see comments)
Omit A. McEachin M001200 (see comments)
Omit L000587 (see comments)
Squash commits for this pull

rthbound · 2017-02-07T04:26:30Z

@konklone, thank you for the additional work in preparing this PR. I've squashed our work so @unitedstates will not need to retain the rejected images in its git history. I've preserved that git history in a branch in case anyone wants or needs any of it later.

Further feedback is welcomed, I'm happy to continue amending these changes until they are satisfactory. Thanks.

@DesmondJones

- We wanted to help get it up to date - Many thanks to @woobietuesday, @DesmondJones for helping to gather images - We worked from this list https://gist.github.com/rthbound/9abeca9b0c4890d58f66d29b3e75bafe - Hope this helps! Adds originals. These need to be converted to .jpg of same name (for those that are jpeg or png) Switch to images for which attributions can be found for some being added Metadata for new additions Converts updated originals, c/o @hiemanshu - also adds imagemagick script used in converting originals to the prescribed <BIOGUIDE>.jpg format Refine Wikipedia/Wikimedia attributions Improve source for R000606 Improve source for B001303 Improve source for B001300 Improve source for K000389 Improve source for B001301 Improve source for C001110 Improve source for G000579 Delete images for T000478 until public domain images can be found. Improve source for J000298 Delete images for R000606 until public domain images can be found. Delete images for J000298 until public domain images can be found. Removes Ballotpedia sourced image taken from campaign photos Delete images for G000580 until public domain images can be found. Delete images for J000299 until public domain images can be found. Delete images for H001077 until public domain images can be found. Delete images for G000581 until public domain images can be found. Delete images for L000586 until public domain images can be found. Improve L000587 attribution Adds G000580 Changes K000390, using twitter avatar as source Changes G000583, previous choice was from a campaign photo Use house.gov source for B001299 Reloceate @hiemanshu's (png|jpeg) -> jpg script to ./scripts/ Use public domain image for C001111 Use public domain image for G000578 Omit M001200 until a public domain image can be found Remove L000587 until a public domain replacement can be found

hugovk · 2017-02-07T19:13:06Z

@konklone Looks ok to me, feel free to merge after making any final checks.

hugovk · 2017-02-08T06:51:52Z

Thank you @rthbound, @woobietuesday, @DesmondJones, @hiemanshu, @ProgressiveCoders and @konklone!

konklone mentioned this pull request Feb 6, 2017

The 115th Congress unitedstates/congress-legislators#375

Closed

16 tasks

konklone reviewed Feb 6, 2017

View reviewed changes

hugovk reviewed Feb 6, 2017

View reviewed changes

konklone reviewed Feb 7, 2017

View reviewed changes

rthbound force-pushed the prog-code-patch-1 branch from e4207cf to 039d6b0 Compare February 7, 2017 04:22

rthbound force-pushed the prog-code-patch-1 branch from 039d6b0 to d93b20c Compare February 7, 2017 04:33

hugovk mentioned this pull request Feb 7, 2017

Create a pull request template that emphasizes the need for public domain images #133

Merged

rthbound changed the title ~~Fixes #125 by adding missing members of 115th Congress~~ Addresses #125 by adding some missing members of 115th Congress Feb 7, 2017

rthbound mentioned this pull request Feb 7, 2017

Missing members of the 115th Congress #125

Open

konklone merged commit a5a44bd into unitedstates:gh-pages Feb 8, 2017

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Addresses #125 by adding some missing members of 115th Congress #132

Addresses #125 by adding some missing members of 115th Congress #132

rthbound commented Feb 6, 2017 •

edited

Loading

konklone commented Feb 6, 2017

rthbound commented Feb 6, 2017 •

edited

Loading

konklone commented Feb 6, 2017

rthbound commented Feb 6, 2017 •

edited

Loading

konklone Feb 6, 2017

konklone Feb 6, 2017

konklone Feb 6, 2017

rthbound Feb 6, 2017

konklone Feb 6, 2017

konklone Feb 6, 2017

konklone Feb 6, 2017

konklone Feb 6, 2017

konklone Feb 6, 2017

rthbound commented Feb 6, 2017 •

edited

Loading

rthbound commented Feb 6, 2017 •

edited

Loading

konklone Feb 6, 2017

rthbound commented Feb 6, 2017

hugovk Feb 6, 2017

konklone Feb 7, 2017

konklone Feb 7, 2017

konklone Feb 7, 2017

konklone Feb 7, 2017

konklone Feb 7, 2017

konklone commented Feb 7, 2017

konklone commented Feb 7, 2017

konklone commented Feb 7, 2017

rthbound commented Feb 7, 2017 •

edited

Loading

rthbound commented Feb 7, 2017 •

edited

Loading

hugovk commented Feb 7, 2017 •

edited

Loading

hugovk commented Feb 8, 2017

		@@ -0,0 +1,2 @@
		name: Ballotpedia
		link: https://ballotpedia.org/Vicente_Gonz%C3%A1lez

		@@ -0,0 +1,2 @@
		name: Ballotpedia
		link: https://ballotpedia.org/Mike_Johnson_(Louisiana)

		@@ -0,0 +1,2 @@
		name: Facebook
		link: https://www.facebook.com/votevicente/

		@@ -0,0 +1,2 @@
		name: Twitter
		link: https://pbs.twimg.com/profile_images/735547603912433664/TIW7-Jzs.jpg

		@@ -0,0 +1,2 @@
		name: Facebook
		link: https://www.facebook.com/captclayhiggins/

		@@ -0,0 +1,2 @@
		name: Votesmart
		link: http://votesmartnv.org/us-congress/ruben-kihuen/

		@@ -0,0 +1,2 @@
		name: Genesis Communications Network
		link: https://commons.wikimedia.org/w/index.php?title=User:Genesis_Communications_Network&action=edit&redlink=1

		@@ -0,0 +1,2 @@
		name: Al Lawson Campaign - Own work
		link: https://upload.wikimedia.org/wikipedia/commons/e/e2/Al_Lawson.jpg

		@@ -0,0 +1,2 @@
		name: Gage Skidmore
		link: https://commons.wikimedia.org/wiki/File:Jim_Banks_by_Gage_Skidmore.jpg

		@@ -0,0 +1,2 @@
		name: LWVSPA
		link: https://lwvspa.org/congressional-representatives-pinellas-county/

		@@ -0,0 +1,2 @@
		name: Florida House of Representatives
		link: http://www.myfloridahouse.gov/Sections/Representatives/representatives.aspx?SortField=district&SortDirection=asc&SessionId=73

		@@ -0,0 +1,2 @@
		name: JCWilmore - Own work
		link: https://commons.wikimedia.org/wiki/User:JCWilmore

Addresses #125 by adding some missing members of 115th Congress #132

Addresses #125 by adding some missing members of 115th Congress #132

Conversation

rthbound commented Feb 6, 2017 • edited Loading

konklone commented Feb 6, 2017

rthbound commented Feb 6, 2017 • edited Loading

konklone commented Feb 6, 2017

rthbound commented Feb 6, 2017 • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

rthbound commented Feb 6, 2017 • edited Loading

rthbound commented Feb 6, 2017 • edited Loading

Choose a reason for hiding this comment

rthbound commented Feb 6, 2017

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

konklone commented Feb 7, 2017

konklone commented Feb 7, 2017

konklone commented Feb 7, 2017

rthbound commented Feb 7, 2017 • edited Loading

rthbound commented Feb 7, 2017 • edited Loading

hugovk commented Feb 7, 2017 • edited Loading

hugovk commented Feb 8, 2017

rthbound commented Feb 6, 2017 •

edited

Loading

rthbound commented Feb 6, 2017 •

edited

Loading

rthbound commented Feb 6, 2017 •

edited

Loading

rthbound commented Feb 6, 2017 •

edited

Loading

rthbound commented Feb 6, 2017 •

edited

Loading

rthbound commented Feb 7, 2017 •

edited

Loading

rthbound commented Feb 7, 2017 •

edited

Loading

hugovk commented Feb 7, 2017 •

edited

Loading