-
Notifications
You must be signed in to change notification settings - Fork 53
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Missing members of the 115th Congress #125
Comments
Thanks, I'll add these. Running
http://memberguide.gpo.gov doesn't yet have the 115th congress, so we'll have to wait or do them manually. |
yes, there are a bunch. But only four senators so i figured they'd be easy to tackle. Masto doesn't have any CC0 photos I could find though. GPO will probably be up soon enough! |
How's this? #127 |
Add H001075, H001076, K000393 via #125
As @hugovk noted, there are quite a few legislators with missing photos at the moment. Is there any expectation of when those photos will be scrapeable via the memberguide? I'm trying to gauge the value of contributing other (fill-in) photos in the meantime. Ie, if those photos are typically available soon, it may be best to just wait for them. If not, providing fill-in photos would be more valuable. |
In January 2015, @handlers called the GPO about the 114th, and they estimated it'd be ready in June: #22 (comment) I'm not sure when they were added, but they were there by October 2015 (#114), and they'd mostly been manually added in the summer. It may be worth calling them again to get a new estimate. Last time round, @nickom did a sterling job in filling in missing images, and then finding better quality images of existing ones. If someone's up for hunting out new ones, it may be worth browsing his closed issues for tips and sources: See also: https://github.com/unitedstates/images#contributing-other-photos (we could update this with some tips) And a note on metadata: #39 (comment) |
Just ran a script to report on missing images... sharing results: https://gist.github.com/rthbound/9abeca9b0c4890d58f66d29b3e75bafe (current as of sometime around this comment's timestamp) |
@amp343 @hugovk We have images for the meantime here: gh-pages...rthbound:prog-code-patch-1 The So far we've produced The most recent commit explains what's most likely next if we want this merged:
It's been a long few hours of work preparing these, so I'm headed to bed. Will look at converting/renaming the last few originals tomorrow. |
Thank you for preparing all those! Regarding: Are they all official/public domain images? Where did each one come from? They'll also need metadata files, see #39 (comment) Thanks again! |
@hugovk that's what i get for not reading. I expected we'd want public domain images, so these were the instructions we followed while gathering:
I'll have to check on the metadata... and do you need the source urls? EDIT I see the details, thank you for the links and feedback. |
Ok. Given the instructions, and given that a lawyer and a paralegal helped to carry them out, I expect these are about 99% public domain. I do know that Brian Mast's image came from his facebook somewhere. We'll take some time to find the attributions before we issue a PR. I am assuming that the originals do also need to use the |
Yes please, let's have them all .jpg, because this says:
|
If #132 is merged, the following additions to 115th Congress will be outstanding (still missing):
From #132 (comment) |
Addresses #125 by adding some missing members of 115th Congress
PR #132 is merged, confirmation of the missing:
https://travis-ci.org/unitedstates/images/jobs/199439242#L362 |
Opened a new issue #138 for missing photos but didn't realize I should probably be referencing this ticket instead. Running
Since then I've submitted three PRs #141 #140 and #139 . After those changes the output of
If I submit any further changes I'll reference this ticket instead of #138 |
Claudia Tenney - T000478 Donald McEachin - M001200 Clay Higgins - H001077 |
Adding the changes in PRs #139 #140 #141 #142 brings the output of
|
Al Lawson's official 115th Congressional portrait is available here: Al Lawson, Jr. (D-FL)Bioguide ID: L000586 |
Awesome, just submitted a PR for that image. Down to 4 missing:
|
Thanks to @msimonborg for adding two more in #147. Now just two remaining:
|
Currently missing:
|
Currently missing those from previous comment plus:
|
New Senator Photos Missing
When checking for photos of the 115th Congress, four or the seven freshman members of Senate do not yet have photos. This is probably because the GPO hasn't posted the 115th member list and they never served in the House. Here are photos that can be used as placeholders until they become available on GPO:
Kamala D. Harris (D-CA)
John Kennedy (R-LA)
Margaret Wood Hassan (D-NH)
Catherine Cortez Masto (D-NV)
I was unable to find a suitable public domain photo of Senator Masto.
The text was updated successfully, but these errors were encountered: