Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update S001202 via #138 #139

Merged
merged 2 commits into from
Mar 31, 2017
Merged

Update S001202 via #138 #139

merged 2 commits into from
Mar 31, 2017

Conversation

@coveralls
Copy link

coveralls commented Mar 29, 2017

Coverage Status

Coverage remained the same at 59.813% when pulling a7a5ccb on phoneyourrep:patch into a5a44bd on unitedstates:gh-pages.

3 similar comments
@coveralls
Copy link

Coverage Status

Coverage remained the same at 59.813% when pulling a7a5ccb on phoneyourrep:patch into a5a44bd on unitedstates:gh-pages.

@coveralls
Copy link

Coverage Status

Coverage remained the same at 59.813% when pulling a7a5ccb on phoneyourrep:patch into a5a44bd on unitedstates:gh-pages.

@coveralls
Copy link

Coverage Status

Coverage remained the same at 59.813% when pulling a7a5ccb on phoneyourrep:patch into a5a44bd on unitedstates:gh-pages.

@coveralls
Copy link

coveralls commented Mar 29, 2017

Coverage Status

Coverage remained the same at 59.813% when pulling a7a5ccb on phoneyourrep:patch into a5a44bd on unitedstates:gh-pages.

@hugovk hugovk merged commit 5282493 into unitedstates:gh-pages Mar 31, 2017
@msimonborg msimonborg deleted the patch branch March 31, 2017 07:15
@hugovk
Copy link
Member

hugovk commented Mar 31, 2017

@msimonborg Thanks for these!

I just thought, the link: in the metadata would probably be better as the Commons webpage rather than the image itself.

e.g. https://commons.wikimedia.org/wiki/File:Luther_Strange_official_portrait.jpg rather than https://upload.wikimedia.org/wikipedia/commons/5/52/Luther_Strange_official_portrait.jpg

Please could you update these?

Thanks again!

(I've also turned that annoying @coveralls comment spam off.)

@msimonborg
Copy link
Contributor Author

@hugovk No problem! I'm happy to submit a PR to update those metadata files, but I should note that the default behavior of the scripts/update_image.sh file is to use the image source URL in the link: field, in case you'd want to consider changing that. It might require adding another URL variable to the shell script, since the img source URL and the context URL could be totally unrelated.

hugovk added a commit that referenced this pull request Apr 1, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants