-
Notifications
You must be signed in to change notification settings - Fork 630
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
SystemVerilog: improve compiler directive support #2675
Conversation
Codecov Report
@@ Coverage Diff @@
## master #2675 +/- ##
=======================================
Coverage 86.93% 86.93%
=======================================
Files 183 183
Lines 39079 39080 +1
=======================================
+ Hits 33972 33974 +2
+ Misses 5107 5106 -1
Continue to review full report at Codecov.
|
All standard compiler directives are supported. Only `define directive emits a tag. All other directives skip the whole line included. The newline character preceded by a backslash is ignored to support a multi-line macro definition.
I checked uncovered lines (L704-709). I tried to add testcases for this block in this pull-request, but I found that I've added a test-case which covers the lines. |
I think it is nice to have a case for testing a multiline macro. By the way, I recommend you to explore how our C parser support macros.
In the latter invocation, main is captured as a function:-)
|
Me, too. I've added it.
Thanks. I've merged this request.
No, I don't. If we need to expand macros, I prefer to use external preprocessor and use
Good suggestion. I will add them on the TODO list. |
All standard compiler directives are supported.
Only `define directive emits a tag. All other directives skip the whole line included.
The newline character preceded by a backslash is ignored to support a multi-line macro definition.
new tests are added.