Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SystemVerilog: port list fix and others #2753

Merged
merged 8 commits into from
Dec 7, 2020

Conversation

hirooih
Copy link
Contributor

@hirooih hirooih commented Dec 6, 2020

  • fix module port tagging bugs
    • net type and user-defined type ports are tagged as port.
    • correctly distinguishes between ANSI port and non-ANSI port.
    • merge with processPortList()
  • define swapToken() for K_WITH handling (proposed by @masatake san)
  • fixes for uncovered lines

All high-priority items are implemented by this pull-request.

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature. The key has expired.
- net type and user-defined type ports are tagged as port.
- correctly distinguishes between ANSI port and non-ANSI port.
- update extected.tags and add tests
@coveralls
Copy link

coveralls commented Dec 6, 2020

Coverage Status

Coverage increased (+0.03%) to 87.165% when pulling 1f209b7 on hirooih:sv-port-list into 69df9dc on universal-ctags:master.

@codecov
Copy link

codecov bot commented Dec 6, 2020

Codecov Report

Merging #2753 (1f209b7) into master (bdb7d99) will increase coverage by 0.08%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #2753      +/-   ##
==========================================
+ Coverage   86.99%   87.08%   +0.08%     
==========================================
  Files         190      191       +1     
  Lines       40496    40784     +288     
==========================================
+ Hits        35230    35517     +287     
- Misses       5266     5267       +1     
Impacted Files Coverage Δ
parsers/verilog.c 98.24% <100.00%> (+1.27%) ⬆️
main/field.c 95.67% <0.00%> (-0.19%) ⬇️
parsers/haskell.c 91.12% <0.00%> (ø)
main/writer-ctags.c 98.70% <0.00%> (+<0.01%) ⬆️
main/read.c 96.19% <0.00%> (+0.05%) ⬆️
main/routines.c 81.18% <0.00%> (+0.06%) ⬆️
main/entry.c 88.83% <0.00%> (+0.46%) ⬆️
parsers/vhdl.c 96.26% <0.00%> (+0.86%) ⬆️
main/vstring.c 91.95% <0.00%> (+1.72%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update bdb7d99...1f209b7. Read the comment docs.

@hirooih
Copy link
Contributor Author

hirooih commented Dec 7, 2020

I've removed some more uncovered lines.

@hirooih hirooih merged commit e6f258d into universal-ctags:master Dec 7, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants