-
Notifications
You must be signed in to change notification settings - Fork 502
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
added Roadmap link in the footer "Company" #2302
Conversation
|
@Adityaadpandey is attempting to deploy a commit to the Unkey Team on Vercel. A member of the Team first needs to authorize it. |
📝 Walkthrough📝 WalkthroughWalkthroughThe changes in this pull request involve the addition of a new navigation link labeled "Roadmap" to the Changes
Assessment against linked issues
Possibly related PRs
Suggested reviewers
📜 Recent review detailsConfiguration used: CodeRabbit UI 📒 Files selected for processing (1)
🚧 Files skipped from review as they are similar to previous changes (1)
Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media? 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
CodeRabbit Configuration File (
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
|
Hey there and thank you for opening this pull request! 👋🏼 We require pull request titles to follow the Conventional Commits specification and it looks like your proposed title needs to be adjusted.
Details:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actionable comments posted: 0
🧹 Outside diff range and nitpick comments (1)
apps/www/components/footer/footer.tsx (1)
35-39
: LGTM! Consider adding a trailing comma for consistency.The addition of the "Roadmap" link is implemented correctly and aligns with the PR objectives. The link is properly structured and marked as external.
For consistency with the other entries in the array, consider adding a trailing comma after the
external: true
property:{ title: "Roadmap", href: "https://github.com/unkeyed/unkey/discussions/categories/roadmap", - external:true + external: true, }This change improves code consistency and makes future additions easier.
I already told you in the comments that I already have a PR open for this. I unassigned myself so that I could assign myself to other issues. @Adityaadpandey . If you had at least seen the issue it already had 2 PRs ( one closed and one open ) both of them were mine. Aside from that, there was a comment stating the same. #2291 |
Well it's my first contribution in open source community so i am not well not about these things |
Duplicate |
What does this PR do?
adds a new link titled "Roadmap" to the footer section of the Unkey website, under the "Company" section
Fixes #2288
Type of change
How should this be tested?
Scroll to the footer and check if the "Roadmap" link appears under "Company."
Checklist
Required
pnpm build
pnpm fmt
console.logs
git pull origin main
Appreciated
Summary by CodeRabbit