chore: add roadmap link in the footer #2291
Conversation
harshsbhat
requested review from
perkinsjr,
chronark,
mcstepp and
MichaelUnkey
as code owners
|
|
@harshsbhat is attempting to deploy a commit to the Unkey Team on Vercel. A member of the Team first needs to authorize it. |
📝 Walkthrough📝 WalkthroughWalkthroughThe changes in this pull request include modifications to the validation schema for the Changes
Assessment against linked issues
Possibly related PRs
Suggested reviewers
📜 Recent review detailsConfiguration used: CodeRabbit UI 📒 Files selected for processing (1)
🚧 Files skipped from review as they are similar to previous changes (1)
Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media? 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
CodeRabbit Configuration File (
|
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
|
Thank you for following the naming conventions for pull request titles! 🙏 |
github-actions
bot
added
🕹️ 150 points
Good first issue
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Actionable comments posted: 0
🧹 Outside diff range and nitpick comments (1)
apps/www/components/footer/footer.tsx (1)
16-16: LGTM! Consider adding an external flag for consistency.The addition of the "Roadmap" link in the footer navigation aligns perfectly with the PR objectives. The implementation is correct and consistent with the existing code structure.
For improved consistency with other external links in the navigation array, consider adding the
external: trueproperty to the "Roadmap" link. This would ensure that the link opens in a new tab, which is typically desirable for roadmap links that lead to external pages. Here's a suggested modification:- { title: "Roadmap", href: "/roadmap" }, + { title: "Roadmap", href: "/roadmap", external: true },This change would make the behavior consistent with other external links in the footer and improve user experience.
📜 Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
📒 Files selected for processing (4)
- apps/dashboard/components/dashboard/feedback-component.tsx (1 hunks)
- apps/dashboard/lib/trpc/routers/plain.ts (1 hunks)
- apps/www/app/roadmap/page.tsx (1 hunks)
- apps/www/components/footer/footer.tsx (1 hunks)
✅ Files skipped from review due to trivial changes (2)
- apps/dashboard/components/dashboard/feedback-component.tsx
- apps/dashboard/lib/trpc/routers/plain.ts
🧰 Additional context used
🔇 Additional comments (4)
apps/www/app/roadmap/page.tsx (4)
1-1: LGTM: Correct import for Next.js navigation.The import statement is correct and appropriate for the intended functionality in a Next.js application.
3-5: LGTM: Correct implementation of the redirect function.The
RoadmapRedirectfunction is implemented correctly:
- It's exported as default, which is appropriate for Next.js page components.
- The function name clearly describes its purpose.
- The implementation is simple and straightforward, which is suitable for a redirect page.
4-4: Verified: Correct redirect URL.The redirect URL "https://github.com/unkeyed/unkey/discussions/categories/roadmap" matches the specifications in the PR objectives and correctly points to the GitHub discussions page for the roadmap.
1-5: Overall assessment: Excellent implementation of the roadmap redirect.This file successfully implements the roadmap redirect functionality as requested in the PR objectives. The code is concise, follows Next.js best practices, and correctly redirects users to the specified GitHub discussions page for the roadmap. Great job!
|
/assign |
|
Assigned to @Pa04rth! Please open a draft PR linking this issue within 48h |
|
/assign |
|
This issue is already assigned to another person. Please find more issues here. |
1 similar comment
|
This issue is already assigned to another person. Please find more issues here. |
|
@mcstepp DONE |
|
/award 150 |
|
Awarding harshsbhat: 150 points 🕹️ Well done! Check out your new contribution on oss.gg/harshsbhat |
|
Awarding harshsbhat: 150 points 🕹️ Well done! Check out your new contribution on oss.gg/harshsbhat |
* removed the wrong commits pushed with this PR * adding roadmap after other info --------- Co-authored-by: Meg Stepp <mcstepp@users.noreply.github.com>
What does this PR do?
Fixes #2288
Adds a roadmap link in the footer which redirects to
www.unkey.com/roadmapand thenhttps://github.com/unkeyed/unkey/discussions/categories/roadmapsimilar to discord.#2281 probably did not run
pnpm fmtthat's why the extra changes in plain and feedback component.Type of change
How should this be tested?
Checklist
Required
pnpm buildpnpm fmtconsole.logsgit pull origin mainAppreciated
Summary by CodeRabbit
Summary by CodeRabbit
New Features
Bug Fixes