fix: full width onboarding on md screens #2371

rishipatel9 · 2024-10-13T10:04:17Z

What does this PR do?

Add full gap for medium size and provided full width to child component

Fixes #2370

Type of change

Bug fix (non-breaking change which fixes an issue)
Chore (refactoring code, technical debt, workflow improvements)
Enhancement (small improvements)
New feature (non-breaking change which adds functionality)
Breaking change (fix or feature that would cause existing functionality to not work as expected)
This change requires a documentation update

How should this be tested?

Navigate to Create workspace page on phone

Checklist

Required

Appreciated

If a UI change was made: Added a screen recording or screenshots to this PR
Updated the Unkey Docs if changes were necessary

Summary by CodeRabbit

New Features
- Enhanced the layout and responsiveness of the Create Workspace component for improved user experience on various screen sizes.
Bug Fixes
- Adjusted the width of the main element to ensure optimal display on smaller screens.

changeset-bot · 2024-10-13T10:04:21Z

⚠️ No Changeset found

Latest commit: f6c71c4

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

CLAassistant · 2024-10-13T10:04:23Z

All committers have signed the CLA.

vercel · 2024-10-13T10:04:24Z

@rishipatel9 is attempting to deploy a commit to the Unkey Team on Vercel.

A member of the Team first needs to authorize it.

coderabbitai · 2024-10-13T10:04:24Z

📝 Walkthrough

Walkthrough

The changes in this pull request focus on enhancing the layout and responsiveness of the CreateWorkspace component in apps/dashboard/app/new/create-workspace.tsx. The outer <div> was modified to allow for a responsive design, switching from a fixed flex direction to a layout that adapts based on screen size. Additionally, the width settings for the <main> element were adjusted to ensure full-width display on smaller screens while retaining previous dimensions on larger screens.

Changes

File Path	Change Summary
apps/dashboard/app/new/create-workspace.tsx	Updated layout structure for responsiveness; changed outer `<div>` to support responsive flex direction and adjusted `<main>` width.

Assessment against linked issues

Objective	Addressed	Explanation
Improve responsiveness of the Create Workspace page (2370)	✅

Possibly related PRs

fix: make keys UI responsive to mobile devices #2145: The changes in the Keys component also focus on enhancing responsiveness for mobile devices, similar to the layout adjustments made in the CreateWorkspace component.
fix(dashboard): hydration warnings #2253: Although primarily addressing hydration warnings, this PR involves structural changes in components that may relate to layout and rendering, which is a focus of the main PR's changes to the CreateWorkspace component.
fix: weird spacing in changelog by removing the extra gap #2340: The adjustments made to spacing in the Changelog and BlogList components reflect a similar concern for layout and visual presentation, which aligns with the responsive design improvements in the CreateWorkspace component.

Suggested labels

Bug, 🕹️ oss.gg, :joystick: 150 points, hacktoberfest

Suggested reviewers

mcstepp
chronark
perkinsjr

📜 Recent review details

Configuration used: CodeRabbit UI
Review profile: CHILL

📥 Commits

Files that changed from the base of the PR and between b4e2e24 and c540e17.

📒 Files selected for processing (1)

apps/dashboard/app/new/create-workspace.tsx (1 hunks)

🧰 Additional context used

🔇 Additional comments (3)

apps/dashboard/app/new/create-workspace.tsx (3)

62-62: Excellent responsive layout implementation!

The changes to the outer <div> element significantly improve the component's responsiveness, addressing the issue raised in #2370. The use of Tailwind CSS utility classes flex-col md:flex-row and gap-8 md:gap-16 ensures a stacked layout on smaller screens and a side-by-side layout on medium and larger screens. This implementation enhances the user experience across different device sizes, particularly for medium-sized screens as requested.

63-63: Effective width adjustment for improved responsiveness

The modification of the <main> element's width class from w-3/4 to w-full md:w-3/4 is a well-thought-out change. This adjustment ensures that:

On smaller screens, the main content utilizes the full width of its container, maximizing the available space.

On medium and larger screens, the width remains at 3/4 of the container, maintaining the existing layout for larger devices.

This change directly addresses the issue raised in #2370, where the component lacked full width on medium-sized screens. It works in tandem with the responsive layout of the parent <div> to create a cohesive, adaptive design across various screen sizes.

62-63: Summary: Successful implementation of responsive design

The changes made to the CreateWorkspace component effectively address the responsiveness issues raised in #2370 and align perfectly with the PR objectives. By implementing a flexible layout that adapts to different screen sizes, particularly medium-sized screens, the usability and accessibility of the Create Workspace page have been significantly improved.

Key improvements:

Responsive flex direction for better content organization on various screen sizes.

Adaptive gap sizes to maintain visual harmony across devices.

Full-width main content on smaller screens for optimal space utilization.

These changes demonstrate a thoughtful approach to responsive design and should greatly enhance the user experience when creating a new workspace across different devices.

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

❤️ Share

🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

Review comments: Directly reply to a review comment made by CodeRabbit. Example:
- I pushed a fix in commit <commit_id>, please review it.
- Generate unit testing code for this file.
- Open a follow-up GitHub issue for this discussion.
Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
- @coderabbitai generate unit testing code for this file.
- @coderabbitai modularize this function.
PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
- @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
- @coderabbitai read src/utils.ts and generate unit testing code.
- @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
- @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

@coderabbitai pause to pause the reviews on a PR.
@coderabbitai resume to resume the paused reviews.
@coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
@coderabbitai full review to do a full review from scratch and review all the files again.
@coderabbitai summary to regenerate the summary of the PR.
@coderabbitai resolve resolve all the CodeRabbit review comments.
@coderabbitai configuration to show the current CodeRabbit configuration for the repository.
@coderabbitai help to get help.

Other keywords and placeholders

Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (`.coderabbit.yaml`)

You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
Please see the configuration documentation for more information.
If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

Visit our Documentation for detailed information on how to use CodeRabbit.
Join our Discord Community to get help, request features, and share feedback.
Follow us on X/Twitter for updates and announcements.

vercel · 2024-10-13T10:04:25Z

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name	Status	Preview	Comments	Updated (UTC)
dashboard	✅ Ready (Inspect)	Visit Preview	💬 Add feedback	Oct 13, 2024 11:40am
engineering	✅ Ready (Inspect)	Visit Preview	💬 Add feedback	Oct 13, 2024 11:40am
play	✅ Ready (Inspect)	Visit Preview	💬 Add feedback	Oct 13, 2024 11:40am
workflows	✅ Ready (Inspect)	Visit Preview	💬 Add feedback	Oct 13, 2024 11:40am
www	✅ Ready (Inspect)	Visit Preview	💬 Add feedback	Oct 13, 2024 11:40am

github-actions · 2024-10-13T10:04:30Z

Thank you for following the naming conventions for pull request titles! 🙏

* fix:breadcrum-cache-issue * chore:rename-revalidateMytag * refactor: move-revalidateTag * refactor: extract tags into reusable utility * feat: add template * Update 3_follow_the_unkey_x_account.md (#2323) * fix: capture uniqueness error and return it correctly (#2337) * docs: getVerifications instead of get (#2329) * Update 3_follow_the_unkey_x_account.md (#2324) Followed unkey on Twitter Co-authored-by: Andreas Thomas <dev@chronark.com> * fix: transaction ...: in use: for query (#2278) * fix: transaction ...: in use: for query - Fixes #2197 - The error is caused by the cache revalidation happening in the background, so we have a racecondition with the other queries we are running in the insertGenericAuditLogs function * docs: explain for future self * fix: another racecondition also bulk insert auditLogs and auditLogTargets * [autofix.ci] apply automated fixes --------- Co-authored-by: chronark <dev@chronark.com> Co-authored-by: autofix-ci[bot] <114827586+autofix-ci[bot]@users.noreply.github.com> * fix: handle undefined ratelimits * Update 3_follow_the_unkey_x_account.md (#2338) * fix: handle case when blogs array is empty * [oss.gg] side quest : added another framework; hono on cloudflare workers. (#2345) * fix: weird spacing in changelog by removing the extra gap (#2340) * fix: weird spacing in changelog * feat: formatted * oss.gg: create a template for ratelimiting a oak server in deno with unkey (#2308) Co-authored-by: Andreas Thomas <dev@chronark.com> * follow unkey on X #2252 (#2315) Co-authored-by: Your Name <you@example.com> * Follow the Unkey X account: @unkeydev Complete! (#2332) * Update 3_follow_the_unkey_x_account.md * Update 3_follow_the_unkey_x_account.md --------- Co-authored-by: Andreas Thomas <dev@chronark.com> * fix(www): analytics bento code snippet is not readable (#2311) - add hover effect to analytics bento removing gradient background - make copy code button sticky to top-right corner - impl independent vertical scrolls for language switcher and code editor * Update 7_create_a_template.md * Update 7_create_a_template.md * chore(deps-dev): bump @content-collections/core from 0.6.2 to 0.7.2 (#2255) Bumps @content-collections/core from 0.6.2 to 0.7.2. --- updated-dependencies: - dependency-name: "@content-collections/core" dependency-type: direct:development update-type: version-update:semver-minor ... Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> * fix: order audit logs by time, show latest on top (#2295) * feat: add template * feat: Unkey FastAPI boilerplate (#2307) * feat: add template * feat: follow unkey on X (#2357) * Update 6_record_onboarding.md (#2301) * fix: reset input fields in API delete dialog after reopening (#2316) * fix: reset input fields in API delete dialog after reopening * refactor: remove unnecessary useEffect and utilize existing onOpenChange function for dialog * refactor: removed unused imports * Update 3_follow_the_unkey_x_account.md (#2364) Added name to the followed list. Co-authored-by: Andreas Thomas <dev@chronark.com> * ci: add label * feat: add hover to input fields * Added gaps and width for md (#2371) * docs: update overview.mdx (#2384) avaliable -> available * oss.gg side quest 3_follow_the_unkey_x_account.md (#2399) Followed the unkey x account * feat: Following unkey acc on twitter #2407 (#2408) * Feat: Followed Unkey on X * Feat: Followed Unkey on Twitter --------- Co-authored-by: Andreas Thomas <dev@chronark.com> * resolve merge conflicts * resolve merge conflicts --------- Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: chronark <dev@chronark.com> Co-authored-by: Emily Marie Ahtúnan <86572370+Emmarie-Ahtunan@users.noreply.github.com> Co-authored-by: Harsh Shrikant Bhat <90265455+harshsbhat@users.noreply.github.com> Co-authored-by: Aritra Sadhukhan <60315087+aritradevelops@users.noreply.github.com> Co-authored-by: Flo <53355483+Flo4604@users.noreply.github.com> Co-authored-by: autofix-ci[bot] <114827586+autofix-ci[bot]@users.noreply.github.com> Co-authored-by: Devang Rakholiya <116096508+Devang0907@users.noreply.github.com> Co-authored-by: Prabin <42871240+prabincankod@users.noreply.github.com> Co-authored-by: ZiaCodes <72739794+Khaan25@users.noreply.github.com> Co-authored-by: Devansh Baghel <77718741+Devansh-Baghel@users.noreply.github.com> Co-authored-by: Shreenarayan jaiswal <127131074+shreenarayan123@users.noreply.github.com> Co-authored-by: Your Name <you@example.com> Co-authored-by: Chirag Arora <chirag8023@gmail.com> Co-authored-by: Nazar Poshtarenko <32395926+unrenamed@users.noreply.github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Co-authored-by: Saketh Pavan Goti <44170829+Sakethpavan@users.noreply.github.com> Co-authored-by: Teddy ASSIH <110066080+Ionfinisher@users.noreply.github.com> Co-authored-by: Vardhaman Bhandari <97441447+Vardhaman619@users.noreply.github.com> Co-authored-by: Atharva_404 <72994819+Atharva-3000@users.noreply.github.com> Co-authored-by: Rishi <rishipatel0826@gmail.com> Co-authored-by: Ikko Eltociear Ashimine <eltociear@gmail.com> Co-authored-by: Ayan Mondal <ayanmondal1805@gmail.com> Co-authored-by: Kunal Arya <105645118+kunalarya873@users.noreply.github.com>

Added gaps and width for md

c540e17

rishipatel9 requested review from perkinsjr, chronark and mcstepp as code owners October 13, 2024 10:04

github-actions bot added the 🕹️ oss.gg label Oct 13, 2024

vercel bot deployed to Preview – engineering October 13, 2024 10:05 View deployment

rishipatel9 changed the title ~~Added gaps and width for md~~ Fix:Added gaps and width for md Oct 13, 2024

vercel bot deployed to Preview – dashboard October 13, 2024 10:14 View deployment

chronark changed the title ~~Fix:Added gaps and width for md~~ fix: full width onboarding on md screens Oct 13, 2024

chronark enabled auto-merge October 13, 2024 10:27

vercel bot deployed to Preview – play October 13, 2024 10:27 View deployment

vercel bot deployed to Preview – workflows October 13, 2024 10:28 View deployment

vercel bot deployed to Preview – www October 13, 2024 10:28 View deployment

Merge branch 'main' into ui_changes

f6c71c4

vercel bot deployed to Preview – engineering October 13, 2024 11:31 View deployment

vercel bot deployed to Preview – play October 13, 2024 11:35 View deployment

vercel bot deployed to Preview – workflows October 13, 2024 11:36 View deployment

chronark approved these changes Oct 13, 2024

View reviewed changes

vercel bot deployed to Preview – www October 13, 2024 11:36 View deployment

vercel bot deployed to Preview – dashboard October 13, 2024 11:40 View deployment

chronark added this pull request to the merge queue Oct 13, 2024

Merged via the queue into unkeyed:main with commit 7972170 Oct 13, 2024
23 of 24 checks passed

AkshayBandi027 pushed a commit to AkshayBandi027/unkey that referenced this pull request Oct 14, 2024

Added gaps and width for md (unkeyed#2371)

6e72da9

AkshayBandi027 pushed a commit to AkshayBandi027/unkey that referenced this pull request Oct 14, 2024

Added gaps and width for md (unkeyed#2371)

f1c6570

This was referenced Oct 16, 2024

fix: Missing plan check and ip whitelist parsing #2379

Merged

fix: disable save button when workspace name is empty #2294

Merged

coderabbitai bot mentioned this pull request Dec 3, 2024

feat: New logs page #2143

Closed

18 tasks

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

fix: full width onboarding on md screens #2371

fix: full width onboarding on md screens #2371

rishipatel9 commented Oct 13, 2024 •

edited

Loading

changeset-bot bot commented Oct 13, 2024 •

edited

Loading

CLAassistant commented Oct 13, 2024 •

edited

Loading

vercel bot commented Oct 13, 2024

coderabbitai bot commented Oct 13, 2024 •

edited

Loading

Walkthrough

Changes

Assessment against linked issues

Possibly related PRs

Suggested labels

Suggested reviewers

Chat

CodeRabbit Commands (Invoked using PR comments)

Other keywords and placeholders

CodeRabbit Configuration File (`.coderabbit.yaml`)

Documentation and Community

vercel bot commented Oct 13, 2024 •

edited

Loading

github-actions bot commented Oct 13, 2024 •

edited

Loading

fix: full width onboarding on md screens #2371

fix: full width onboarding on md screens #2371

Conversation

rishipatel9 commented Oct 13, 2024 • edited Loading

What does this PR do?

Type of change

How should this be tested?

Checklist

Required

Appreciated

Summary by CodeRabbit

changeset-bot bot commented Oct 13, 2024 • edited Loading

⚠️ No Changeset found

CLAassistant commented Oct 13, 2024 • edited Loading

vercel bot commented Oct 13, 2024

coderabbitai bot commented Oct 13, 2024 • edited Loading

Walkthrough

Changes

Assessment against linked issues

Possibly related PRs

Suggested labels

Suggested reviewers

Chat

CodeRabbit Commands (Invoked using PR comments)

Other keywords and placeholders

CodeRabbit Configuration File (.coderabbit.yaml)

Documentation and Community

vercel bot commented Oct 13, 2024 • edited Loading

github-actions bot commented Oct 13, 2024 • edited Loading

rishipatel9 commented Oct 13, 2024 •

edited

Loading

changeset-bot bot commented Oct 13, 2024 •

edited

Loading

CLAassistant commented Oct 13, 2024 •

edited

Loading

coderabbitai bot commented Oct 13, 2024 •

edited

Loading

CodeRabbit Configuration File (`.coderabbit.yaml`)

vercel bot commented Oct 13, 2024 •

edited

Loading

github-actions bot commented Oct 13, 2024 •

edited

Loading