Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Support shadows for Popups and Flyouts #11138

Open
MartinZikmund opened this issue Feb 1, 2023 · 4 comments
Open

Support shadows for Popups and Flyouts #11138

MartinZikmund opened this issue Feb 1, 2023 · 4 comments
Labels
area/popups 💬 Categorizes an issue or PR as relevant to popups or flyouts area/shadows Categorizes an issue or PR as relevant to shadows difficulty/challenging 🤯 Categorizes an issue for which the difficulty level is reachable with internals understanding kind/enhancement New feature or request project/styling 👔 Categorizes an issue or PR as relevant to element styling

Comments

@MartinZikmund
Copy link
Member

What would you like to be added:

Elevation for popup elements

Why is this needed:

Visual pop

For which Platform:

All
@MartinZikmund MartinZikmund added difficulty/tbd Categorizes an issue for which the difficulty level needs to be defined. kind/enhancement New feature or request triage/untriaged Indicates an issue requires triaging or verification difficulty/challenging 🤯 Categorizes an issue for which the difficulty level is reachable with internals understanding project/styling 👔 Categorizes an issue or PR as relevant to element styling and removed difficulty/tbd Categorizes an issue for which the difficulty level needs to be defined. triage/untriaged Indicates an issue requires triaging or verification labels Feb 1, 2023
@DierkDroth DierkDroth mentioned this issue Feb 1, 2023
Closed
11 tasks
@jeromelaban jeromelaban added the area/shadows Categorizes an issue or PR as relevant to shadows label Feb 1, 2023
@DierkDroth
Copy link

@MartinZikmund I took another look at the ThemeShadow issue. It worries me a bit that you stated that the implementation for Popups and Flyouts likely would be based on ElevatedView.

This imples that I would have to add the Uno.UI.Toolkit package to work around the missing 'ThemeShadow' support, no? This I very much would not want to do just for getting this sole issue 'resolved'.

Is my understanding correct?

@DierkDroth
Copy link

@MartinZikmund while ripping through theme XAML files I realized that the dropdowns for ComboBox and AutoSuggestBox also have a shadow effect. So it might make sense to look into those controls as well...

@jp-weber
Copy link
Contributor

Could we not do this on the basis of the implementation of MAUI?

dotnet/maui#570

@MartinZikmund
Copy link
Member Author

@jp-weber our shadow support uses the same APIs, but the tricky part is clipping that causes issues when corner radius is used. We will need to investigate this further

@MartinZikmund MartinZikmund added the area/popups 💬 Categorizes an issue or PR as relevant to popups or flyouts label Aug 23, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
area/popups 💬 Categorizes an issue or PR as relevant to popups or flyouts area/shadows Categorizes an issue or PR as relevant to shadows difficulty/challenging 🤯 Categorizes an issue for which the difficulty level is reachable with internals understanding kind/enhancement New feature or request project/styling 👔 Categorizes an issue or PR as relevant to element styling
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
4 participants
@MartinZikmund @jeromelaban @jp-weber @DierkDroth