Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

WinUI TeachingTip #3911

Closed
7 of 11 tasks
MartinZikmund opened this issue Aug 30, 2020 · 13 comments · Fixed by #15732
Closed
7 of 11 tasks

WinUI TeachingTip #3911

MartinZikmund opened this issue Aug 30, 2020 · 13 comments · Fixed by #15732
Assignees
Labels
area/popups 💬 Categorizes an issue or PR as relevant to popups or flyouts blocked/dependency Categorizes an issue as blocked due to another issue difficulty/challenging 🤯 Categorizes an issue for which the difficulty level is reachable with internals understanding kind/enhancement New feature or request platform/android 🤖 Categorizes an issue or PR as relevant to the Android platform platform/ios 🍎 Categorizes an issue or PR as relevant to the iOS platform platform/macos 🍏 Categorizes an issue or PR as relevant to the macOS platform platform/wasm 🌐 Categorizes an issue or PR as relevant to the WebAssembly platform project/input ⌨️ Categorizes an issue or PR as relevant to input (Button, CheckBox, Toggle, Scroll, Map, Numeric,...)

Comments

@MartinZikmund
Copy link
Member

What would you like to be added:

WinUI TeachingTip control.

Why is this needed:

WinUI parity.

For which Platform:

  • iOS
  • Android
  • WebAssembly
  • WebAssembly renderers for Xamarin.Forms
  • macOS
  • Skia
    • WPF
    • GTK (Linux)
  • Windows
  • Build tasks
  • Solution Templates
@MartinZikmund MartinZikmund added kind/enhancement New feature or request triage/untriaged Indicates an issue requires triaging or verification platform/android 🤖 Categorizes an issue or PR as relevant to the Android platform platform/ios 🍎 Categorizes an issue or PR as relevant to the iOS platform platform/macos 🍏 Categorizes an issue or PR as relevant to the macOS platform area/skia ✏️ Categorizes an issue or PR as relevant to Skia platform/wasm 🌐 Categorizes an issue or PR as relevant to the WebAssembly platform and removed triage/untriaged Indicates an issue requires triaging or verification labels Aug 30, 2020
@MartinZikmund MartinZikmund self-assigned this Aug 30, 2020
@agneszitte agneszitte added the project/input ⌨️ Categorizes an issue or PR as relevant to input (Button, CheckBox, Toggle, Scroll, Map, Numeric,...) label Sep 21, 2020
@jeromelaban jeromelaban added the difficulty/tbd Categorizes an issue for which the difficulty level needs to be defined. label Feb 15, 2021
@MartinZikmund MartinZikmund added this to the 3.7 milestone Mar 22, 2021
@MartinZikmund MartinZikmund modified the milestones: 3.7, 3.8 Apr 14, 2021
@sigmarsson
Copy link

@MartinZikmund when is it gonna be available or is it already in any 3.7dev pkg ?

@MartinZikmund
Copy link
Member Author

Unfortunately not yet. While the code is ported, it will require quite a few Uno-specific adjustments to properly show up. I'm hoping this can be finished for 3.8

@MartinZikmund MartinZikmund modified the milestones: 3.8, 3.9 May 12, 2021
@MartinZikmund MartinZikmund added difficulty/challenging 🤯 Categorizes an issue for which the difficulty level is reachable with internals understanding and removed difficulty/tbd Categorizes an issue for which the difficulty level needs to be defined. labels Jun 1, 2021
@MartinZikmund
Copy link
Member Author

This control is highly dependent on Popup, so it is quite tricky to get it working currently, until we rewrite popups significantly

@MartinZikmund MartinZikmund added the area/popups 💬 Categorizes an issue or PR as relevant to popups or flyouts label Jun 1, 2021
@sigmarsson
Copy link

@MartinZikmund , okay it isn't very essential control, so we can either substitute or wait if you could estimate a version number please.

@MartinZikmund
Copy link
Member Author

Quite hard to say... 3.9 is unlikely, possibly 3.10, but probably will take a while to make it work just right on all platforms

@MartinZikmund MartinZikmund removed this from the 3.9 milestone Jul 26, 2021
@DierkDroth
Copy link

DierkDroth commented Jan 2, 2022

@MartinZikmund appears latest UNO 4.X compiles TeachingTip fine with .NET 6 + WindowsAppSdk. Does this means it's supported now?

If not, shouldn't I get warning?
There is none - in fact I don't get any 'not supported' warning in my project at all ... which I find surprising given the many warning I got with UNO 3.X

@MartinZikmund MartinZikmund removed the area/skia ✏️ Categorizes an issue or PR as relevant to Skia label Jan 6, 2022
@FrozDark
Copy link

Is it ready to be implemented?

@MartinZikmund MartinZikmund added the blocked/dependency Categorizes an issue as blocked due to another issue label Nov 10, 2022
@MartinZikmund
Copy link
Member Author

I will be rebasing this and checking the state of the control now that we have Popup placement support.

@MartinZikmund MartinZikmund changed the title WinUI TeachingTip [WIP] WinUI TeachingTip Jan 31, 2023
@MartinZikmund MartinZikmund changed the title [WIP] WinUI TeachingTip WinUI TeachingTip Jan 31, 2023
@DierkDroth
Copy link

DierkDroth commented Jan 31, 2023

@MartinZikmund thanks. I actually replaced the TeachingTip as while back by some custom code. Nevertheless, it's definitely great to have it supported.

Popup placement support.

This rang a bell: I'm desperately waiting to get support for the shadow effect on Flyouts, since they look plain and horrible on WASM. Is there any chance now with the above mentioned 'popup' support.

@MartinZikmund
Copy link
Member Author

@MartinZikmund thanks. I actually replaced the TeachingTip as while back by some custom code. Nevertheless, it's definitely great to have it supported.

Popup placement support.

This rang a bell: I'm desperately waiting to get support for the shadow effect on Flyouts, since they look plain and horrible on WASM. Is there any chance now with the above mentioned 'popup' support.

Shadows are a bit tricky, as they interfere with clipping on some targets. Hence to add elevation to popups, we will probably need to wrap them in elevated view. But it is definitely something we want to take care of soon. Will create an issue specifically for this

@DierkDroth
Copy link

DierkDroth commented Feb 1, 2023

Thanks @MartinZikmund

I saw that you guys made progress on ElevatedView. Looking forward to see this becoming real

@BertrandDeSaintBezier
Copy link

Any news on how the implementation is progressing ? :D

@ACheekyBeluga
Copy link

😮 how soon can we expect this to be released ?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/popups 💬 Categorizes an issue or PR as relevant to popups or flyouts blocked/dependency Categorizes an issue as blocked due to another issue difficulty/challenging 🤯 Categorizes an issue for which the difficulty level is reachable with internals understanding kind/enhancement New feature or request platform/android 🤖 Categorizes an issue or PR as relevant to the Android platform platform/ios 🍎 Categorizes an issue or PR as relevant to the iOS platform platform/macos 🍏 Categorizes an issue or PR as relevant to the macOS platform platform/wasm 🌐 Categorizes an issue or PR as relevant to the WebAssembly platform project/input ⌨️ Categorizes an issue or PR as relevant to input (Button, CheckBox, Toggle, Scroll, Map, Numeric,...)
Projects
None yet
Development

Successfully merging a pull request may close this issue.

8 participants