Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Docs(AlertDialog): Fix default values for the components #914

Merged
merged 1 commit into from
May 17, 2024

Conversation

dwightjack
Copy link
Contributor

Correct the documentation about the default values for some of the components in AlertDialog.

@zernonia
Copy link
Member

the meta/*.md files were auto-generated. I think vue-component-meta couldn't pick up the default props from Dialog in this case. We should assign a default as in the AlertDialog component instead.

@dwightjack
Copy link
Contributor Author

Oh, sorry, I didn't noticed it. I'll try to investigate if we can fix this issue via vue-component-meta.

@zernonia zernonia marked this pull request as draft May 14, 2024 01:18
@dwightjack
Copy link
Contributor Author

@zernonia I investigated this problem, and indeed, vue-component-meta is not picking the default value, probably because it's not defined in the derived components (for example AlertDialogAction), but in the parent component (DialogClose).

I am not familiar with vue-component-meta but I don't think it could infer the default value in any way. One option could be to re-define the default values in the derived components, even if that's a repetition 🤔 .

@zernonia
Copy link
Member

Yup. The vue-component-meta is using static analysis, there's some limitation to it. I'm ok with re-defining the default value for them 😁

@dwightjack
Copy link
Contributor Author

Cool. I will update the PR 👍

@dwightjack dwightjack marked this pull request as ready for review May 17, 2024 02:40
@dwightjack
Copy link
Contributor Author

@zernonia sorry for the delay. I updated the PR.

Copy link
Member

@zernonia zernonia left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Thanks for the PR @dwightjack ! 🚀

@zernonia zernonia merged commit 32ac33b into unovue:main May 17, 2024
3 of 4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants