Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Docs(AlertDialog): Fix default values for the components #914

Merged
merged 1 commit into from
May 17, 2024
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion docs/content/meta/AlertDialogAction.md
Original file line number Diff line number Diff line change
Expand Up @@ -6,7 +6,7 @@
'description': '<p>The element or component this component should render as. Can be overwrite by <code>asChild</code></p>\n',
'type': 'AsTag | Component',
'required': false,
'default': '\'div\''
'default': '\'button\''
},
{
'name': 'asChild',
Expand Down
2 changes: 1 addition & 1 deletion docs/content/meta/AlertDialogCancel.md
Original file line number Diff line number Diff line change
Expand Up @@ -6,7 +6,7 @@
'description': '<p>The element or component this component should render as. Can be overwrite by <code>asChild</code></p>\n',
'type': 'AsTag | Component',
'required': false,
'default': '\'div\''
'default': '\'button\''
},
{
'name': 'asChild',
Expand Down
2 changes: 1 addition & 1 deletion docs/content/meta/AlertDialogDescription.md
Original file line number Diff line number Diff line change
Expand Up @@ -6,7 +6,7 @@
'description': '<p>The element or component this component should render as. Can be overwrite by <code>asChild</code></p>\n',
'type': 'AsTag | Component',
'required': false,
'default': '\'div\''
'default': '\'p\''
},
{
'name': 'asChild',
Expand Down
2 changes: 1 addition & 1 deletion docs/content/meta/AlertDialogTitle.md
Original file line number Diff line number Diff line change
Expand Up @@ -6,7 +6,7 @@
'description': '<p>The element or component this component should render as. Can be overwrite by <code>asChild</code></p>\n',
'type': 'AsTag | Component',
'required': false,
'default': '\'div\''
'default': '\'h2\''
},
{
'name': 'asChild',
Expand Down
2 changes: 1 addition & 1 deletion docs/content/meta/AlertDialogTrigger.md
Original file line number Diff line number Diff line change
Expand Up @@ -6,7 +6,7 @@
'description': '<p>The element or component this component should render as. Can be overwrite by <code>asChild</code></p>\n',
'type': 'AsTag | Component',
'required': false,
'default': '\'div\''
'default': '\'button\''
},
{
'name': 'asChild',
Expand Down
2 changes: 1 addition & 1 deletion packages/radix-vue/src/AlertDialog/AlertDialogAction.vue
Original file line number Diff line number Diff line change
Expand Up @@ -8,7 +8,7 @@ export interface AlertDialogActionProps extends DialogCloseProps {}
<script setup lang="ts">
import { DialogClose } from '@/Dialog'

const props = defineProps<AlertDialogActionProps>()
const props = withDefaults(defineProps<AlertDialogActionProps>(), { as: 'button' })
useForwardExpose()
</script>

Expand Down
2 changes: 1 addition & 1 deletion packages/radix-vue/src/AlertDialog/AlertDialogCancel.vue
Original file line number Diff line number Diff line change
Expand Up @@ -10,7 +10,7 @@ import { onMounted } from 'vue'
import { injectAlertDialogContentContext } from './AlertDialogContent.vue'
import { DialogClose } from '@/Dialog'

const props = defineProps<AlertDialogCancelProps>()
const props = withDefaults(defineProps<AlertDialogCancelProps>(), { as: 'button' })
const contentContext = injectAlertDialogContentContext()
const { forwardRef, currentElement } = useForwardExpose()

Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -8,7 +8,7 @@ export interface AlertDialogDescriptionProps extends DialogDescriptionProps {}
<script setup lang="ts">
import { DialogDescription } from '@/Dialog'

const props = defineProps<AlertDialogDescriptionProps>()
const props = withDefaults(defineProps<AlertDialogDescriptionProps>(), { as: 'p' })
useForwardExpose()
</script>

Expand Down
2 changes: 1 addition & 1 deletion packages/radix-vue/src/AlertDialog/AlertDialogTitle.vue
Original file line number Diff line number Diff line change
Expand Up @@ -8,7 +8,7 @@ export interface AlertDialogTitleProps extends DialogTitleProps {}
<script setup lang="ts">
import { DialogTitle } from '@/Dialog'

const props = defineProps<AlertDialogTitleProps>()
const props = withDefaults(defineProps<AlertDialogTitleProps>(), { as: 'h2' })
useForwardExpose()
</script>

Expand Down
2 changes: 1 addition & 1 deletion packages/radix-vue/src/AlertDialog/AlertDialogTrigger.vue
Original file line number Diff line number Diff line change
Expand Up @@ -8,7 +8,7 @@ export interface AlertDialogTriggerProps extends DialogTriggerProps {}
<script setup lang="ts">
import { DialogTrigger } from '@/Dialog'

const props = defineProps<AlertDialogTriggerProps>()
const props = withDefaults(defineProps<AlertDialogTriggerProps>(), { as: 'button' })
useForwardExpose()
</script>

Expand Down
Loading