[release-1.13] Backport Usage API and Convert from Json Transform #105
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ransform Signed-off-by: Philippe Scorsolini <p.scorsolini@gmail.com> (cherry picked from commit 66e02e4)
Signed-off-by: Hasan Turken <turkenh@gmail.com> (cherry picked from commit 0339892)
- No more block annotation - Webhook for checking usages - Index used fields - Used resources as an array - Return 409 when deletion blocked - Fixes from Usage design reviews - Use objectSelector in usage webhook - Used resource should have in-use label Signed-off-by: Hasan Turken <turkenh@gmail.com> Update and generate with latest schema Signed-off-by: Hasan Turken <turkenh@gmail.com> (cherry picked from commit 221ab17)
Signed-off-by: Hasan Turken <turkenh@gmail.com> (cherry picked from commit f9aca52)
- Add logs and comments for Usage implementation - Add events in Usage reconciler - Add conditions to Usage resource - Resolve selectors if any - Add CEL rule for Usage, either by or reason should be defined - Handle Usage with reason Signed-off-by: Hasan Turken <turkenh@gmail.com> (cherry picked from commit 0e1c4d2)
Signed-off-by: Hasan Turken <turkenh@gmail.com> (cherry picked from commit 7e4112a)
Also: - Do not add owner references to the used resource - Rename dependency package as resource - Add unit tests for usage reference selector - Add unit tests for usage reconciler - Add unit tests for usage webhook Signed-off-by: Hasan Turken <turkenh@gmail.com> (cherry picked from commit 8236621)
Also: - Add details annotation and column to Usage - It should be possible to override REGISTRY_ORGS - Asses Usage functionality in composition with e2e - e2e tests with suites Signed-off-by: Hasan Turken <turkenh@gmail.com> (cherry picked from commit 4e7889a)
Also: - Resolve comments in Usage - Remove composite check during deletion Signed-off-by: Hasan Turken <turkenh@gmail.com> (cherry picked from commit f7ac2fb)
Signed-off-by: Hasan Turken <turkenh@gmail.com> (cherry picked from commit 72011ee)
Signed-off-by: Hasan Turken <turkenh@gmail.com> (cherry picked from commit 44956a2)
Signed-off-by: Hasan Turken <turkenh@gmail.com> (cherry picked from commit 5f5ed2a)
Signed-off-by: Hasan Turken <turkenh@gmail.com>
As it depends on previous refactorings on the master branch which we don't have on the release branch. Signed-off-by: Hasan Turken <turkenh@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of your changes
This PR backports the following upstream PR to the release branch:
Usagetype for Deletion Ordering and Resource Protection crossplane/crossplane#4444 (e2e changes stripped out as they depend on some refactoring available on master only)Additionally, it applies a workaround (since we don't maintain a crossplane-runtime fork) to backport the following runtime PR:
I have:
make reviewableto ensure this PR is ready for review.Addedbackport release-x.ylabels to auto-backport this PR, if necessary.Opened a PR updating the docs, if necessary.