Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[release-1.13] Backport Usage API and Convert from Json Transform #105

Merged
merged 14 commits into from
Sep 12, 2023
Merged

[release-1.13] Backport Usage API and Convert from Json Transform #105

merged 14 commits into from
Sep 12, 2023

Commits on Sep 12, 2023

  1. fix(alpha): schema aware validation properly handling ToJson string t… 

    …ransform

Signed-off-by: Philippe Scorsolini <p.scorsolini@gmail.com>
(cherry picked from commit 66e02e4)
    @phisco @turkenh
    phisco authored and turkenh committed Sep 12, 2023
    Configuration menu
    Copy the full SHA
    b0b00ca View commit details
    Browse the repository at this point in the history

  2. Add support for convert from json to object/list 

    Signed-off-by: Hasan Turken <turkenh@gmail.com>
(cherry picked from commit 0339892)
    @turkenh
    turkenh committed Sep 12, 2023
    Configuration menu
    Copy the full SHA
    3af579d View commit details
    Browse the repository at this point in the history

  3. Add usage type for deletion blocking 

    - No more block annotation
- Webhook for checking usages
- Index used fields
- Used resources as an array
- Return 409 when deletion blocked
- Fixes from Usage design reviews
- Use objectSelector in usage webhook
- Used resource should have in-use label

Signed-off-by: Hasan Turken <turkenh@gmail.com>

Update and generate with latest schema

Signed-off-by: Hasan Turken <turkenh@gmail.com>
(cherry picked from commit 221ab17)
    @turkenh
    turkenh committed Sep 12, 2023
    Configuration menu
    Copy the full SHA
    36eba3c View commit details
    Browse the repository at this point in the history

  4. Support multiple webhook configurations in init 

    Signed-off-by: Hasan Turken <turkenh@gmail.com>
(cherry picked from commit f9aca52)
    @turkenh
    turkenh committed Sep 12, 2023
    Configuration menu
    Copy the full SHA
    dacfe36 View commit details
    Browse the repository at this point in the history

  5. Usage controller improvements 

    - Add logs and comments for Usage implementation
- Add events in Usage reconciler
- Add conditions to Usage resource
- Resolve selectors if any
- Add CEL rule for Usage, either by or reason should be defined
- Handle Usage with reason

Signed-off-by: Hasan Turken <turkenh@gmail.com>
(cherry picked from commit 0e1c4d2)
    @turkenh
    turkenh committed Sep 12, 2023
    Configuration menu
    Copy the full SHA
    dacd8d7 View commit details
    Browse the repository at this point in the history

  6. Add alpha flag for Usages 

    Signed-off-by: Hasan Turken <turkenh@gmail.com>
(cherry picked from commit 7e4112a)
    @turkenh
    turkenh committed Sep 12, 2023
    Configuration menu
    Copy the full SHA
    720d60d View commit details
    Browse the repository at this point in the history

  7. Add unit tests for Usage 

    Also:
- Do not add owner references to the used resource
- Rename dependency package as resource
- Add unit tests for usage reference selector
- Add unit tests for usage reconciler
- Add unit tests for usage webhook

Signed-off-by: Hasan Turken <turkenh@gmail.com>
(cherry picked from commit 8236621)
    @turkenh
    turkenh committed Sep 12, 2023
    Configuration menu
    Copy the full SHA
    724de18 View commit details
    Browse the repository at this point in the history

  8. Add e2e tests for Usage in composition 

    Also:
- Add details annotation and column to Usage
- It should be possible to override REGISTRY_ORGS
- Asses Usage functionality in composition with e2e
- e2e tests with suites

Signed-off-by: Hasan Turken <turkenh@gmail.com>
(cherry picked from commit 4e7889a)
    @turkenh
    turkenh committed Sep 12, 2023
    Configuration menu
    Copy the full SHA
    c2eb1ef View commit details
    Browse the repository at this point in the history

  9. Handle if neither reference nor selector provided 

    Also:
- Resolve comments in Usage
- Remove composite check during deletion

Signed-off-by: Hasan Turken <turkenh@gmail.com>
(cherry picked from commit f7ac2fb)
    @turkenh
    turkenh committed Sep 12, 2023
    Configuration menu
    Copy the full SHA
    8af0b7b View commit details
    Browse the repository at this point in the history

  10. Respect owner ref on Usage in Composite controller 

    Signed-off-by: Hasan Turken <turkenh@gmail.com>
(cherry picked from commit 72011ee)
    @turkenh
    turkenh committed Sep 12, 2023
    Configuration menu
    Copy the full SHA
    4cebd8f View commit details
    Browse the repository at this point in the history

  11. Resolve comments in Usage 

    Signed-off-by: Hasan Turken <turkenh@gmail.com>
(cherry picked from commit 44956a2)
    @turkenh
    turkenh committed Sep 12, 2023
    Configuration menu
    Copy the full SHA
    797b92e View commit details
    Browse the repository at this point in the history

  12. Resolve review comments in Usage 

    Signed-off-by: Hasan Turken <turkenh@gmail.com>
(cherry picked from commit 5f5ed2a)
    @turkenh
    turkenh committed Sep 12, 2023
    Configuration menu
    Copy the full SHA
    112b02d View commit details
    Browse the repository at this point in the history

  13. Workaround for Usage - we don't have Crossplane Runtime fork 

    Signed-off-by: Hasan Turken <turkenh@gmail.com>
    @turkenh
    turkenh committed Sep 12, 2023
    Configuration menu
    Copy the full SHA
    391d78a View commit details
    Browse the repository at this point in the history

  14. Strip out the e2e changes of the Usage PR 

    As it depends on previous refactorings on the master branch
which we don't have on the release branch.

Signed-off-by: Hasan Turken <turkenh@gmail.com>
    @turkenh
    turkenh committed Sep 12, 2023
    Configuration menu
    Copy the full SHA
    c7bf47a View commit details
    Browse the repository at this point in the history