Cherry-pick the ability to disable clusterrole aggregation #63
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hasheddan
approved these changes
Sep 28, 2022
There was a problem hiding this comment.
@muvaf this looks good to me, though I have typically been fast-forwarding master in this repo, then CP'ing the exact commit back to release branches. Since this is a divergence anyway, it doesn't matter too much, but does help us avoid having release branches "ahead" of master, which is tracking upstream 👍🏻
|
@hasheddan That sounds nicer. Let's do it #64 |
… deployed Signed-off-by: Muvaffak Onus <me@muvaf.com>
muvaf
force-pushed
the
sync-upstream-release-1.9
branch
from
8d85274
to
bdd5908
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of your changes
Cherry pick of crossplane/crossplane#3343 . This targets only the
release-1.9branch since it's needed for EKS Addon compatibility and we'll publish only v1.9 and above there. No impact on existing users.I have:
make reviewableto ensure this PR is ready for review.backport release-x.ylabels to auto-backport this PR if necessary.How has this code been tested
Tested in upstream PR, manually by installing the Helm chart and confirming that the changes are effective and existing users are not affected.