Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Sync upstream master #64

Merged
merged 7 commits into from
Sep 28, 2022
Merged

Sync upstream master #64

merged 7 commits into from
Sep 28, 2022

Conversation

muvaf
Copy link
Contributor

@muvaf muvaf commented Sep 28, 2022

Sync master.

hasheddan and others added 6 commits September 23, 2022 09:04
Drops the default imagePullSecret named dockerhub that is set on the
Crossplane ServiceAccount. We don't install a secret named dockerhub and
it now causes package install to fail because the image fetcher cannot
find the dockerhub secret to pull with.

Signed-off-by: hasheddan <georgedanielmangum@gmail.com>
Drop default imagePullSecret dockerhub
Signed-off-by: Andrii Petruk <andrey.petruk@gmail.comm>
… deployed

Signed-off-by: Muvaffak Onus <me@muvaf.com>
Use aggregation in ClusterRole of Crossplane only if rbac-manager is deployed
Copy link
Contributor

@hasheddan hasheddan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @muvaf!

@muvaf muvaf merged commit abdf2b0 into upbound:master Sep 28, 2022
@muvaf muvaf deleted the sync-upstream-master branch September 28, 2022 15:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants