Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix uptest pipeline by utilizing new package-type argument #99

Merged
merged 1 commit into from
Mar 24, 2023
Merged

Fix uptest pipeline by utilizing new package-type argument #99

merged 1 commit into from
Mar 24, 2023

Conversation

ytsarev
Copy link
Member

@ytsarev ytsarev commented Mar 21, 2023 •
edited
Loading

Description of your changes

Fix uptest pipeline by utilizing new package-type argument

Fixes #98

I have:

  • Read and followed Upbound's contribution process.
  • Run make reviewable to ensure this PR is ready for review.
  • Added backport release-x.y labels to auto-backport this PR, as appropriate.

How has this code been tested

by running the pipeline below

@ytsarev
Copy link
Member Author

ytsarev commented Mar 21, 2023

/test-examples

1 similar comment
@ytsarev
Copy link
Member Author

ytsarev commented Mar 21, 2023

/test-examples

@ytsarev
Copy link
Member Author

ytsarev commented Mar 21, 2023

/test-examples

@ytsarev ytsarev changed the title Fix uptest by adding missing conventional go cache targets Fix uptest by consuming the explicit commit of reusable worlkflow Mar 21, 2023
@ytsarev ytsarev requested a review from turkenh March 21, 2023 17:37
@ytsarev ytsarev mentioned this pull request Mar 21, 2023
Closed
@ytsarev
Fix uptest pipeline by utilizing new package-type argument
bf7b47b 
* Consume changes from upbound/official-providers-ci#87

Signed-off-by: Yury Tsarev <yury@upbound.io>
@ytsarev ytsarev changed the title Fix uptest by consuming the explicit commit of reusable worlkflow Fix uptest pipeline by utilizing new package-type argument Mar 23, 2023
@ytsarev
Copy link
Member Author

ytsarev commented Mar 23, 2023

/test-examples

@ytsarev
Copy link
Member Author

ytsarev commented Mar 23, 2023

upbound/official-providers-ci#87 (comment) The relevant tests are there.

Unfortunately, changes from this PR are not getting into action until the merge to main.

@ytsarev ytsarev merged commit e123bb8 into upbound:main Mar 24, 2023
@ytsarev ytsarev deleted the fix-uptest branch March 24, 2023 07:25
This was referenced Apr 26, 2023
Merged
Merged
@haarchri haarchri mentioned this pull request Sep 20, 2023
Merged
2 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@turkenh turkenh turkenh approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Fix uptest pipeline
2 participants
@ytsarev @turkenh