Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix uptest #24

Merged
merged 1 commit into from
Apr 27, 2023
Merged

Fix uptest #24

merged 1 commit into from
Apr 27, 2023

Conversation

ytsarev
Copy link
Member

@ytsarev ytsarev commented Apr 26, 2023

Description of your changes

  • Use package type configuration in e2e GH workflow
  • Make release deletion hook more reliable

I have:

  • Read and followed Upbound's contribution process.
  • Run make reviewable to ensure this PR is ready for review.
  • Added backport release-x.y labels to auto-backport this PR, as appropriate.

How has this code been tested

Uptest invocation will follow below

* Use package type configuration in e2e GH workflow
* Make release deletion hook more reliable

Signed-off-by: Yury Tsarev <yury@upbound.io>
@ytsarev
Copy link
Member Author

ytsarev commented Apr 26, 2023

/test-examples

@ytsarev
Copy link
Member Author

ytsarev commented Apr 26, 2023

We must merge this one to main to make the reusable workflow respect the new configuration.
We have seen this behaviour before upbound/platform-ref-aws#99 (comment)

Copy link
Member

@stevendborrelli stevendborrelli left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants