image_types_ostree: ostree_rmdir_helper: fix regression in removing /var symbolic links #69
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pattivacek
reviewed
Apr 24, 2023
quaresmajose
force-pushed
the
image_types_ostree
branch
from
925ea32 to
96e61de
Compare
quaresmajose
changed the title
…var symbolic links Before the introduction of the ostree_rmdir_helper the '/var' content is removed uncondictional but new they are removed if they are directories and not symbolic link. To make it consistent we will remove everything in '/var' with the exception of 'var/local'. This will also warn about all content deleted from '/var' that has been silent until now so running bitbake in verbose mode will produce: WARNING: lmp-base-console-image-1.0-r0 do_image_ostree: Data in 'var' directory is not preserved by OSTree. Consider moving it under '/usr' var/volatile var/lib var/log var/tmp var/cache + rm -vrf var removed directory 'var/volatile' removed directory 'var/lib' removed 'var/log' removed 'var/tmp' removed directory 'var/cache' removed directory 'var' + mkdir var Signed-off-by: Jose Quaresma <jose.quaresma@foundries.io>
quaresmajose
force-pushed
the
image_types_ostree
branch
from
96e61de to
6cae66f
Compare
Thanks. |
ricardosalveti
pushed a commit
to ricardosalveti/meta-updater-1
that referenced
this pull request
Apr 26, 2023
git log --oneline bf0494df6382dd26e3daa89d57a393c0ff77f7d8..eced3900754b51273733c66588ca44c44ba03b2c eced39007 Merge pull request uptane#76 from shr-project/jansa/gcc-12 567b12b43 Fix build with gcc-12 a57b25061 Merge pull request uptane#69 from uptane/add-tuf-test-same-metadata-version 9d9142e3e Merge pull request uptane#65 from uptane/cmake-shellcheck b5706acb1 Merge pull request uptane#75 from uptane/ats-doc-update 07937a704 tuf-test-vectors: Test update if metadata version is the same 3da96e69e deleted not relevant url ef323b045 Append '.sh' to shell scripts used for testing. bcde05ddd Add CMake command to run shellcheck.
rborn-tx
reviewed
Mar 13, 2024
This was referenced Mar 13, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Before the introduction of the ostree_rmdir_helper the '/var' content is removed uncondictional
but new they are removed if they are directories and not symbolic link.
To make it consistent we will remove everything in '/var' with the exception of 'var/local'.
This will also warn about all content deleted from '/var' that has been silent until now
so running bitbake in verbose mode will produce: