Backport [kirkstone]: image_types_ostree: ostree_rmdir_helper: fix regression in removing /var symbolic links #70
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…var symbolic links Before the introduction of the ostree_rmdir_helper the '/var' content is removed uncondictional but new they are removed if they are directories and not symbolic link. To make it consistent we will remove everything in '/var' with the exception of 'var/local'. This will also warn about all content deleted from '/var' that has been silent until now so running bitbake in verbose mode will produce: WARNING: lmp-base-console-image-1.0-r0 do_image_ostree: Data in 'var' directory is not preserved by OSTree. Consider moving it under '/usr' var/volatile var/lib var/log var/tmp var/cache + rm -vrf var removed directory 'var/volatile' removed directory 'var/lib' removed 'var/log' removed 'var/tmp' removed directory 'var/cache' removed directory 'var' + mkdir var Signed-off-by: Jose Quaresma <jose.quaresma@foundries.io> (cherry picked from commit 6cae66f) Signed-off-by: Jose Quaresma <jose.quaresma@foundries.io>
pattivacek
approved these changes
Apr 25, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Backport #69