Consolidate all App code into Command
#1602
Conversation
|
@meatballhat Perhaps its better to split this into two separate PRs. One to change Subcommands -> Commands and another to merge App into command. |
@dearchap that was my intention when I started, but keeping both |
meatballhat
force-pushed
the
app-command-collapse
branch
from
86018f7 to
5449c6c
Compare
|
@meatballhat One thing that may help is removing ctx from Help and using Command params throughout. That way there are no App/Ctx references anywhere on that portion. If you'd like I can work on that. |
@dearchap that sounds great to me! 🎉 |
help_test.go
Outdated
| @@ -574,58 +574,6 @@ func TestShowCommandHelp_CommandAliases(t *testing.T) { | |||
| } | |||
| } | |||
|
|
|||
| func TestHelpNameConsistency(t *testing.T) { | |||
There was a problem hiding this comment.
@meatballhat Any reason why this was removed ?
There was a problem hiding this comment.
Oh gosh I totally don't remember why I did this 😭 I'm starting over!
There was a problem hiding this comment.
Ooh, I remember! But I'm still starting over 😂 I'll be introducing smaller PRs to do parts of what's discovered here.
|
Superseded by #1746 |
What type of PR is this?
(REQUIRED)
What this PR does / why we need it:
(REQUIRED)
Which issue(s) this PR fixes:
(REQUIRED)
Fixes #1586
Special notes for your reviewer:
(fill-in or delete this section)
Testing
(fill-in or delete this section)
Release Notes
(REQUIRED)