-
Notifications
You must be signed in to change notification settings - Fork 1.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Consolidate all App
code into Command
#1746
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
includes adding internal `tracef` func
plus delete accidentally-added binary
including removal of the `Commands` slice type, replacing the `Command.HelpName` field with a `Command.FullName()` method
meatballhat
added
kind/feature
describes a code enhancement / feature request
kind/cleanup
describes internal cleanup / maintaince
area/v3
relates to / is being considered for v3
labels
Jun 9, 2023
and separate test package to ensure public API usage
and remove duplicates
because it is not used internally anymore
dearchap
reviewed
Jun 12, 2023
dearchap
reviewed
Jun 12, 2023
dearchap
reviewed
Jun 12, 2023
dearchap
reviewed
Jun 12, 2023
dearchap
reviewed
Jun 12, 2023
dearchap
previously approved these changes
Jun 12, 2023
dearchap
approved these changes
Jun 13, 2023
dearchap
approved these changes
Jun 13, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
area/v3
relates to / is being considered for v3
kind/cleanup
describes internal cleanup / maintaince
kind/feature
describes a code enhancement / feature request
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What type of PR is this?
What this PR does / why we need it:
In addition to what is described in #1586, this change:
Command.Root()
method for returning the "root command" (previously what wasApp
) which is generally used to get the "root Writer". I'd like to make this access more sugary thancCtx.Command.Root().Writer
onceContext
andCommand
are collapsed 🤞🏼Run
method that accepts only stdlibcontext.Context
and a string slice likeos.Args
Commands
type alias for[]*Command
tracef
func for runtime tracing to aid with development, testing, and debuggingtestify/require
expectFileContent
fromfish_test.go
tocli_test.go
and modifies it to usetestify/require
HelpName
string withFullName
method, which also removes the ability to customize the name used for a command in help text./cmd/
Which issue(s) this PR fixes:
Closes #1586