Ask users for go list ... output
#967
Conversation
!!! I'll think on this 🤔 |
Codecov Report
@@ Coverage Diff @@
## master #967 +/- ##
=======================================
Coverage 73.36% 73.36%
=======================================
Files 32 32
Lines 2440 2440
=======================================
Hits 1790 1790
Misses 540 540
Partials 110 110Continue to review full report at Codecov.
|
| ## Run `go list -u -m all` and paste its output here | ||
|
|
||
| ``` | ||
| # paste `go list -u -m all` output in here |
There was a problem hiding this comment.
~ $ go list -u -m all
warning: pattern "all" matched no module dependencies
What is this supposed to do?
There was a problem hiding this comment.
Ok, we have to be more explicit where this needs to be run. This also can be pretty big, are we sure we want everything?
What are we trying to answer here?
There was a problem hiding this comment.
What is this supposed to do?
I added that into my pull request description
❯ go list -u -m all
go: finding github.com/cpuguy83/go-md2man/v2 v2.0.0
go: finding gopkg.in/check.v1 latest
go: finding gopkg.in/yaml.v2 v2.2.7
github.com/urfave/cli/v2
github.com/BurntSushi/toml v0.3.1
github.com/cpuguy83/go-md2man/v2 v2.0.0-20190314233015-f79a8a8ca69d [v2.0.0]
github.com/pmezard/go-difflib v1.0.0
github.com/russross/blackfriday/v2 v2.0.1
github.com/shurcooL/sanitized_anchor_name v1.0.0
gopkg.in/check.v1 v0.0.0-20161208181325-20d25e280405 [v1.0.0-20190902080502-41f04d3bba15]
gopkg.in/yaml.v2 v2.2.2 [v2.2.7]
did you run it inside of a golang github repo? what go version are you using?
This also can be pretty big, are we sure we want everything?
Yes
What are we trying to answer here?
The versions of your dependencies. Most critically the version of urfave/cli
There was a problem hiding this comment.
I think we can pipe this to grep urfave/cli to just focus on the version of our package.
|
🕙 closing due to age (and my attention span) |
I noticed via these two issues #964, #957 that people are liking to just say "v1" or "v2" which sometimes won't be enough detail. Other times, it won't be correct!
So I've changed the issue template to instead prompt for
go list -u -m all, which looks like this😍 beautiful! so much information!