Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ask users for go list ... output #967

Closed
wants to merge 4 commits into from
Closed

Ask users for go list ... output #967

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
473f305
Update v1-bug-report.md
coilysiren Nov 29, 2019
8f2547e
Update v2-bug-report.md
coilysiren Nov 29, 2019
2e5d43c
Update v2-bug-report.md
coilysiren Nov 29, 2019
9b5bcdd
Merge branch 'master' into go-list-all
coilysiren Dec 4, 2019
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 6 additions & 4 deletions .github/ISSUE_TEMPLATE/v1-bug-report.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,10 +7,6 @@ assignees: lynncyrin

---

## my urfave/cli version is

_**( Put the version of urfave/cli that you are using here )**_

## Checklist

* [ ] Are you running the latest v1 release? The list of releases is [here](https://github.com/urfave/cli/releases).
Expand Down Expand Up @@ -59,3 +55,9 @@ We'd love to have more contributors on this project! If the fix for this bug is
```
# paste `go env` output in here
```

## Run `go list -u -m all` and paste its output here

```
# paste `go list -u -m all` output in here
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more. 

~ $ go list -u -m all
warning: pattern "all" matched no module dependencies

What is this supposed to do?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ok, we have to be more explicit where this needs to be run. This also can be pretty big, are we sure we want everything?
What are we trying to answer here?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What is this supposed to do?

I added that into my pull request description

❯ go list -u -m all
go: finding github.com/cpuguy83/go-md2man/v2 v2.0.0
go: finding gopkg.in/check.v1 latest
go: finding gopkg.in/yaml.v2 v2.2.7
github.com/urfave/cli/v2
github.com/BurntSushi/toml v0.3.1
github.com/cpuguy83/go-md2man/v2 v2.0.0-20190314233015-f79a8a8ca69d [v2.0.0]
github.com/pmezard/go-difflib v1.0.0
github.com/russross/blackfriday/v2 v2.0.1
github.com/shurcooL/sanitized_anchor_name v1.0.0
gopkg.in/check.v1 v0.0.0-20161208181325-20d25e280405 [v1.0.0-20190902080502-41f04d3bba15]
gopkg.in/yaml.v2 v2.2.2 [v2.2.7]

did you run it inside of a golang github repo? what go version are you using?

This also can be pretty big, are we sure we want everything?

Yes

What are we trying to answer here?

The versions of your dependencies. Most critically the version of urfave/cli

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think we can pipe this to grep urfave/cli to just focus on the version of our package.

```
11 changes: 7 additions & 4 deletions .github/ISSUE_TEMPLATE/v2-bug-report.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,10 +7,6 @@ assignees: ''

---

## my urfave/cli version is

_**( Put the version of urfave/cli that you are using here )**_

## Checklist

* [ ] Are you running the latest v2 release? The list of releases is [here](https://github.com/urfave/cli/releases).
Expand Down Expand Up @@ -47,6 +43,7 @@ If you can reproduce this issue with a public CI system, please link a failing b
## Want to fix this yourself?

We'd love to have more contributors on this project! If the fix for this bug is easily explained and very small, free free to create a pull request for it.

## Run `go version` and paste its output here

```
Expand All @@ -58,3 +55,9 @@ We'd love to have more contributors on this project! If the fix for this bug is
```
# paste `go env` output in here
```

## Run `go list -u -m all` and paste its output here

```
# paste `go list -u -m all` output in here
```