Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

VOTE-2587 Config, templates and po file changes related to string migration #1049

Merged
merged 15 commits into from
Nov 14, 2024

Conversation

rayestrada
Copy link
Contributor

@rayestrada rayestrada commented Oct 16, 2024

Jira ticket

https://cm-jira.usa.gov/browse/VOTE-2587

Description

This PR has 3 objectives:

  1. Replace current hardcoded strings in templates with the dynamic variables
  2. Add a new 'Submit button label' field for hardcoded string for search component.
  3. Remove translations from the po files.

Deployment and testing

Post-deploy steps

  1. Pull the latest db from prod to local
  2. lando retune

QA/Testing instructions

  1. visit http://vote-gov.lndo.site/media/add/image and make sure the caption field only accepts simple formatting options
  2. visit https://vote-gov.lndo.site/admin/content/block/2 and add a Submit Button Label
  3. Test the display of each of these components for migrated content
  • Email sign up block
  • government banner block
  • search component block
  • contact identifier block
  • partnership block
  • registration tool paragraph

Checklist for the Developer

  • A link to the JIRA ticket has been included above.
  • No merge conflicts exist with the target branch.
  • Automated tests have passed on this PR.
  • A reviewer has been designated.
  • Deployment and testing steps have been documented above, if applicable.

Checklist for the Peer Reviewers

  • The file changes are relevant to the task objective.
  • Code is readable and includes appropriate commenting.
  • Code standards and best practices are followed.
  • QA/Test steps were successfully completed, if applicable.
  • Applicable logs are free of errors.

@rayestrada rayestrada changed the title Feature/vote 2587 string templates VOTE-2587 string templates Nov 5, 2024
@rayestrada rayestrada changed the title VOTE-2587 string templates VOTE-2587 Config, templates and po file changes related to string migration Nov 5, 2024
@rayestrada rayestrada marked this pull request as ready for review November 5, 2024 05:03
@rayestrada
Copy link
Contributor Author

I've added new size styles for the imgs. I've also removed the alt text for the U.S.Flag icon and made that decorative following recent updates to the USWDS banner https://designsystem.digital.gov/components/banner/.

@SamiraMSadat SamiraMSadat merged commit e9e81ff into dev Nov 14, 2024
2 checks passed
@rayestrada rayestrada deleted the feature/VOTE-2587-string-templates branch December 3, 2024 18:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants