-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
VOTE-2587 Config, templates and po file changes related to string migration #1049
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rayestrada
changed the title
Feature/vote 2587 string templates
VOTE-2587 string templates
Nov 5, 2024
rayestrada
changed the title
VOTE-2587 string templates
VOTE-2587 Config, templates and po file changes related to string migration
Nov 5, 2024
Limit image captions to simple format
SamiraMSadat
requested changes
Nov 7, 2024
web/themes/custom/votegov/templates/block/block-content--partnership.html.twig
Show resolved
Hide resolved
web/themes/custom/votegov/templates/block/block-content--partnership.html.twig
Show resolved
Hide resolved
Remove alt text for us flag and make it decorative
I've added new size styles for the imgs. I've also removed the alt text for the U.S.Flag icon and made that decorative following recent updates to the USWDS banner https://designsystem.digital.gov/components/banner/. |
SamiraMSadat
approved these changes
Nov 14, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Jira ticket
https://cm-jira.usa.gov/browse/VOTE-2587
Description
This PR has 3 objectives:
Deployment and testing
Post-deploy steps
lando retune
QA/Testing instructions
Checklist for the Developer
Checklist for the Peer Reviewers