Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

VOTE-2180 hero component styling updates #788

Merged
merged 1 commit into from
Jun 26, 2024

Conversation

rayestrada
Copy link
Contributor

@rayestrada rayestrada commented Jun 26, 2024

Jira ticket

VOTE-2006
VOTE-2110
VOTE-2084
VOTE-2180

Description

  • Homepage hero changes
  • Hero high contrast changes
  • Adding new 'homepage' variant to paragraph
  • Adding breadcrumbs to hero for 'dark' variant

Deployment and testing

Post-deploy steps

  1. run npm run build in votegov theme
  2. run lando retune

QA/Testing instructions

  1. login and visit http://vote-gov.lndo.site/node/91/edit
  2. Upload new homepage hero image located in the VOTE-2180 ticket and select the background color "homepage" and save
  3. visit http://vote-gov.lndo.site/ and confirm the styling matches the figma design
  4. switch to high contrast and confirm it matches figma design
  5. Add arabic translation of homepage and test hero in normal and high contrast
  6. visit http://vote-gov.lndo.site/node/78/edit and upload a test image and select the background color "dark" and save
  7. visit http://vote-gov.lndo.site/guide-voting and confirm the breadcrumb is displaying
  8. test in normal and high contrast
  9. visit http://vote-gov.lndo.site/node/82/edit and upload a test image
  10. visit http://vote-gov.lndo.site/voting-college-student and test in normal and high contrast

Checklist for the Developer

  • A link to the JIRA ticket has been included above.
  • No merge conflicts exist with the target branch.
  • Automated tests have passed on this PR.
  • A reviewer has been designated.
  • Deployment and testing steps have been documented above, if applicable.

Checklist for the Peer Reviewers

  • The file changes are relevant to the task objective.
  • Code is readable and includes appropriate commenting.
  • Code standards and best practices are followed.
  • QA/Test steps were successfully completed, if applicable.
  • Applicable logs are free of errors.

Copy link
Contributor

@mlloydbixal mlloydbixal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I sent a message on teams about the breadcrumb link text color

@mlloydbixal mlloydbixal merged commit 4b39d82 into dev Jun 26, 2024
3 checks passed
@rayestrada rayestrada deleted the feature/VOTE-2180-homepage-hero branch July 2, 2024 23:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants